Review Request JDK-8182416: Clean up module-info.java like move requires transitive adjacent to exports

Alan Bateman Alan.Bateman at oracle.com
Sat Jun 17 14:26:44 UTC 2017


On 17/06/2017 07:27, Mandy Chung wrote:
> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182416/webrev.00/
>
> This patch cleans up module-info.java mainly moving requires transitive
> before exports, group exports/opens (packages) together and uses/provides
> (services) next.
>
> Document if a module is upgradeable.
>
> jdeps —-generate-module-info is also updated to list requires transitive
> before exports.
>
This looks okay to me, I just wonder if jdk.xml.ws and jdk.xml.bind 
modules need the upgradeable note given that they aren't standard modules.

A minor nit in java.corba where it has "<p>This ...". All the others 
have a space.

For jdeps then should it emit a blank line between the groupings to be 
consistent with the proposed layout?

-Alan




More information about the jigsaw-dev mailing list