RFR(S) : 8177374 : fix module dependency declaration in jdk_svc tests

Igor Ignatyev igor.ignatyev at oracle.com
Wed Mar 22 23:09:57 UTC 2017


Hi Mandy,
 
I've (re)sorted @modules in all the tests which I touched -- http://cr.openjdk.java.net/~iignatyev/8177374/webrev.01/index.html <http://cr.openjdk.java.net/~iignatyev/8177374/webrev.01/index.html>

> test/java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java
>   This test should need java.management.  Where is it declared?
it's declared in test/java/lang/management/TEST.properties which has been pushed by JDK-8176176.

Thanks,
-- Igor
> On Mar 22, 2017, at 2:01 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
> 
> 
>> On Mar 22, 2017, at 1:09 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>> 
>> http://cr.openjdk.java.net/~iignatyev/8177374/webrev.00/index.html
>>> 40 lines changed: 26 ins; 13 del; 1 mod;
>> 
>> Hi all,
>> 
>> could you please review this changeset which fixes in a few jdk_svc tests which were missed by JDK-8176176[1]?
>> 
>> testing: :jdk_svc tests
>> webrev: http://cr.openjdk.java.net/~iignatyev/8177374/webrev.00/index.html
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8177374
> 
> 
> test/java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java
>   This test should need java.management.  Where is it declared?
>   Does the webrev miss some new file?
> 
> Can you keep @modules sorted? e.g. the following in a few files:
>  42  * @modules jdk.management.agent/jdk.internal.agent
>  43  *          java.management
>  44  *          jdk.attach
> Mandy
> 



More information about the jigsaw-dev mailing list