Review Request: JDK-8173303: Add module-subgraph images to main platform documentation

[Philip Race]

123             "fontname", "DejaVuSans bold",

Even if this gets consumed only during the build environment
by some tool it supposes that string means something to
either the tool or the OS. Unless one of those parses "bold"
out of the string and interprets it as a style request then
I don't see this doing what you intend. It probably works on
Linux + Solaris but not anywhere else.

-phil.

On 3/26/17, 9:51 AM, Alan Bateman wrote:
> On 25/03/2017 21:33, Mandy Chung wrote:
>
>> I edited the module descriptions per your feedback.  I also revised
>> GenGraphs tool to take a properties file to customize the dot graphs
>> for javadoc use.
>>
>> Updated webrev:
>>    http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173303/webrev.02/
>>
> The updated descriptions look good. For jdk.charsets then I think we 
> would parentheses around "mostly double byte and IBM charsets". I went 
> through the updated GenGraphs tools too and it looks good.
>
> -Alan