RFR 8189671: jlink should clearly report error when an automatic module is used as root

[mandy chung]

On 10/19/17 7:04 AM, Sundararajan Athijegannathan wrote:
> Please review.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8189671
> Webrev: http://cr.openjdk.java.net/~sundar/8189671/webrev.00/
>
441 ModuleFinder finder = config.finder();
442 for (String root : config.getModules()) { This should check the 
resolved modules rather than just the root modules since a resolved 
module may be an automatic module but not a root. You may want to add 
such a test case too. (A side note: JlinkConfiguration::getModules 
perhaps should be renamed to `roots` since it returns the root modules 
specified in jlink --add-modules)
447 throw new 
IllegalArgumentException(taskHelper.getMessage("err.automatic.module.as.root", 
modDesc.name())); It may be useful to include the pathname to the 
exception message. Nit: long line and good to wrap it into multiple 
lines. Mandy