RFR 8189777: jlink --module-path default value and automatic addition of $JAVA_HOME/jmods if java.base is missing

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Mon Oct 23 10:37:21 UTC 2017


Updated for getDefaultModulePath. moduleFinder uses three instance 
fields - modulepaths, limitmods and modules. We may have to pass all to 
the static method...

http://cr.openjdk.java.net/~sundar/8189777/webrev.01

Thanks
-Sundar

On 23/10/17, 1:11 PM, Alan Bateman wrote:
> On 23/10/2017 06:37, Sundararajan Athijegannathan wrote:
>> Please review.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8189777
>> Webrev: http://cr.openjdk.java.net/~sundar/8189777/webrev.00/
> This patch is very welcome as it makes jlink easier to use without any 
> impact to the cross building case.
>
> Two small comments:
>
> - getStandardModulePath might be better renamed getDefaultModulePath 
> as it isn't standard.
>
> - JlinkConfiguration calls moduleFinder() during construction. You can 
> avoid this by adding a static ModuelFinder moduleFinder(List<Path>).
>
> -Alan


More information about the jigsaw-dev mailing list