JDK-8170120 jimage IOException solution?

[Michal Vala]

On 02/17/2018 08:17 AM, Alan Bateman wrote:
> On 16/02/2018 14:39, Michal Vala wrote:
>> :
>>
>> That sounds reasonable. Here's the webrev: 
>> http://cr.openjdk.java.net/~shade/8170120/webrev.01/
>>
>> It fixes JImageVerifyTest so I've removed it from ProblemList.
>>
>>
>> note: JImageExtractTest still failing on not-empty-dir(JDK-8170114) and 
>> JImageListTest fails on simplest list test. I'll take a look at it later.
>>
> The changes look good, I just wonder if it would be better to specify {0} as 
> file rather than file.getName(). Just thinking about a script running this tool 
> failing because the file path is wrong, I think it could be useful to have it in 
> error.

Yes, true. Attached.

> 
> -Alan
> 

-- 
Michal Vala
OpenJDK QE
Red Hat Czech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jdk.patch
Type: text/x-patch
Size: 1497 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/jigsaw-dev/attachments/20180219/e6e9cc44/jdk.patch>