ModuleLayer#layers() and Configuration#configurations() produces non-topological ordering

David Lloyd david.lloyd at redhat.com
Fri Jun 15 14:25:36 UTC 2018


On Thu, Jun 14, 2018 at 10:37 PM, Luke Hutchison <luke.hutch at gmail.com> wrote:

> The list allLayers should be changed to a LinkedList, allowing nodes to be
> pushed onto the beginning of the list, so that the ordering doesn't have to

A small quibble: LinkedList should normally never be used.  You can
push things on to the beginning of an ArrayDeque (it is a double-ended
queue after all).

> longer be inverted, since we're not using a FIFO stack to process parents

A stack would be LIFO.  But at any rate the above comment applies:
anything LinkedList can do, ArrayDeque can probably do better.
-- 
- DML


More information about the jigsaw-dev mailing list