Review Request JDK-8200121: Remove unused qualified exports in java.base

Lance Andersen lance.andersen at oracle.com
Fri Jun 15 19:37:45 UTC 2018


Hi Mandy

The test that was added seems fine.

Best
Lance
> On Jun 15, 2018, at 3:14 PM, mandy chung <mandy.chung at oracle.com> wrote:
> 
> Alan, Lance,
> 
> I added a test case for JDK-8205116 in test/langtools/tools/jdeps/Options.java.
> 
> Updated webrev for JDK-8205116 only:
>   http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8205116/webrev.01/
> 
> Mandy
> 
> On 6/15/18 10:47 AM, Alan Bateman wrote:
>> On 15/06/2018 17:34, mandy chung wrote:
>>> A simple cleanup to remove unused qualified exports in java.base.
>>> 
>>> The webrev also includes a fix for JDK-8205116 (jdeps --system $java.home fails) that I uncovered through this process where I ran `jdeps --check java.base --system $java.home` on the JDK binaries on several platforms.
>>> 
>>> Webrev at:
>>> http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8200121/webrev.00/
>> Looks good.
>> -Alan

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>





More information about the jigsaw-dev mailing list