RFR 8220700: jlink generated launcher script needs quoting to avoid parameter expansion

sundararajan.athijegannathan at oracle.com sundararajan.athijegannathan at oracle.com
Wed Aug 21 11:33:02 UTC 2019


Thanks Severin for your test improvement suggestion!

Updated: http://cr.openjdk.java.net/~sundar/8220700/webrev.02/index.html

PS. This email is in response to 
https://mail.openjdk.java.net/pipermail/jigsaw-dev/2019-August/014273.html 
For some reason, I didn't get Severin's email. Checked it by list archive!

Thanks,

-Sundar

On 21/08/19 12:23 pm, sundararajan.athijegannathan at oracle.com wrote:
> Updated to add a test:
>
> http://cr.openjdk.java.net/~sundar/8220700/webrev.01
>
> PS. There are launcher tests in BasicTest.java and arguments are 
> passed even - but args are only printed. The new test passes args and 
> checks the return value that is computed using the args.
>
> Thanks,
>
> -Sundar
>
> On 20/08/19 10:07 pm, Alan Bateman wrote:
>> On 20/08/2019 17:25, Mandy Chung wrote:
>>> +1
>>>
>>> What we really want is to replace this stop-gap shell script some 
>>> day with jlink to generate the native launcher [1].
>> I agree. One other thing for stop-gap is a test as we could easily 
>> regress without any of the existing tests catching it.
>>
>> -Alan


More information about the jigsaw-dev mailing list