RFR: 8218913: Rename --strip-debug jlink plugin

Severin Gehwolf sgehwolf at redhat.com
Fri Feb 15 16:12:23 UTC 2019


Hi Alan,

On Fri, 2019-02-15 at 15:57 +0000, Alan Bateman wrote:
> On 15/02/2019 12:15, Severin Gehwolf wrote:
> > :
> > Here is the latest webrev:
> > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8218913/02/webrev/
> > 
> > It uses --strip-java-debug-attributes as discussed in [1]. The --list-
> > plugins output for --strip-debug and --strip-java-debug-attributes
> > reads as follows:
> > 
> > Plugin Name: strip-debug
> > Option: --strip-debug
> > Description: Strip debug information from the output image
> > 
> > Plugin Name: strip-java-debug-attributes
> > Option: --strip-java-debug-attributes
> > Description: Strip Java debug attributes from classes in the output image
> > 
> This looks good to me. One minor point is that try to discourage @author 
> tags in source files these days.

Thanks for the review! I've remove the @author tag:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8218913/03/webrev/

Thanks,
Severin



More information about the jigsaw-dev mailing list