RFR(S): 8219142: Make libjimage strncpy uses GCC 8.x friendly

[James Laskey]

I wonder if you should flag overflow so no attempt is made to search with a bogus path. It’s not necessary but prevent future misunderstandings. 

Sent from my iPhone

> On Feb 15, 2019, at 5:24 PM, Mikael Vidstedt <mikael.vidstedt at oracle.com> wrote:
> 
> 
> Please review this change which addresses some warnings generated by GCC 8.2 related to the uses of strncpy in libjimage/imageFile.cpp.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8219142
> Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8219142/webrev.00/open/webrev/ <http://cr.openjdk.java.net/~mikael/webrevs/8219142/webrev.00/open/webrev/>
> 
> 
> In addition to feedback on the change itself, I’m taking suggestions on what tests to run. An earlier version of the change passed the typical tier1 testing. I’m going to run tier1 on this version as well, but let me know if there are additional tests I should run.
> 
> Cheers,
> Mikael
>