Help with build changes for: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

[Severin Gehwolf]

On Mon, 2019-01-28 at 14:40 +0000, Alan Bateman wrote:
> On 28/01/2019 09:26, Severin Gehwolf wrote:
> > :
> > > I skimmed the current patch and I see the usability has improved since
> > > the original proposal. It would be nice to get to
> > > `--strip-native-debug-symbols` without needing the "=defaults" suffix.
> > > There are details around the sub-options and naming that I assume will
> > > need detailed review at some point too.
> > 
> > This sounds like a different patch to me, I'll investigate.
> > 
> 
> If the common case is to not require any complicated options then 
> `--strip-native-debug-symbols` would be nice and would be consistent 
> with the existing `--strip-XXXX` options. The cross targeting case, or 
> cases where debuginfo options are need, would of course mean a more 
> complicated command.

Yes, but I was referring to the current state of the jlink plugin
system. AFAIK, there is two --strip-XXX plugins:
StripNativeCommandsPlugin and StripDebugPlugin. Both of these have
hasArguments() == false. This new one has hasArguments() == true. Then
the plugin system wants at least 1 argument.

What has to be implemented first is a way for a plugin to allow both:
no-args *and* 1+ args. Currently it's 1+ args XOR 0 args. This
functionality doesn't seem related to this particular patch but would
be generic.

Thanks,
Severin