RFR 8216535: tools/jimage/JImageExtractTest.java timed out

Mandy Chung mandy.chung at oracle.com
Fri May 31 02:43:40 UTC 2019


Hi Sundar,

On 5/30/19 10:12 AM, Sundararajan Athijegannathan wrote:
> Please review.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8216535
> Webrev: https://cr.openjdk.java.net/~sundar/8216535/webrev.00/
>

Looks okay.

It seems cleaner to have a new JImageCliTest constructor that takes the 
path to ${java.home} for jimage tests and this JImageExtractTest to call 
this superclass constructor.

> I'm creating a small jre image with just java.base and jdk.zipfs 
> modules it. The lib/modules of that small jre is extracted for the 
> test purpose. This reduces time taken -  elapsed time in jtreg log is 
> 26656 vs 83445 (earlier). I hope this should solve timeout issues seen 
> in the test runs.
>

It might be useful to instrument and print the jimage execution time to 
prepare for the future diagnosis.

Mandy


More information about the jigsaw-dev mailing list