8233922: Service binding augments module graph with observable incubator modules

Chris Hegarty chris.hegarty at oracle.com
Tue Nov 19 12:43:33 UTC 2019



> On 18 Nov 2019, at 12:34, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
> ...
>   http://cr.openjdk.java.net/~alanb/8233922/webrev/

I think this looks ok.

The original patch that added incubator module support had similar changes ( to exclude incubator modules from service binding ), but it impacted on the public Configuration::resolveAndBind ( so backed away from doing this ). Your changes to limit this to the boot layer are good ( since it is unlikely to be a more general issue ).

I’m surprise to see the resolver use `mres.hasIncubatingWarning() == false`, rather than ModuleResolution.doNotResolveByDefault(mres).

-Chris.






More information about the jigsaw-dev mailing list