8233922: Service binding augments module graph with observable incubator modules

[Alan Bateman]

On 19/11/2019 14:27, Chris Hegarty wrote:
> :
> The original design of ModuleResolution intended do-not-resolve-by-default to be consulted by the resolver when making decisions about whether or not to include the module in the resolution process by default.
>
> The warn-if-resolved value was intended to be used by tools and the launcher, to provide a warning reason if the module in question was resolved.
>
The resolver has never used the ModuleResolution attribute during 
resolution or service binding before now. To date, we've used the 
do-no-resolve-by-default to exclude modules that export an API from the 
default set of root modules. The semantics that we want for service 
binding is to say whether the module participates or not, maybe you are 
thinking we should expand the meaning of this flag to beyond the default 
modules case?

I remember the warning reasons although I don't think it's possible to 
create an incubator module without the warn-incubating flag. The 
warn-incubating is the only way to know if a module is an incubator module.

-Alan