RFR: 8242039: Improve jlink VersionPropsPlugin

mark.reinhold at oracle.com mark.reinhold at oracle.com
Tue Apr 7 21:39:13 UTC 2020


2020/4/3 6:36:53 -0700, christoph.langer at sap.com:
> 2020/4/2 14:12:54 -0700, mark.reinhold at oracle.com:
>> I thought about doing this when I originally wrote that plugin, but it’s
>> so awkward to achieve with ASM -- as demonstrated by your patch -- that
>> I concluded it wasn’t worth it.  Who will notice an extra pop in a basic
>> block that’s only ever executed once?  Is the complexity of this new
>> code worth the benefit?
> 
> Well, first I started playing with this and got a bit obsessed to find
> optimizations in that area. (I learned quite a bit about java asm.)
> It would be of higher (micro-)benefit for common VM startup if the
> fields to be modified could be final but that's even more awkward to
> do and requires intricate knowledge and assumptions about how
> VersionProps.java is structured. So I decided against messing with
> that.
> 
> Eventually I came up with this result and then I also asked myself the
> question whether the new complexity was worth the benefit. I answered
> myself with a yes (though definitely not a clear one ��), and that's
> why I proposed the change. After all, the new complexity isn't huge...
> 
> So, would that be your terminal veto or could you imagine accepting
> the change?

I won’t veto it.

- Mark


More information about the jigsaw-dev mailing list