RFR (T): 8242846: removed an empty file test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java

Ao Qi aoqi at loongson.cn
Mon Apr 20 15:00:18 UTC 2020


Hi Alan and Sundar,


Thanks for the advice. I will take a look at if the test should be 
brought back.


Cheers,

Ao Qi


On 2020/4/20 下午6:32, sundararajan.athijegannathan at oracle.com wrote:
> Hi Alan,
>
> I don't remember it now. Likely a mistake. The changeset
>
> http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/a066fe7b1b42
>
> has that file. Perhaps it may be useful to restore & check if the test 
> passes.
>
> Thanks,
>
> -Sundar
>
> On 18/04/20 3:32 pm, Alan Bateman wrote:
>>
>> Sundar - do you recognize this? I assume truncating this test to 0 
>> bytes was a mistake but I can't tell if the test should be brought 
>> back or not (to ensure that`jlink --order-resources` is tested).
>>
>> -Alan
>>
>> On 17/04/2020 11:34, Ao Qi wrote:
>>> Hi,
>>>
>>> The original email is waiting for moderator approval. Subscribed to
>>> jigsaw-dev and resent the RFR (cc'ed core-libs-dev).
>>>
>>> Thanks,
>>> Ao Qi
>>>
>>> On Wed, Apr 15, 2020 at 10:11 PM Ao Qi <aoqi at loongson.cn> wrote:
>>>> Hi all,
>>>>
>>>> test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java was changed
>>>> to an empty file by JDK-8162538, but not removed. I think we should
>>>> remve this file.
>>>>
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8242846
>>>> webrev: http://cr.openjdk.java.net/~aoqi/8242846/webrev.00/
>>>>
>>>> Thanks,
>>>> Ao Qi
>>



More information about the jigsaw-dev mailing list