RFR (T): 8242846: Bring back test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java (was: Re: RFR (T): 8242846: removed an empty file test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java)

[sundararajan.athijegannathan at oracle.com]

Looks good

-Sundar

On 27/04/20 12:24 pm, Ao Qi wrote:
> On Sun, Apr 26, 2020 at 12:00 AM Alan Bateman <Alan.Bateman at oracle.com> wrote:
>> On 21/04/2020 04:58, Ao Qi wrote:
>>> On 2020/4/20 下午9:27, Alan Bateman wrote:
>>>> On 20/04/2020 11:32, sundararajan.athijegannathan at oracle.com wrote:
>>>>> Hi Alan,
>>>>>
>>>>> I don't remember it now. Likely a mistake. The changeset
>>>>>
>>>>> http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/a066fe7b1b42
>>>>>
>>>>> has that file. Perhaps it may be useful to restore & check if the
>>>>> test passes.
>>>> Yes. I think it was the only test for this jlink option so let's
>>>> bring it back or replace it.
>>>>
>>> I think the test should be brought back. I restored the test and it
>>> didn't pass. Here is the diff against the original test[1]:
>>> http://cr.openjdk.java.net/~aoqi/8242846/diff.01, and the new webrev
>>> is http://cr.openjdk.java.net/~aoqi/8242846/webrev.01/ . I'm not
>>> familiar with this field, so I am not sure I fix this rightly.
>> Thanks, I think this looks okay.
> Thanks, Alan. I have updated the bug title. Is another review needed?
>
> Cheers,
> Ao Qi
>
>> -Alan.