Review Request 8240910: jmod rejects duplicate entries in --class-path jars

Lance Andersen lance.andersen at oracle.com
Thu May 7 20:48:14 UTC 2020


Hi Mandy,

The extra updates look good.  Thank you for adding the additional clean up!

Best
Lance

> On May 7, 2020, at 2:39 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
> 
> I have taken a further step to clean this up by recording the written entries such that it can filter out duplicated entries properly:
> 
> http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8240910/webrev.01/
> 
> thanks
> Mandy
> 
> On 5/7/20 10:12 AM, Mandy Chung wrote:
>> jmod tool should ignore duplicated resources from class path and emit a warning.  It currently ignores duplicated resources when read from a directory but not from JAR entries.  It's an oversight from the fix for JDK-8134779 [1]
>> 
>> http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8240910/webrev.00/
>> 
>> This is a simple fix applying the same fix for JDK-8134779 to ignore duplicated entries processed from a JAR file.
>> 
>> Thanks
>> Mandy
>> [1] https://bugs.openjdk.java.net/browse/JDK-8134779
> 

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>





More information about the jigsaw-dev mailing list