Review request: JMC-5859: Upgrade to Tycho 1.2.0 with class loader hook for javafx-swt.jar

Jayathirth D V jayathirth.d.v at oracle.com
Fri Aug 10 08:27:30 UTC 2018


Hi Guru,

 

Changes are fine.

 

Thanks,

Jay

 

From: Marcus Hirt 
Sent: Thursday, August 09, 2018 10:41 PM
To: Guru; jmc-dev at openjdk.java.net
Cc: Jayathirth D V; Klara Ward; Sharath Ballal; Viplove Paliwal
Subject: Re: Review request: JMC-5859: Upgrade to Tycho 1.2.0 with class loader hook for javafx-swt.jar

 

Looks good. I’d consider dropping JMC from the class names though. No new review necessary if you do change the class names.

 

/M

 

From: Guru <HYPERLINK "mailto:guru.hb at oracle.com"guru.hb at oracle.com>
Date: Thursday, 9 August 2018 at 18:40
To: <HYPERLINK "mailto:jmc-dev at openjdk.java.net"jmc-dev at openjdk.java.net>, Marcus Hirt <HYPERLINK "mailto:marcus.hirt at oracle.com"marcus.hirt at oracle.com>
Cc: Jayathirth D V <HYPERLINK "mailto:jayathirth.d.v at oracle.com"jayathirth.d.v at oracle.com>, Klara Ward <HYPERLINK "mailto:klara.ward at oracle.com"klara.ward at oracle.com>, Sharath Ballal <HYPERLINK "mailto:sharath.ballal at oracle.com"sharath.ballal at oracle.com>, Viplove Paliwal <HYPERLINK "mailto:viplove.p.paliwal at oracle.com"viplove.p.paliwal at oracle.com>
Subject: Review request: JMC-5859: Upgrade to Tycho 1.2.0 with class loader hook for javafx-swt.jar

 

Hi Marcus,

 

Please review the fix for 

JBS : https://bugs.openjdk.java.net/browse/JMC-5859

Webrev : http://cr.openjdk.java.net/~ghb/JMC-5859/webrev.0/

 

RC and Solution is updated in JBS.

 

Thanks,

Guru


More information about the jmc-dev mailing list