[PATCH] JMC-5128/JMC-5149 - Utilize EventThread field in GC Phase Events

[Joshua Matsuoka]

Hi Marcus,

Thanks for the feedback!

I was following the suggestions in the comments/history on
https://bugs.openjdk.java.net/browse/JMC-5128 . I think there's value to
having the thread lane able to be visualized alongside the rest of the GC
information. It's nice being able to see the thread events/activity align
with the pause visualization and heap activity. I can also seeing this be
useful for users who may have custom events defined, where it may be useful
to see these events alongside the heap/gc behaviour.  I noticed as well
that the thread activity display on the Java Application page lacks the
context menu options to display additional types of events in the
visualization. Perhaps if we feel that these changes are unnecessary, I can
make an additional patch that could add that functionality to the thread
lane on the application page. In either case though, we should probably
still add the event thread to the information displayed for pause events.

Cheers,

- Josh

On Mon, Aug 13, 2018 at 11:56 AM, Marcus Hirt <marcus.hirt at oracle.com>
wrote:

> Hi Josh,
>
> Thanks for the suggestion! The normal work process is to focus the UI on
> whatever is of interest, and then just go to the Applications view. That
> way
> we end up not having to replicate that functionality on every page.
>
> Can you tell me a little bit more about your use case and how you see this
> being used?
>
> (Good initiative! I think you're the first non-Oracle employee attempting
> to
> improve on the visualization, so kudos!)
>
> Kind regards,
> Marcus
>
> On 2018-08-13, 17:41, "jmc-dev on behalf of Joshua Matsuoka" <
> jmc-dev-bounces at openjdk.java.net on behalf of jmatsuok at redhat.com> wrote:
>
>     Hi,
>
>     This is a patch that addresses JMC-5128 and JMC-5149. Currently the
> event
>     thread field in the GC Phase Events isn't used by the UI. This patch
>     accomplishes the following:
>
>     - Adds this field to the phases table.
>     - Adds a Thread table similar to the Java Application page which
> displays
>     the threads that the phase events occurred on.
>     - Adds a Thread lane to visualize the thread selected by the above
> table.
>
>     This is a screenshot of the updated UI: https://imgur.com/a/CFQz9G6
>
>     Thoughts?
>
>     Cheers,
>
>     - Josh
>
>
>
>
>