RFR: JMC-6115 Use Jemmy builds from Maven Central

[Patrick Reinhart]

Hi jay,

The changes where made on a Mac though. I now tried it on my Linux 
machine starting at:

[rep at bisonchws12019 jmc]$ hg branches
default                       31:c178c31fdcf2

Applied the patch not having any problems:

[rep at bisonchws12019 jmc]$ curl 
http://cr.openjdk.java.net/~reinhapa/reviews/JMC-6115/webrev/jmc.patch | 
patch -p1
   % Total    % Received % Xferd  Average Speed   Time    Time     Time  
Current
                                  Dload  Upload   Total   Spent    Left  
Speed
100 31304  100 31304    0     0  26086      0  0:00:01  0:00:01 --:--:-- 
26108
patching file application/uitests/org.openjdk.jmc.test.jemmy/.classpath
patching file 
application/uitests/org.openjdk.jmc.test.jemmy/.settings/org.eclipse.jdt.core.prefs
patching file 
application/uitests/org.openjdk.jmc.test.jemmy/META-INF/MANIFEST.MF
patching file 
application/uitests/org.openjdk.jmc.test.jemmy/build.properties
patching file application/uitests/org.openjdk.jmc.test.jemmy/pom.xml
patching file 
releng/platform-definitions/platform-definition-oxygen/platform-definition-oxygen.target
patching file 
releng/platform-definitions/platform-definition-photon/platform-definition-photon.target
patching file releng/third-party/pom.xml
patching file application/org.openjdk.jmc.feature.jemmy/.project
patching file application/org.openjdk.jmc.feature.jemmy/build.properties
patching file 
application/org.openjdk.jmc.feature.jemmy/feature.properties
patching file application/org.openjdk.jmc.feature.jemmy/feature.xml
patching file application/org.openjdk.jmc.feature.jemmy/pom.xml
patching file 
application/uitests/org.openjdk.jmc.test.jemmy/.settings/org.eclipse.core.resources.prefs

After building the site (mvn p2:site) and starting the local jetty 
instance (mvn jetty:run)

mvn package
mvn verify -Dspotbugs.skip=true
mvn verify -Dspotbugs.skip=true -Puitests


All went well... even though I will check the same parts on Windows 
later too...

-Patrick



On 2018-08-14 11:37, Jayathirth D V wrote:
> Hi Patrick,
> 
> Thanks for your contribution to this important change.
> I created new repo to run UI tests with this patch. I am facing below
> problems related to this patch:
> 
> 1) While importing the patch I am getting  "abort: path '.\README.md'
> is inside nested repo '.'". Since README.md has only comments, I
> selectively removed the changes in README.md and imported the patch.
> 
> 2) After importing the patch "mvn package" & "mvn verify
> -Dspotbugs.skip=true" is running fine. But when I try to run UI tests
> using "mvn verify -Dspotbugs.skip=true -Puitests" I am getting many
> Access restriction errors for org.openjdk.jmc.test.jemmy.
> 
> [ERROR] Access restriction: The type 'Image' is not API (restriction
> on classpath entry
> 'C:\Users\jdv.ORADEV\.m2\repository\p2\osgi\bundle\o
> rg.adoptopenjdk.jemmy-core\1.0.2\org.adoptopenjdk.jemmy-core-1.0.2.jar')
> [ERROR]
> D:\Workspace\JMC7_Open\jmc\application\uitests\org.openjdk.jmc.test.jemmy\src\test\java\org\openjdk\jmc\test\jemmy\misc\base\wrapper
> s\MCJemmyBase.java:[810]
> [ERROR]         image.save(fileName);
> [ERROR]         ^^^^^^^^^^^^^^^^^^^^
> [ERROR] Access restriction: The method 'Image.save(String)' is not API
> (restriction on classpath entry 'C:\Users\jdv.ORADEV\.m2\repository\p
> 2\osgi\bundle\org.adoptopenjdk.jemmy-core\1.0.2\org.adoptopenjdk.jemmy-core-1.0.2.jar')
> [ERROR] 92 problems (92 errors)
> [ERROR] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with
> the -e switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions,
> please read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> [ERROR]
> [ERROR] After correcting the problems, you can resume the build with 
> the command
> [ERROR]   mvn <goals> -rf :org.openjdk.jmc.test.jemmy
> 
> Please clarify.
> 
> Regards,
> Jay
> 
> -----Original Message-----
> From: Patrick Reinhart [mailto:patrick at reini.net]
> Sent: Tuesday, August 14, 2018 1:53 AM
> To: jmc-dev at openjdk.java.net
> Subject: RFR: JMC-6115 Use Jemmy builds from Maven Central
> 
> Hi everybody,
> 
> I added a new feature to have the jemmy libraries resolved from maven 
> central.
> 
> http://cr.openjdk.java.net/~reinhapa/reviews/JMC-6115/webrev/
> 
> -Patrick