[PATCH] JMC-6116 Make Applications page context menu consistent with threads page

Joshua Matsuoka jmatsuok at redhat.com
Wed Aug 15 18:03:52 UTC 2018


Hi Marcus,

Sounds good, here's the patch preserving the old behaviour as well.

Cheers,

- Josh

On Wed, Aug 15, 2018 at 1:53 PM, Marcus Hirt <marcus.hirt at oracle.com> wrote:

> Hi Josh,
>
> Sounds good, though I think it would be good to have the context menu
> present on the legend as well, allowing the old behaviour to still be
> supported as well.
>
> I can sponsor this one.
>
> Kind regards,
> Marcus
>
> On 2018-08-15, 19:48, "jmc-dev on behalf of Joshua Matsuoka" <
> jmc-dev-bounces at openjdk.java.net on behalf of jmatsuok at redhat.com> wrote:
>
>     Hi,
>
>     Currently on the Java Applications page the context menu for editing
> the
>     thread activity lanes is only present over the chart legend, rather
> than
>     over the chart/lane itself. This is inconsistent with the context menu
> of
>     the Threads page. This patch moves the context menu to the chart
> instead,
>     making it consistent with the other usage of thread activity lanes.
> I've
>     also added the edit thread lanes action to the form toolbar, again for
>     consistency.
>
>     Thoughts?
>
>     Cheers,
>
>     - Josh
>
>
>
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: JMC-6116.patch
Type: text/x-patch
Size: 1979 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/jmc-dev/attachments/20180815/1c06e14a/JMC-6116.patch>


More information about the jmc-dev mailing list