Subject: Review request for JMC-6126: Removing deprecated modules from Eclipse launchers

[Guru]

+1, Looks good to me.
> On 27-Aug-2018, at 11:41 PM, Marcus Hirt <marcus.hirt at oracle.com> wrote:
> 
> Hi all,
> 
> Please review this fix to make it possible to launch from within Eclipse with JDK11.
> 
> Jira:   https://bugs.openjdk.java.net/browse/JMC-6126
> Patch:
> diff -r 4f670a413628 application/org.openjdk.jmc.updatesite.ide/src/main/resources/run-on-jdk-instructions/index.html
> --- a/application/org.openjdk.jmc.updatesite.ide/src/main/resources/run-on-jdk-instructions/index.html	Mon Aug 27 18:52:45 2018 +0200
> +++ b/application/org.openjdk.jmc.updatesite.ide/src/main/resources/run-on-jdk-instructions/index.html	Mon Aug 27 20:05:31 2018 +0200
> @@ -38,7 +38,6 @@
> 	<p>You can also configure JVM options by using -vmargs on commandline or eclipse.ini:  <blockquote> <p><code>-showsplash<br>org.eclipse.platform<br>-vm <br>D:/java/jdk8_131/jre/bin/<br>-vmargs<br><JVM options on separate lines></code></p></blockquote> 
> 	<p>If you use JDK 9 to run Eclipse, the following JVM options are needed for Mission Control to work properly:</p>
> 	 <blockquote> <p><code>-Djdk.attach.allowAttachSelf=true
> -	 <br>--add-modules=java.xml.bind,java.xml.ws.annotation
> 	 <br>--add-exports=java.xml/com.sun.org.apache.xerces.internal.parsers=ALL-UNNAMED
> 	 <br>--add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED
> 	 <br>--add-exports=java.management/sun.management=ALL-UNNAMED
> diff -r 4f670a413628 configuration/ide/eclipse/launchers/JMC RCP plug-ins.launch
> --- a/configuration/ide/eclipse/launchers/JMC RCP plug-ins.launch	Mon Aug 27 18:52:45 2018 +0200
> +++ b/configuration/ide/eclipse/launchers/JMC RCP plug-ins.launch	Mon Aug 27 20:05:31 2018 +0200
> @@ -59,7 +59,7 @@
> <stringAttribute key="org.eclipse.jdt.launching.JRE_CONTAINER" value="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.8"/>
> <stringAttribute key="org.eclipse.jdt.launching.PROGRAM_ARGUMENTS" value="-os ${target.os} -ws ${target.ws} -arch ${target.arch} -nl ${target.nl} -consoleLog"/>
> <stringAttribute key="org.eclipse.jdt.launching.SOURCE_PATH_PROVIDER" value="org.eclipse.pde.ui.workbenchClasspathProvider"/>
> -<stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value="-XX:+IgnoreUnrecognizedVMOptions -XX:+UseG1GC -XX:+UnlockCommercialFeatures -XX:+FlightRecorder -XX:StartFlightRecording=name=JMC_Default,maxsize=100m -Djava.net.preferIPv4Stack=true -Djdk.attach.allowAttachSelf=true --add-modules=java.xml.bind,java.xml.ws.annotation --add-exports=java.xml/com.sun.org.apache.xerces.internal.parsers=ALL-UNNAMED --add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED --add-exports=java.management/sun.management=ALL-UNNAMED --add-exports=java.management/sun.management.counter.perf=ALL-UNNAMED --add-exports=jdk.management.agent/jdk.internal.agent=ALL-UNNAMED --add-exports=jdk.attach/sun.tools.attach=ALL-UNNAMED --add-exports=java.desktop/sun.awt.windows=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=jdk.attach/sun.tools.attach=ALL-UNNAMED -Dorg.eclipse.swt.internal.carbon.smallFonts"/>
> +<stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value="-XX:+IgnoreUnrecognizedVMOptions -XX:+UseG1GC -XX:+UnlockCommercialFeatures -XX:+FlightRecorder -XX:StartFlightRecording=name=JMC_Default,maxsize=100m -Djava.net.preferIPv4Stack=true -Djdk.attach.allowAttachSelf=true --add-exports=java.xml/com.sun.org.apache.xerces.internal.parsers=ALL-UNNAMED --add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED --add-exports=java.management/sun.management=ALL-UNNAMED --add-exports=java.management/sun.management.counter.perf=ALL-UNNAMED --add-exports=jdk.management.agent/jdk.internal.agent=ALL-UNNAMED --add-exports=jdk.attach/sun.tools.attach=ALL-UNNAMED --add-exports=java.desktop/sun.awt.windows=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=jdk.attach/sun.tools.attach=ALL-UNNAMED -Dorg.eclipse.swt.internal.carbon.smallFonts"/>
> <stringAttribute key="pde.version" value="3.3"/>
> <stringAttribute key="product" value="org.openjdk.jmc.rcp.application.product"/>
> <setAttribute key="selected_features">
> diff -r 4f670a413628 configuration/ide/eclipse/launchers/JMC RCP.launch
> --- a/configuration/ide/eclipse/launchers/JMC RCP.launch	Mon Aug 27 18:52:45 2018 +0200
> +++ b/configuration/ide/eclipse/launchers/JMC RCP.launch	Mon Aug 27 20:05:31 2018 +0200
> @@ -61,7 +61,7 @@
> <stringAttribute key="org.eclipse.jdt.launching.JRE_CONTAINER" value="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.8"/>
> <stringAttribute key="org.eclipse.jdt.launching.PROGRAM_ARGUMENTS" value="-os ${target.os} -ws ${target.ws} -arch ${target.arch} -nl ${target.nl} -consoleLog"/>
> <stringAttribute key="org.eclipse.jdt.launching.SOURCE_PATH_PROVIDER" value="org.eclipse.pde.ui.workbenchClasspathProvider"/>
> -<stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value="-XX:+IgnoreUnrecognizedVMOptions -XX:+UseG1GC -XX:+UnlockCommercialFeatures -XX:+FlightRecorder -XX:StartFlightRecording=name=JMC_Default,maxsize=100m -Djava.net.preferIPv4Stack=true -Djdk.attach.allowAttachSelf=true --add-modules=java.xml.bind,java.xml.ws.annotation --add-exports=java.xml/com.sun.org.apache.xerces.internal.parsers=ALL-UNNAMED --add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED --add-exports=java.management/sun.management=ALL-UNNAMED --add-exports=jdk.management.agent/jdk.internal.agent=ALL-UNNAMED --add-exports=jdk.attach/sun.tools.attach=ALL-UNNAMED --add-exports=java.desktop/sun.awt.windows=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED -Dorg.eclipse.swt.internal.carbon.smallFonts"/>
> +<stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value="-XX:+IgnoreUnrecognizedVMOptions -XX:+UseG1GC -XX:+UnlockCommercialFeatures -XX:+FlightRecorder -XX:StartFlightRecording=name=JMC_Default,maxsize=100m -Djava.net.preferIPv4Stack=true -Djdk.attach.allowAttachSelf=true --add-exports=java.xml/com.sun.org.apache.xerces.internal.parsers=ALL-UNNAMED --add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED --add-exports=java.management/sun.management=ALL-UNNAMED --add-exports=jdk.management.agent/jdk.internal.agent=ALL-UNNAMED --add-exports=jdk.attach/sun.tools.attach=ALL-UNNAMED --add-exports=java.desktop/sun.awt.windows=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED -Dorg.eclipse.swt.internal.carbon.smallFonts"/>
> <stringAttribute key="pde.version" value="3.3"/>
> <stringAttribute key="product" value="org.openjdk.jmc.rcp.application.product"/>
> <setAttribute key="selected_features">
> 
> ----
> Kind regards,
> Marcus
> 
>