JMC-6149: Distinguish by package with default packages in the traces does not work

Marcus Hirt marcus.hirt at oracle.com
Tue Dec 4 14:14:36 UTC 2018


Using brackets is also what we do in other places in JMC to denote 
special/empty values, for example in the selection and aspect combo-boxes, 
so it would fit well.

Kind regards,
Marcus

On 2018-12-04, 13:34, "jmc-dev on behalf of Mario Torre" <jmc-dev-bounces at openjdk.java.net on behalf of neugens at redhat.com> wrote:

    On Tue, Dec 4, 2018 at 11:32 AM Marcus Hirt <marcus at hirt.se> wrote:
    >
    > Trying that again. Heh.
    >
    > Hi Mario,
    >
    > Agreed. That said, there is probably a difference in how to render a stand alone
    > default package in a human readable way, and what the core API itself returns.
    > The API needs to return a valid package name, possibly the empty string (or
    > null) for the default package. When we _render_ the default package, it depends
    > on the context how we probably want to render. As part of a FQN, it should be
    > the empty string. As a stand alone package only rendering in the
    > StackTrace-view, when grouping on package, possibly something like <default>,
    > to underline that there is a package and not a missing data error.
    
    Yes, exactly what I had in mind, and <default> works very well, I
    think this is what other tools use as well.
    
    Cheers,
    Mario
    
    -- 
    Mario Torre
    Associate Manager, Software Engineering
    Red Hat GmbH <https://www.redhat.com>
    9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898
    
    




More information about the jmc-dev mailing list