RFR: JMC-6266: JDK 8 specific code in core (String.join)

[Miro Wengner]

Hi Marcus, 
  I’ve test your little “silly” fix, 

I’ve also tested with  oracle-jdk1.7_80  JfrHtmlRulesReport

looks good to me

Kind Regards, 
Miro

> On Dec 11, 2018, at 7:10 PM, Marcus Hirt <marcus at hirt.se> wrote:
> 
> Can I get a +1 on this silly little fix? ;)
> 
> 
> 
> Kind regards,
> 
> Marcus
> 
> 
> 
> Från: Joshua Matsuoka <jmatsuok at redhat.com> 
> Skickat: den 11 december 2018 16:20
> Till: Marcus Hirt <marcus at hirt.se>
> Kopia: jmc-dev at openjdk.java.net
> Ämne: Re: RFR: JMC-6266: JDK 8 specific code in core (String.join)
> 
> 
> 
> Hi Marcus,
> 
> 
> 
> Looks good.
> 
> 
> 
> Cheers,
> 
> 
> 
> - Josh
> 
> 
> 
> On Tue, Dec 11, 2018 at 7:52 AM Marcus Hirt <marcus at hirt.se <mailto:marcus at hirt.se> > wrote:
> 
> Hi all,
> 
> Please review this fix for getting rid of some JDK 8-specific code that has
> snuck into core.
> 
> Jira:  https://bugs.openjdk.java.net/browse/JMC-6266
> Patch:
> 
> <---8<--->
> diff -r abb4b7f54009
> core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/
> flightrecorder/rules/jdk/general/DuplicateFlagsRule.java
> ---
> a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jm
> c/flightrecorder/rules/jdk/general/DuplicateFlagsRule.java     Thu Dec 06
> 19:12:44 2018 +0100
> +++
> b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jm
> c/flightrecorder/rules/jdk/general/DuplicateFlagsRule.java     Tue Dec 11
> 13:47:26 2018 +0100
> @@ -44,6 +44,7 @@
> import org.openjdk.jmc.common.item.Aggregators;
> import org.openjdk.jmc.common.item.IItemCollection;
> import org.openjdk.jmc.common.util.IPreferenceValueProvider;
> +import org.openjdk.jmc.common.util.StringToolkit;
> import org.openjdk.jmc.common.util.TypedPreference;
> import org.openjdk.jmc.flightrecorder.jdk.JdkAttributes;
> import org.openjdk.jmc.flightrecorder.jdk.JdkFilters;
> @@ -81,7 +82,7 @@
>                                StringBuilder sb = new StringBuilder();
>                                sb.append("<ul>"); //$NON-NLS-1$
>                                for (ArrayList<String> dupe : dupes) {
> -                                    sb.append("<li>" +
> Encode.forHtml(String.join(", ", dupe)) + "</li>"); //$NON-NLS-1$
> //$NON-NLS-2$
> +                                    sb.append("<li>" +
> Encode.forHtml(StringToolkit.join(dupe, ", ")) + "</li>"); //$NON-NLS-1$
> //$NON-NLS-2$
>                                }
>                                sb.append("</ul>"); //$NON-NLS-1$
>                                String shortDescription = dupes.size() > 1
> <---8<--->
> 
> Kind regards,
> Marcus
>