RFR: JMC-4467: Reducing roundtrips required for enablement checking

Guru guru.hb at oracle.com
Thu Dec 13 08:08:42 UTC 2018


+1 looks good to me. 
Verified with OpenJDK 11.0.2. 
Verified jfr recording and didn’t see any error window (as Miro encountered). 

Thanks,
Guru
> On 13-Dec-2018, at 4:16 AM, Miro Wengner <miro.wengner at gmail.com> wrote:
> 
> Hi Marcus, 
>   I’ve tested it but I didn’t received any log messages
> tested jdks: oracle1.8_191 and openjdk11
> 
> when I wanted to start jfr recording on any running project I got a error window
> I’m sending you some screen shots
> 
> maybe someone other can test too ? 
> 
> Kind Regards, 
> Miro
> 
> 
>> On Dec 12, 2018, at 9:56 PM, Marcus Hirt <marcus at hirt.se> wrote:
>> 
>> Hi all,
>> 
>> Please review this fix to optimize the checks for JFR enablement, and to 
>> optimize the checks for commercial features enablement for JDK 11+. 
>> 
>> Jira:  https://bugs.openjdk.java.net/browse/JMC-4467
>> Patch: http://cr.openjdk.java.net/~hirt/JMC-4467/webrev.0/
>> 
>> Kind regards,
>> Marcus
>> 
> 



More information about the jmc-dev mailing list