Review request for JMC-6281: Removing forgotten hirt.se license text

[Marcus Hirt]

Thanks Alex! Will follow up immediately with a check-in. Setting you as reviewer. ;)

 

Kind regards,

Marcus

 

From: Alex Macdonald <almacdon at redhat.com>
Date: Wednesday, 19 December 2018 at 21:21
To: Guru <guru.hb at oracle.com>
Cc: Marcus Hirt <marcus.hirt at oracle.com>, "jmc-dev at openjdk.java.net" <jmc-dev at openjdk.java.net>
Subject: Re: Review request for JMC-6281: Removing forgotten hirt.se license text

 

I believe this change requires accompanying edits to the build.properties [0] file to remove the license.txt and readme.txt from the bin.includes section. Trying to build JMC currently results in an error: build.properties: bin.includes value(s) [license.txt, readme.txt] do not match any files

 

Cheers,

 

Alex

 

[0] http://hg.openjdk.java.net/jmc/jmc/file/246d9bb1a89a/application/org.openjdk.jmc.greychart/build.properties#l38

 

On Wed, Dec 19, 2018 at 1:37 PM Guru <guru.hb at oracle.com> wrote:

+1 Looks good to me.
> On 20-Dec-2018, at 12:00 AM, Marcus Hirt <marcus.hirt at oracle.com> wrote:
> 
> Hi all,
> 
> Please review this fix to remove some hirt.se license text that 
> we missed to remove when open sourcing jmc.
> 
> Jira:   https://bugs.openjdk.java.net/browse/JMC-6281
> Webrev: http://cr.openjdk.java.net/~hirt/JMC-6281/webrev.01/
> 
> Kind regards,
> Marcus
> 
> 
>