Small text issue in Recording Wizard

[Marcus Hirt]

You're good to go!

/M

On 2018-12-20, 17:41, "jmc-dev on behalf of Joshua Matsuoka" <jmc-dev-bounces at openjdk.java.net on behalf of jmatsuok at redhat.com> wrote:

    Hi,
    
    I'll open a bug and push this for you. Looks good.
    
    Cheers,
    
    - Josh
    
    On Thu, Dec 20, 2018 at 11:38 AM Ken Dobson <kdobson at redhat.com> wrote:
    
    > Here is the patch in text form because I believe it was stripped.
    >
    > diff -r abb4b7f54009
    >
    > application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/resources/org/openjdk/jmc/flightrecorder/controlpanel/ui/messages/internal/messages.properties
    > ---
    >
    > a/application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/resources/org/openjdk/jmc/flightrecorder/controlpanel/ui/messages/internal/messages.properties
    > Thu Dec 06 19:12:44 2018 +0100
    > +++
    >
    > b/application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/resources/org/openjdk/jmc/flightrecorder/controlpanel/ui/messages/internal/messages.properties
    > Wed Dec 19 16:41:16 2018 -0500
    > @@ -184,8 +184,8 @@
    >  RECORDING_WIZARD_PAGE_RECORDING_NAME_INVALID_CHARS=Name can't contain any
    > of these characters: {0}
    >  RECORDING_WIZARD_PAGE_NO_TEMPLATE_SELECTED_ERROR_MSG=You need to select a
    > configuration of events to include in the recording.
    >  RECORDING_WIZARD_PAGE_NO_TEMPLATES_IN_MANAGER_ERROR_MSG=You need to use
    > the Template Manager to create or import a configuration of events to
    > include in the recording.
    > -RECORDING_WIZARD_PAGE_DURATION_NOTE=<form><p><br/><b>Note: </b>Time
    > fixed recordings will be automatically dumped and opened.</p></form>
    >
    > -RECORDING_WIZARD_PAGE_CONTINUOUS_NOTE=<form><p><br/><b>Note: </b>Continuous
    > recordings will need to be dumped to access the data. Right-click on the
    > recording in the JVM Browser to open the Dump Recording dialog.</p></form>
    > +RECORDING_WIZARD_PAGE_DURATION_NOTE=<form><p><br/><b>Note: </b>Time fixed
    > recordings will be automatically dumped and opened.</p></form>
    > +RECORDING_WIZARD_PAGE_CONTINUOUS_NOTE=<form><p><br/><b>Note:
    > </b>Continuous recordings will need to be dumped to access the data.
    > Right-click on the recording in the JVM Browser to open the Dump Recording
    > dialog.</p></form>
    >
    >  START_FLIGHT_RECORDING_JOB_MISSING_RECORDING=Unexpectedly lost connection
    > to flight recording {0}, possibly closed by another client.
    >  FLIGHT_RECORDING_OPTIONS_PROBLEM_TITLE=Problems with the flight recording
    > options
    >
    >
    > On Thu, Dec 20, 2018 at 11:31 AM Ken Dobson <kdobson at redhat.com> wrote:
    >
    > > Hi all,
    > >
    > > When you open the Recording Wizard you should see this written at the
    > > bottom of the first page:
    > >
    > > *Note: *Time fixed recordings will be automatically dumped and
    > > opened.
    > >
    > > This was bothering me so I had a look and it seems the eclipse setText
    > > function replaces all "&" with "&" so you're unable to use character
    > > references in the string you pass to it, only HTML tags. This tiny patch
    > > just removes the   as it currently does nothing and looks quite
    > ugly.
    > >
    > > Thanks,
    > >
    > > Ken
    > >
    >