Review request for JMC-6061: running cleanup on core

[Marcus Hirt]

Hi Mario,

There is a style guide. The formatting parts are encoded into the formatting 
settings (configuration/ide/eclipse/formatting/formatting.xml). There are other 
parts to the style guide too, as how to handle acronyms/initialisms (there will 
probably be a check-in soon that will correct some wrongly named classes). I 
will try to update the wiki with style guide elements.

Kind regards,
Marcus

On 2018-07-03, 15:42, "Mario Torre" <neugens at redhat.com> wrote:

    On Tue, Jul 3, 2018 at 2:51 PM, Marcus Hirt <marcus.hirt at oracle.com> wrote:
    > Hi all,
    >
    > This patch is not quite as scary as it looks. Many files have whitespace
    > changes only. That said, I'd rather do these changes as early as possible.
    >
    > Jira:   https://bugs.openjdk.java.net/browse/JMC-6061
    > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6061/webrev.0/
    >
    > Kind regards,
    > Marcus
    
    Hi Marcus,
    
    I pick an easy one for the start :)
    
    The patch looks generally good (well, as you say is mostly about white
    spaces), I have a question though, do we have a coding guidelines?
    
    For instance, we are aligning now the enum fields to the same column
    and the start of the definition, is that the recommended style?
    
    Cheers,
    Mario
    -- 
    Mario Torre
    Associate Manager, Software Engineering
    Red Hat GmbH <https://www.redhat.com>
    9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898