RFR JMC-6104: Java Application/Thread Activity does not show the graph

[Sharath Ballal]

Thanks for the review Marcus.


Thanks,
Sharath


-----Original Message-----
From: Marcus Hirt 
Sent: Monday, July 30, 2018 3:28 PM
To: Sharath Ballal; jmc-dev at openjdk.java.net
Subject: Re: RFR JMC-6104: Java Application/Thread Activity does not show the graph

Looks fine! Go ahead!

/M

On 2018-07-30, 06:41, "jmc-dev on behalf of Sharath Ballal" <jmc-dev-bounces at openjdk.java.net on behalf of sharath.ballal at oracle.com> wrote:

    Hello,
    
     
    
    Pls review this fix.  The issue was that in the "Java Application" page if "Thread Activity" checkbox was selected in the legend no bars in the graph was getting generated. (More details in the bug.)
    
     
    
    Reason is that the event id path "com.oracle.jdk" was hard coded in some places.  Fix is to use the global constants.  
    
     
    
    JBS: https://bugs.openjdk.java.net/browse/JMC-6104
    
    Webrev: http://cr.openjdk.java.net/~sballal/JMC-6104/webrev.00/
    
     
    
    Testing:
    
    Mvn verify passes.  
    
    I loaded JDK 7/8/9/10/11 recordings and verified under "Java Application", "Thread Activity" shows the bars in the graph.  "Threads" page under "Java Application" also shows the bars in the graph.
    
     
    
    Thanks,
    
    Sharath