Review request for JMC-6045 : JMC 7.0.0 update ide and rcp landing page with correct url's

Klara Ward klara.ward at oracle.com
Tue Jun 12 09:42:07 UTC 2018


A few comments:

* IDE page has one "Mission Control" without the "JDK" prefix, maybe
that is intentional?
* I assume the offline url needs to be updated again to remove the '-ea'
suffix for the zip file name?

* Is there also a bug to update the screenshots? They say "Oracle Java
Mission Control" in the window title..

* In
application/org.openjdk.jmc.updatesite.ide/src/main/resources/update-site-instructions/index.html,
the updatesite url should be
'...missioncontrol/updatesites/openjdk/7.0.0/eclipse/' instead of
'...missioncontrol/updatesites/oracle/7.0.0/eclipse/'
* Maybe these screenshots needs to be updated as well...

// Klara

On 2018-06-08 18:13, Guru wrote:
> Please review the fix for updating landing page (ide and rcp) with
> correct url's
> JBS : https://bugs.openjdk.java.net/browse/JMC-6045
> Web rev : http://cr.openjdk.java.net/~ghb/JMC-6045/webrev.0/
> <http://cr.openjdk.java.net/%7Eghb/JMC-6045/webrev.0/>
>
> Thanks,
> Guru




More information about the jmc-dev mailing list