Review Request: JMC-5996: License text not displayed when installing JMC plugins

Guru guru.hb at oracle.com
Tue Jun 12 14:04:59 UTC 2018


Yes, I tried with 1.2.0 as well and getting the same compilation failure.

@Ola, Do suggest if you have pointer for this failure (Compiling JMC with Tyco 1.1.0 or with 1.2.0.

Thanks,
Guru
> On 12-Jun-2018, at 3:30 PM, Klara Ward <klara.ward at oracle.com> wrote:
> 
> I believe Ola tried to find a solution for this, but never had the time to solve it.
> 
> Did you try Tycho 1.2.0 which seems to be released in May.
> 
> // Klara
> 
> On 2018-06-12 11:42, Guru wrote:
>> Yes, I observed the compilation failure on Windows (though Mac it works i.e compilation and works as expected).
>> 
>> "[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:1.2.0:compile (default-compile) on project org.openjdk.jmc.javafx.osgi: Fatal error compiling: Illegal char <:> at index 74: D:\ade\jmc-releng-dev\jmc\application\org.openjdk.jmc.javafx.osgi\external:$java.home$\lib\ext\jfxrt.jar -> [Help 1]”.
>> 
>> Same for Tyco 1.1.0 as well..
>> 
>> Thanks,
>> Guru
>> 
>>> On 12-Jun-2018, at 2:59 PM, Klara Ward <klara.ward at oracle.com <mailto:klara.ward at oracle.com>> wrote:
>>> 
>>> Hi Guru,
>>> 
>>> Did you see the javafx classpath issue caused by upgrading to Tycho
>>> 1.1.0 in https://bugs.openjdk.java.net/browse/JMC-5859 <https://bugs.openjdk.java.net/browse/JMC-5859>
>>> Is that resolved now?
>>> 
>>> // Klara
>>> 
>>> 
>>> On 2018-06-05 19:25, Guru wrote:
>>>> Hi Klara,
>>>> 
>>>> Thanks for your suggestion and Please review the fix for 
>>>> JBS : https://bugs.openjdk.java.net/browse/JMC-5996 <https://bugs.openjdk.java.net/browse/JMC-5996>
>>>> Webrev : http://cr.openjdk.java.net/~ghb/JMC-5996/webrev.0 <http://cr.openjdk.java.net/%7Eghb/JMC-5996/webrev.0>
>>>> <http://cr.openjdk.java.net/%7Eghb/JMC-5996/webrev.0 <http://cr.openjdk.java.net/%7Eghb/JMC-5996/webrev.0>>
>>>> 
>>>> Solution : Updated the Tyco version from 1.0.0 to 1.1.0.
>>>> Test : Verified the License property generated in ‘content.xml’ and
>>>> also observed the License dialog prompted while installing the updates.
>>>> 
>>>> Thanks,
>>>> Guru
>>> 
>>> 
>> 
> 



More information about the jmc-dev mailing list