Review request for JMC-6045 : JMC 7.0.0 update ide and rcp landing page with correct url's

Klara Ward klara at kth.se
Fri Jun 15 13:54:45 UTC 2018


There is still one url i ide/update-site-instructions which includes
"oracle" instead of "openjdk"

On the updatesite.ide index.html page, the offline download url, which
currently is
"http://download.oracle.com/technology/products/missioncontrol/updatesites/openjdk/7.0.0/eclipse/jmc-updatesite-ide-7.0.0-ea.zip"

could be changed to something like
"http://download.oracle.com/technology/products/missioncontrol/updatesites/openjdk/7.0.0/jmc-updatesite-ide-7.0.0-ea.zip"
to make building the zip for OTN deploy (see
https://bugs.openjdk.java.net/browse/JMC-5841) a bit nicer.


// Klara

On 2018-06-13 11:17, Guru wrote:
> Thanks Klara, 
>
> Please find updated webrev 
> http://cr.openjdk.java.net/~ghb/JMC-6045/webrev.2/ <http://cr.openjdk.java.net/~ghb/JMC-6045/webrev.2/>
> Ide ref : http://cr.openjdk.java.net/~ghb/JMC-6045/new_ide.2/ <http://cr.openjdk.java.net/~ghb/JMC-6045/new_ide.2/>
> Rcp ref : http://cr.openjdk.java.net/~ghb/JMC-6045/new_rcp.2/ <http://cr.openjdk.java.net/~ghb/JMC-6045/new_rcp.2/>
>
> Updated screenshots, corrected Url’s and missing JDK prefix.
>
> Thanks,
> Guru
>
>> On 12-Jun-2018, at 3:12 PM, Klara Ward <klara.ward at oracle.com> wrote:
>>
>> A few comments:
>>
>> * IDE page has one "Mission Control" without the "JDK" prefix, maybe
>> that is intentional?
>> * I assume the offline url needs to be updated again to remove the '-ea'
>> suffix for the zip file name?
>>
>> * Is there also a bug to update the screenshots? They say "Oracle Java
>> Mission Control" in the window title..
>>
>> * In
>> application/org.openjdk.jmc.updatesite.ide/src/main/resources/update-site-instructions/index.html,
>> the updatesite url should be
>> '...missioncontrol/updatesites/openjdk/7.0.0/eclipse/' instead of
>> '...missioncontrol/updatesites/oracle/7.0.0/eclipse/'
>> * Maybe these screenshots needs to be updated as well...
>>
>> // Klara
>>
>> On 2018-06-08 18:13, Guru wrote:
>>> Please review the fix for updating landing page (ide and rcp) with
>>> correct url's
>>> JBS : https://bugs.openjdk.java.net/browse/JMC-6045
>>> Web rev : http://cr.openjdk.java.net/~ghb/JMC-6045/webrev.0/
>>> <http://cr.openjdk.java.net/%7Eghb/JMC-6045/webrev.0/>
>>>
>>> Thanks,
>>> Guru
>>



More information about the jmc-dev mailing list