Review request for JMC-6050: Exception evaluating AllocationByClassRule and AllocationByThreadRule rules
Klara Ward
klara at kth.se
Wed Jun 27 07:25:45 UTC 2018
Shipit!
On 2018-06-25 14:04, Marcus Hirt wrote:
> Thanks Klara! Found an additional problem when there are no stack traces available. Here is an updated webrev:
> http://cr.openjdk.java.net/~hirt/JMC-6050/webrev.1/
>
> /M
>
> On 2018-06-23, 23:01, "Klara Ward" <klara at kth.se> wrote:
>
> Could the event availability check be changed to:
> ”at least one of the two allocation event types should be available, and the other should be enabled”?
>
> I did the change to cause this bug in the first place, in an attempt to handle recordings that only had New TLAB events (more common in JDK9+)
>
> // Klara
>
> > 23 juni 2018 kl. 01:39 skrev Marcus Hirt <marcus.hirt at oracle.com>:
> >
> > Please review the fix for two rules throwing exceptions:
> > JBS: https://bugs.openjdk.java.net/browse/JMC-6050
> > Web rev: http://cr.openjdk.java.net/~hirt/JMC-6050/webrev/
> >
> > /M
> >
> >
>
>
>
>
More information about the jmc-dev
mailing list