JMC-5506 Rule that detects fatal errors in the end of the recording

[Joshua Matsuoka]

Hi Marcus,

Here's an updated webrev:

http://cr.openjdk.java.net/~jmatsuoka/JMC-5506/webrev.03/

Cheers,

- Josh

On Sun, Nov 4, 2018 at 11:18 AM, Marcus Hirt <marcus.hirt at oracle.com> wrote:

> Perfect. Josh, I've reviewed the code and it looks fine. Once you've
> updated
> the texts to say JVM instead of VM, you're good to go. If you want to add
> code
> for reason "No remaining non-daemon Java threads" (25), then that would be
> great. Please let me know if you would like me to sponsor the change.
>
> Kind regards,
> Marcus
>
> On 2018-11-04, 16:54, "Erik Gahlin" <erik.gahlin at oracle.com> wrote:
>
>     Hi Marcus,
>
>     It is stated in the event. For details, look at the patch which is
> linked in the bug for the event.
>
>     Erik
>
>     > On 4 Nov 2018, at 12:43, Marcus Hirt <marcus.hirt at oracle.com> wrote:
>     >
>     > Hi Erik,
>     >
>     > Will Shutdown Reason state that the reason for the shutdown was due
> to no more
>     > remaining non-daemon threads? If so, the reason will be shown on the
> page.
>     > If we want it to be even more apparent, we could also add it to the
> rule
>     > as Severity.INFO (25). Either way is fine with me.
>     >
>     > If the Shutdown Reason doesn't state this explicitly, that should
>     > probably be fixed in the event.
>     >
>     > Kind regards,
>     > Marcus
>     >
>     > On 2018-11-02, 22:28, "jmc-dev on behalf of Erik Gahlin" <
> jmc-dev-bounces at openjdk.java.net on behalf of erik.gahlin at oracle.com>
> wrote:
>     >
>     >    Hi Joshua,
>     >
>     >    I think the text should say "JVM" instead of "VM"
>     >
>     >    Calling the event "VM" was a mistake in JVM implementation and we
> intend
>     >    to change the label of the event to "JVM", similar to other
> events, such
>     >    as "JVM Information"
>     >
>     >    One of the reason the event was added was to detect if there were
> no
>     >    more remaining non-daemon Java threads [1] [2]. Maybe that should
> be
>     >    called out? A user may wonder why their application exited
> abruptly.
>     >    It's not an error per se, but it would still be good to see
> somehow.
>     >
>     >    [1] https://bugs.openjdk.java.net/browse/JDK-8041626
>     >    [2] http://hg.openjdk.java.net/jdk/hs/rev/f413e471a6ab
>     >
>     >    Thanks
>     >    Erik
>     >
>     >> Hi,
>     >>
>     >> The following patch adds support for the recently added VM Shutdown
> event
>     >> by creating a rule to detect if the JVM terminated in a VM Error,
> as well
>     >> as adding shutdown information to the JVM internals page.
>     >>
>     >> http://cr.openjdk.java.net/~jmatsuoka/JMC-5506/webrev.02/
>     >>
>     >> Thoughts?
>     >>
>     >> Cheers,
>     >>
>     >> - Josh
>     >
>     >
>     >
>     >
>     >
>
>
>
>
>
>