JMC-5703: HighGcRule should report extra needed event types

[Marcus Hirt]

Hi Ken,

Yes, if it is no longer used, please go ahead and remove both the constant and 
the entry in the associated properties files (might as well remove it from the 
translated files too).

Kind regards,
Marcus

On 2018-11-06, 17:08, "jmc-dev on behalf of Ken Dobson" <jmc-dev-bounces at openjdk.java.net on behalf of kdobson at redhat.com> wrote:

    Hi all,
    
    This is a small patch to make the highGcRule consistent with the
    GcFreedRatioRule when reporting extra needed event types.
    Should I remove HighGcRuleFactory_TEXT_INFO_LONG_ALLOC_DISABLED from
    Messages.java given it is no longer used?
    
    Thanks,
    
    Ken Dobson
    
    diff -r b3a23786ef23
    core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/HighGcRule.java
    ---
    a/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/HighGcRule.java
    Wed Oct 10 16:43:35 2018 -0400
    +++
    b/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/HighGcRule.java
    Tue Nov 06 10:33:20 2018 -0500
    @@ -84,9 +84,11 @@
                 String message =
    MessageFormat.format(Messages.getString(Messages.HighGcRuleFactory_TEXT_INFO),
    duration,
                         startTime,
    pausePercent.displayUsing(IDisplayable.AUTO));
                 String longMessage = message + " " +
    Messages.getString(Messages.HighGcRuleFactory_TEXT_INFO_LONG);
    //$NON-NLS-1$
                 if (!RulesToolkit.isEventsEnabled(items,
    JdkTypeIDs.ALLOC_INSIDE_TLAB, JdkTypeIDs.ALLOC_OUTSIDE_TLAB)) {
                     longMessage = longMessage + "<p>" //$NON-NLS-1$
    -                        +
    Messages.getString(Messages.HighGcRuleFactory_TEXT_INFO_LONG_ALLOC_DISABLED);
    +                        +
    RulesToolkit.getEnabledEventTypesRecommendation(items,
    +                                JdkTypeIDs.ALLOC_INSIDE_TLAB,
    JdkTypeIDs.ALLOC_OUTSIDE_TLAB);
                 }
                 return new Result(this, score, message, longMessage,
    JdkQueries.GC_PAUSE);
             }