Review request for JMC-6199: Removing the text logging from the agent
Joshua Matsuoka
jmatsuok at redhat.com
Wed Nov 14 22:49:43 UTC 2018
Hi Marcus,
The changes look good to me. I'm unable to instrument the test classes
properly however, as OpenJDK8 doesn't have flight recorder, and on
OpenJDK11 the method we use for instrumentation
(sun.misc.Unsafe.defineClass) has been deprecated [1].
We should look into a way to do this on OpenJDK11. For now the cleanup
looks good.
[1] https://bugs.openjdk.java.net/browse/JDK-8181442
Cheers,
- Josh
On Mon, Nov 12, 2018 at 6:27 AM, Marcus Hirt <marcus.hirt at oracle.com> wrote:
> Hi all,
>
> Please review this fix to remove the text logging capabilities from the
> agent prototype.
>
> Jira: https://bugs.openjdk.java.net/browse/JMC-6199
> Webrev: http://cr.openjdk.java.net/~hirt/JMC-6199/webrev.01/
>
> Kind regards,
> Marcus
>
>
>
More information about the jmc-dev
mailing list