Review request for JMC-5990 : Human readable names for JMC updatesites are missing

Tejpal Rebari tejpal.rebari at oracle.com
Thu Nov 22 07:52:29 UTC 2018


Hi Marcus,
I have changed the name to “JDK Mission Control 7.0.0 RCP Update Site”.
Webrev : http://cr.openjdk.java.net/~ghb/trebari/JMC-5990/webrev.1/ <http://cr.openjdk.java.net/~ghb/trebari/JMC-5990/webrev.1/>

Regards
Tejpal

> On 21-Nov-2018, at 3:38 AM, Marcus Hirt <marcus.hirt at oracle.com> wrote:
> 
> Hi Tejpal,
> 
> I don't think the name should include "Supported", and "Site" is not specific 
> enough. Supported is implied unless it is tagged (Experimental). The delineator
> is rather between "OpenJDK" and "Oracle". I would suggest OpenJDK would be 
> implied as well, so I'd either name it JDK Mission Control 7.0.0 OpenJDK RCP 
> Update Site, or simply JDK Mission Control 7.0.0 RCP Update Site.
> 
> Kind regards,
> Marcus
> 
> On 2018-11-20, 01:18, "Tejpal Rebari  charset=us-ascii" <tejpal.rebari at oracle.com> wrote:
> 
>    Hi All,
> 
>    Please review the small fix for :
> 
>    Jira		: https://bugs.openjdk.java.net/browse/JMC-5990
>    webrev	: http://cr.openjdk.java.net/~ghb/trebari/JMC-5990/webrev.0/
>    RC 		: The name for jmc rcp update site was missing.
>    Solution 	: Added the name JDK Mission Control 7.0.0 Supported RCP Site for jmc rcp update site using setRepositoryProperty.
> 
>    Thanks
>    Tejpal
> 
> 
> 



More information about the jmc-dev mailing list