Review request: JMC-6127: Live Objects Page do not forward selections correctly
Marcus Hirt
marcus.hirt at oracle.com
Tue Nov 27 13:59:46 UTC 2018
Hi Guru,
Looks good, but documentation could be a bit improved e.g. on the
ReferenceTree related classes. It should not say "Object which is leaked"
rather "referenced object" or something similar. Also, it should preferably
explain what the method does, and not only list the parameter. For example:
* @param leafNode
* Object which is leaked
*/
Kind regards,
Marcus
From: Guru <guru.hb at oracle.com>
Date: Tuesday, 27 November 2018 at 07:59
To: <jmc-dev at openjdk.java.net>, Marcus Hirt <marcus.hirt at oracle.com>
Subject: Review request: JMC-6127: Live Objects Page do not forward selections correctly
Hi All,
Please review the fix for
JBS : https://bugs.openjdk.java.net/browse/JMC-6127
Webrev : http://cr.openjdk.java.net/~ghb/JMC-6127/webrev.0/
Root cause and its solution is updated in JBS.
Thanks
Guru
More information about the jmc-dev
mailing list