Review Request: JMC-6217 Update mail.api and its dependencies
Marcus Hirt
marcus.hirt at oracle.com
Fri Nov 30 13:14:12 UTC 2018
Looks good! I can sponsor this.
/M
On 2018-11-30, 05:05, "Prem Balakrishnan" <prem.balakrishnan at oracle.com> wrote:
Hi Marcus, Jie,
Updated patch: http://cr.openjdk.java.net/~pkbalakr/jmc/6217/webrev.03/
I have updated only mail and activation package.
com.sun.mail.jakarta.mail_1.6.3.jar + com.sun.activation.jakarta.activation_1.2.1.jar works fine.
Regards,
Prem
-----Original Message-----
From: Marcus Hirt
Sent: Thursday, November 29, 2018 9:46 PM
To: Jie Kang <jkang at redhat.com>; Prem Balakrishnan <prem.balakrishnan at oracle.com>
Cc: jmc-dev at openjdk.java.net
Subject: Re: Review Request: JMC-6217 Update mail.api and its dependencies
Hi Jie,
Ah, interesting. http://javaee.github.io/javamail/ references the EE4J initiative and says the project is temporarily paused whilst in transit, however the transition status for JavaMail clearly shows at 100%. Source location is now https://github.com/eclipse-ee4j/javamail. Sorry for missing that. Yes, we should switch to the new coordinates.
Prem, can you please try switching to the jakarta.mail coordinates?
Kind regards,
Marcus
On 2018-11-29, 16:28, "Jie Kang" <jkang at redhat.com> wrote:
Hi Prem, Marcus,
It's my understanding that the latest versions for javamail and jaf
are from the Eclipse Foundation and are
javamail : 1.6.3 : com.sun.mail:jakarta.mail
https://github.com/eclipse-ee4j/javamail/releases/tag/1.6.3
https://mvnrepository.com/artifact/com.sun.mail/jakarta.mail/1.6.3
jaf : 1.2.1 : com.sun.activation:jakarta.activation
https://github.com/eclipse-ee4j/jaf/releases/tag/1.2.1
https://mvnrepository.com/artifact/com.sun.activation/jakarta.activation/1.2.1
My initial suggestion was to use these. Is that possible?
Regards,
On Wed, Nov 28, 2018 at 11:17 PM Prem Balakrishnan
<prem.balakrishnan at oracle.com> wrote:
>
> Hi Marcus,
>
> Updated patch: http://cr.openjdk.java.net/~pkbalakr/jmc/6217/webrev.02/
>
> com.sun.mail.javax.mail_1.6.2.jar + javax.activation_1.1.1.jar works fine.
>
> Regards,
> Prem
>
> -----Original Message-----
> From: Marcus Hirt
> Sent: Wednesday, November 28, 2018 7:31 PM
> To: Prem Balakrishnan <prem.balakrishnan at oracle.com>; Jie Kang <jkang at redhat.com>
> Cc: jmc-dev at openjdk.java.net
> Subject: Re: Review Request: JMC-6217 Update mail.api and its dependencies
>
> Hi Prem,
>
> Seems the better way to consume the reference mail implementation is using
> (only) the javax.mail bundle.
>
> See:
> https://javaee.github.io/javamail/
>
> <dependencies>
> <dependency>
> <groupId>com.sun.mail</groupId>
> <artifactId>javax.mail</artifactId>
> <version>1.6.2</version>
> </dependency>
> </dependencies>
>
> Also (a similar issue for another project):
> https://github.com/triplea-game/triplea/pull/2541
>
> I suggest checking to see if a similar change fixes the error messages for us.
>
> Kind regards,
> Marcus
>
> On 2018-11-28, 13:17, "Prem Balakrishnan" <prem.balakrishnan at oracle.com> wrote:
>
> Hi Jie, Marcus
>
> Thank you for the review.
>
> Updated Webrev: http://cr.openjdk.java.net/~pkbalakr/jmc/6217/webrev.01/
> I have used latest versions of javamail and activation.
> With these bundles triggering mail works as expected, but with below warning, seems to be issue with the bundle. Share your feedback on the same.
> javax.mail.Session loadResource
> WARNING: expected resource not found: /META-INF/javamail.default.address.map
>
> I have contacted Yashi regarding third party approval, once review is done we can take further action.
>
> Regards,
> Prem
>
> -----Original Message-----
> From: Marcus Hirt
> Sent: Tuesday, November 27, 2018 8:03 PM
> To: Jie Kang <jkang at redhat.com>; Prem Balakrishnan <prem.balakrishnan at oracle.com>
> Cc: jmc-dev at openjdk.java.net
> Subject: Re: Review Request: JMC-6217 Update mail.api and its dependencies
>
> Hi Jie,
>
> Sounds like a very good idea. Prem, can you please try switching to the Eclipse provided bundles? If all works out, please check with Yashi on third party approvals, and then submit an updated webrev, please.
>
> Kind regards,
> Marcus
>
> On 2018-11-27, 14:33, "Jie Kang" <jkang at redhat.com> wrote:
>
> On Tue, Nov 27, 2018 at 7:05 AM Prem Balakrishnan
> <prem.balakrishnan at oracle.com> wrote:
> >
> > Hi All,
> >
> >
> >
> > Please review the fix for HYPERLINK "https://bugs.openjdk.java.net/browse/JMC-6217"JMC-6217
> >
> > Webrev: http://cr.openjdk.java.net/~pkbalakr/jmc/6217/webrev.00/
> >
> >
> >
> > Issue: javax.activiation is an EE module and it's not shipped any more with JDK 9 onwards.
> >
> > In order to use mail feature in JMC 7.0.0 we need to use mail.api which requires javax.activation.
> >
> >
> >
> > After including javax.activation package, we were still not able to trigger mail in JMC 7.0.
> >
> > Outdated mail.api was causing compatibility issue with "activation", "smtp" and other required bundles,
> >
> > hence updated mail.api and required dependencies.
> >
> >
> >
> > With proposed fix, mail gets triggered as expected and if smtp is not configured relevant exceptions are thrown.
>
> Hi Prem,
>
> javamail and javax.activation as well as a number of other EE packages
> are now under the Eclipse foundation, e.g. @
>
> https://github.com/eclipse-ee4j/javamail
> https://github.com/eclipse-ee4j/jaf
>
> These now have releases as well, 1.6.3. for javamail and 1.2.1 for
> jaf. While we're in this area, should we update to the latest as well?
> The maven coordinates have changed, introducing the jakarta name, but
> I'm not sure how much would need to change in the Tycho system; I'm
> not too familiar with it.
>
>
> Regards,
>
> >
> >
> >
> > Regards,
> > Prem
> >
> >
>
>
>
>
>
>
>
>
More information about the jmc-dev
mailing list