RFR: 8212232: Wrong metadata for the configuration of the cutoff for old object sample events

Markus Gronlund markus.gronlund at oracle.com
Fri Nov 30 13:24:37 UTC 2018


Hi Erik,

Looks good, thanks for fixing this.

Markus

-----Original Message-----
From: Erik Gahlin 
Sent: den 29 november 2018 22:35
To: hotspot-jfr-dev at openjdk.java.net
Cc: jmc-dev at openjdk.java.net
Subject: RFR: 8212232: Wrong metadata for the configuration of the cutoff for old object sample events

Hi,

Could I have a review of a bug fix that changes the content type for the cutoff setting from BooleanFlag to Timespan. Since the threshold setting is also Timespan it will now accept "infinity". The period setting is updated as well.

Bug:
https://bugs.openjdk.java.net/browse/JDK-8212232

Webrev:
http://cr.openjdk.java.net/~egahlin/8212232.0/

Testing:
/test/jdk/jdk/jfr/*

Thanks
Erik


More information about the jmc-dev mailing list