From marcus.hirt at oracle.com Mon Oct 1 08:33:50 2018 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Mon, 01 Oct 2018 10:33:50 +0200 Subject: Review request for JMC-6153: Making the JfrHtmlRulesReport work again Message-ID: <705F4BC0-6A7A-412D-B73E-4EE2662787AF@oracle.com> Hi all, Please review this fix to make the JfrHtmlRulesReport work again. Jira: https://bugs.openjdk.java.net/browse/JMC-6153 The fix is to move core\org.openjdk.jmc.flightrecorder.rules\src\main\java\org\openjdk\jmc\flightrecorder\rules\report\html\resultgroups.xml to core\org.openjdk.jmc.flightrecorder.rules\src\main\resources\org\openjdk\jmc\flightrecorder\rules\report\html\resultgroups.xml Kind regards, Marcus From marcus.hirt at oracle.com Mon Oct 1 10:57:26 2018 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Mon, 01 Oct 2018 12:57:26 +0200 Subject: JMC-6118: Java Mission Control tests fails on OpenJDK 8 In-Reply-To: <0A3A3292-D4A5-4838-B576-690DA53EFFE3@redhat.com> References: <151DB053-0910-4B26-BA7D-FBEE50E24DC8@redhat.com> <5CA1715A-6F81-4A08-9966-85A9DF459E95@oracle.com> <0A3A3292-D4A5-4838-B576-690DA53EFFE3@redhat.com> Message-ID: <1B755453-D45B-4C02-83B0-06B0497718BE@oracle.com> Hi Salman, I would be happy to! Where can I take a look at the patch? Kind regards, Marcus ?On 2018-09-28, 18:21, "jmc-dev on behalf of Salman Siddiqui" wrote: Hi all, I've updated the patch. If someone could please review the changes, that would be great. Thanks, Salman On Fri, Sep 14, 2018 at 10:16 AM Marcus Hirt wrote: > Hi Salman, > > I'll try the patch on my Windows machine at home tonight. If it works on > my machine, > then I'll open up a new bug for fixing so that the browser UI-tests run > properly on > Fedora. > > Kind regards, > Marcus > > ?On 2018-09-14, 06:01, "jmc-dev on behalf of Salman Siddiqui" < > jmc-dev-bounces at openjdk.java.net on behalf of sasiddiq at redhat.com> wrote: > > Hi, > > Please review attached patch file for fix to JMC-6118. > I've tested on Linux (Fedora) with OpenJDK 8. I don't have a Windows > machine available for testing so I'd appreciate some help on that > front. > > Thanks, > Salman > > On Mon, Sep 10, 2018 at 1:32 PM Salman Siddiqui > wrote: > > > Hi, > > > > At the request of Mario, I've been working on JMC-6118. > > Some tests require commercial features and, as a result, are failing > on > > OpenJDK 8. > > My approach for a solution was to have a build profile that will > specify > > test.excludes in the tycho-surefire-plugin configuration for tests > that > > require commercial features. The profile will be activated when an > OpenJDK > > runtime is detected. > > However, it seems to not be working. > > I was hoping someone take a look at the attached patch file and give > some > > pointers on how to approach a fix. > > > > Cheers, > > Salman > > > > > > > -- Salman Siddiqui Software Engineer Intern Red Hat, Toronto, Canada sasiddiq at redhat.com From marcus.hirt at oracle.com Mon Oct 1 11:04:08 2018 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Mon, 01 Oct 2018 13:04:08 +0200 Subject: RFR JMC-5622: Update the updatesite landing pages for 7.0.0 In-Reply-To: References: Message-ID: Hi Sharath, Looks fine! Kind regards, Marcus ?On 2018-09-25, 11:36, "jmc-dev on behalf of Sharath Ballal" wrote: Hi, Pls review changes to updatesite landing pages. Bug id: https://bugs.openjdk.java.net/browse/JMC-5622 Webrev: http://cr.openjdk.java.net/~sballal/JMC-5622/webrev.00/ Thanks, Sharath From guru.hb at oracle.com Mon Oct 1 11:12:33 2018 From: guru.hb at oracle.com (Guru) Date: Mon, 1 Oct 2018 16:42:33 +0530 Subject: Review request for JMC-6153: Making the JfrHtmlRulesReport work again In-Reply-To: <705F4BC0-6A7A-412D-B73E-4EE2662787AF@oracle.com> References: <705F4BC0-6A7A-412D-B73E-4EE2662787AF@oracle.com> Message-ID: <47A194A3-FBCE-4FF3-B21F-64B4856CE2FC@oracle.com> +1, Changes looks good to me. Thanks, Guru > On 01-Oct-2018, at 2:03 PM, Marcus Hirt wrote: > > Hi all, > > Please review this fix to make the JfrHtmlRulesReport work again. > > Jira: https://bugs.openjdk.java.net/browse/JMC-6153 > > The fix is to move core\org.openjdk.jmc.flightrecorder.rules\src\main\java\org\openjdk\jmc\flightrecorder\rules\report\html\resultgroups.xml to core\org.openjdk.jmc.flightrecorder.rules\src\main\resources\org\openjdk\jmc\flightrecorder\rules\report\html\resultgroups.xml > > Kind regards, > Marcus > > From marcus.hirt at oracle.com Mon Oct 1 11:51:21 2018 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Mon, 01 Oct 2018 13:51:21 +0200 Subject: Review request for JMC-6153: Making the JfrHtmlRulesReport work again In-Reply-To: References: <705F4BC0-6A7A-412D-B73E-4EE2662787AF@oracle.com> Message-ID: <3EADECE1-62D1-41DC-A438-90E780D1A7C5@oracle.com> Hi Guru, Added test: http://cr.openjdk.java.net/~hirt/JMC-6153/webrev.01/ Kind regards, Marcus ?On 2018-10-01, 13:12, "Guru" wrote: +1, Changes looks good to me. Thanks, Guru > On 01-Oct-2018, at 2:03 PM, Marcus Hirt wrote: > > Hi all, > > Please review this fix to make the JfrHtmlRulesReport work again. > > Jira: https://bugs.openjdk.java.net/browse/JMC-6153 > > The fix is to move core\org.openjdk.jmc.flightrecorder.rules\src\main\java\org\openjdk\jmc\flightrecorder\rules\report\html\resultgroups.xml to core\org.openjdk.jmc.flightrecorder.rules\src\main\resources\org\openjdk\jmc\flightrecorder\rules\report\html\resultgroups.xml > > Kind regards, > Marcus > > From guru.hb at oracle.com Mon Oct 1 12:34:34 2018 From: guru.hb at oracle.com (Guru) Date: Mon, 1 Oct 2018 18:04:34 +0530 Subject: Review request for JMC-6153: Making the JfrHtmlRulesReport work again In-Reply-To: <3EADECE1-62D1-41DC-A438-90E780D1A7C5@oracle.com> References: <705F4BC0-6A7A-412D-B73E-4EE2662787AF@oracle.com> <3EADECE1-62D1-41DC-A438-90E780D1A7C5@oracle.com> Message-ID: <1828F454-631A-4177-A201-5B75D4AAF19A@oracle.com> +1 to http://cr.openjdk.java.net/~hirt/JMC-6153/webrev.02/ Tested on Windows. Thanks, Guru > On 01-Oct-2018, at 5:21 PM, Marcus Hirt wrote: > > Hi Guru, > > Added test: > http://cr.openjdk.java.net/~hirt/JMC-6153/webrev.01/ > > Kind regards, > Marcus > > ?On 2018-10-01, 13:12, "Guru" wrote: > > +1, Changes looks good to me. > > Thanks, > Guru >> On 01-Oct-2018, at 2:03 PM, Marcus Hirt wrote: >> >> Hi all, >> >> Please review this fix to make the JfrHtmlRulesReport work again. >> >> Jira: https://bugs.openjdk.java.net/browse/JMC-6153 >> >> The fix is to move core\org.openjdk.jmc.flightrecorder.rules\src\main\java\org\openjdk\jmc\flightrecorder\rules\report\html\resultgroups.xml to core\org.openjdk.jmc.flightrecorder.rules\src\main\resources\org\openjdk\jmc\flightrecorder\rules\report\html\resultgroups.xml >> >> Kind regards, >> Marcus >> >> > > > > > From marcus.hirt at oracle.com Mon Oct 1 12:37:30 2018 From: marcus.hirt at oracle.com (marcus.hirt at oracle.com) Date: Mon, 01 Oct 2018 12:37:30 +0000 Subject: hg: jmc/jmc: JMC-6153: Making the JfrHtmlRulesReport work again Message-ID: <201810011237.w91CbUw2016364@aojmv0008.oracle.com> Changeset: 6aeb98d79a5f Author: hirt Date: 2018-10-01 14:37 +0200 URL: http://hg.openjdk.java.net/jmc/jmc/rev/6aeb98d79a5f JMC-6153: Making the JfrHtmlRulesReport work again Reviewed-by: ghb ! core/org.openjdk.jmc.flightrecorder.rules/META-INF/MANIFEST.MF - core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/report/html/resultgroups.xml + core/org.openjdk.jmc.flightrecorder.rules/src/main/resources/org/openjdk/jmc/flightrecorder/rules/report/html/resultgroups.xml ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/java/org/openjdk/jmc/flightrecorder/test/rules/jdk/TestRulesWithJfr.java From kdobson at redhat.com Mon Oct 1 13:50:05 2018 From: kdobson at redhat.com (Ken Dobson) Date: Mon, 1 Oct 2018 09:50:05 -0400 Subject: JMC-5359: Ugly values on Y axis when no events In-Reply-To: References: Message-ID: Hi all, just checking to see if someone could take a quick look at the patch above when they have a chance. Thanks, Ken On Tue, Sep 18, 2018 at 5:17 PM, Ken Dobson wrote: > Hi all, > > This is another simple UI fix for JMC-5359, which also appears to be a > duplicate of JMC-5045 as well. If someone could have a look at it that'd be > great. > Jira: https://bugs.openjdk.java.net/projects/JMC/issues/JMC-5359 > https://bugs.openjdk.java.net/projects/JMC/issues/JMC-5045 > > diff -r 9ebfa2888b8f application/org.openjdk.jmc. > ui/src/main/java/org/openjdk/jmc/ui/charts/XYDataRenderer.java > --- a/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/ > jmc/ui/charts/XYDataRenderer.java Fri Sep 14 01:21:16 2018 +0200 > +++ b/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/ > jmc/ui/charts/XYDataRenderer.java Tue Sep 18 17:11:03 2018 -0400 > @@ -44,6 +44,7 @@ > > import org.openjdk.jmc.common.IDisplayable; > import org.openjdk.jmc.common.unit.IQuantity; > +import org.openjdk.jmc.common.unit.UnitLookup; > import org.openjdk.jmc.common.util.ColorToolkit; > import org.openjdk.jmc.ui.charts.AWTChartToolkit.IColorProvider; > import org.openjdk.jmc.ui.charts.IChartInfoVisitor.IBucket; > @@ -200,9 +201,11 @@ > > if (yAxisMin != null && yAxisMax != null) { > FontMetrics fm = context.getFontMetrics(); > - // If min=max, expand range to be [min, min+1] > + /* If min=max, expand range to be [min, min+1], or [min, > min+1024] in the case of > + a graph measured in bytes*/ > if (yAxisMin.compareTo(yAxisMax) == 0) { > - yAxisMax = yAxisMin.getUnit().quantity(yAxisMin.doubleValue() > + 1); > + int offset = yAxisMin.getUnit() == UnitLookup.BYTE ? 1024 > : 1; > + yAxisMax = yAxisMin.getUnit().quantity(yAxisMin.doubleValue() > + offset); > } else { > // Add sufficient padding to ensure that labels for ticks > <= yAxisMax fit, > // and constant value graphs are discernible. > > Thanks, > > Ken > From marcus.hirt at oracle.com Mon Oct 1 13:57:47 2018 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Mon, 01 Oct 2018 15:57:47 +0200 Subject: JMC-5359: Ugly values on Y axis when no events In-Reply-To: References: Message-ID: Hi Ken, Looks good! Kind regards, Marcus ?On 2018-10-01, 15:50, "jmc-dev on behalf of Ken Dobson" wrote: Hi all, just checking to see if someone could take a quick look at the patch above when they have a chance. Thanks, Ken On Tue, Sep 18, 2018 at 5:17 PM, Ken Dobson wrote: > Hi all, > > This is another simple UI fix for JMC-5359, which also appears to be a > duplicate of JMC-5045 as well. If someone could have a look at it that'd be > great. > Jira: https://bugs.openjdk.java.net/projects/JMC/issues/JMC-5359 > https://bugs.openjdk.java.net/projects/JMC/issues/JMC-5045 > > diff -r 9ebfa2888b8f application/org.openjdk.jmc. > ui/src/main/java/org/openjdk/jmc/ui/charts/XYDataRenderer.java > --- a/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/ > jmc/ui/charts/XYDataRenderer.java Fri Sep 14 01:21:16 2018 +0200 > +++ b/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/ > jmc/ui/charts/XYDataRenderer.java Tue Sep 18 17:11:03 2018 -0400 > @@ -44,6 +44,7 @@ > > import org.openjdk.jmc.common.IDisplayable; > import org.openjdk.jmc.common.unit.IQuantity; > +import org.openjdk.jmc.common.unit.UnitLookup; > import org.openjdk.jmc.common.util.ColorToolkit; > import org.openjdk.jmc.ui.charts.AWTChartToolkit.IColorProvider; > import org.openjdk.jmc.ui.charts.IChartInfoVisitor.IBucket; > @@ -200,9 +201,11 @@ > > if (yAxisMin != null && yAxisMax != null) { > FontMetrics fm = context.getFontMetrics(); > - // If min=max, expand range to be [min, min+1] > + /* If min=max, expand range to be [min, min+1], or [min, > min+1024] in the case of > + a graph measured in bytes*/ > if (yAxisMin.compareTo(yAxisMax) == 0) { > - yAxisMax = yAxisMin.getUnit().quantity(yAxisMin.doubleValue() > + 1); > + int offset = yAxisMin.getUnit() == UnitLookup.BYTE ? 1024 > : 1; > + yAxisMax = yAxisMin.getUnit().quantity(yAxisMin.doubleValue() > + offset); > } else { > // Add sufficient padding to ensure that labels for ticks > <= yAxisMax fit, > // and constant value graphs are discernible. > > Thanks, > > Ken > From marcus.hirt at oracle.com Mon Oct 1 14:00:54 2018 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Mon, 01 Oct 2018 16:00:54 +0200 Subject: JMC-5359: Ugly values on Y axis when no events In-Reply-To: <06030643-3BBD-428A-8CE3-032C2DB6EDDB@oracle.com> References: <06030643-3BBD-428A-8CE3-032C2DB6EDDB@oracle.com> Message-ID: Hi Ken, Check with Mario if he can sponsor your change. I think he is currently busy setting up a new computer. So, if not, I can do it. Kind regards, Marcus ?On 2018-10-01, 15:58, "jmc-dev on behalf of Marcus Hirt" wrote: Hi Ken, Looks good! Kind regards, Marcus ?On 2018-10-01, 15:50, "jmc-dev on behalf of Ken Dobson" wrote: Hi all, just checking to see if someone could take a quick look at the patch above when they have a chance. Thanks, Ken On Tue, Sep 18, 2018 at 5:17 PM, Ken Dobson wrote: > Hi all, > > This is another simple UI fix for JMC-5359, which also appears to be a > duplicate of JMC-5045 as well. If someone could have a look at it that'd be > great. > Jira: https://bugs.openjdk.java.net/projects/JMC/issues/JMC-5359 > https://bugs.openjdk.java.net/projects/JMC/issues/JMC-5045 > > diff -r 9ebfa2888b8f application/org.openjdk.jmc. > ui/src/main/java/org/openjdk/jmc/ui/charts/XYDataRenderer.java > --- a/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/ > jmc/ui/charts/XYDataRenderer.java Fri Sep 14 01:21:16 2018 +0200 > +++ b/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/ > jmc/ui/charts/XYDataRenderer.java Tue Sep 18 17:11:03 2018 -0400 > @@ -44,6 +44,7 @@ > > import org.openjdk.jmc.common.IDisplayable; > import org.openjdk.jmc.common.unit.IQuantity; > +import org.openjdk.jmc.common.unit.UnitLookup; > import org.openjdk.jmc.common.util.ColorToolkit; > import org.openjdk.jmc.ui.charts.AWTChartToolkit.IColorProvider; > import org.openjdk.jmc.ui.charts.IChartInfoVisitor.IBucket; > @@ -200,9 +201,11 @@ > > if (yAxisMin != null && yAxisMax != null) { > FontMetrics fm = context.getFontMetrics(); > - // If min=max, expand range to be [min, min+1] > + /* If min=max, expand range to be [min, min+1], or [min, > min+1024] in the case of > + a graph measured in bytes*/ > if (yAxisMin.compareTo(yAxisMax) == 0) { > - yAxisMax = yAxisMin.getUnit().quantity(yAxisMin.doubleValue() > + 1); > + int offset = yAxisMin.getUnit() == UnitLookup.BYTE ? 1024 > : 1; > + yAxisMax = yAxisMin.getUnit().quantity(yAxisMin.doubleValue() > + offset); > } else { > // Add sufficient padding to ensure that labels for ticks > <= yAxisMax fit, > // and constant value graphs are discernible. > > Thanks, > > Ken > From neugens at redhat.com Mon Oct 1 14:05:20 2018 From: neugens at redhat.com (Mario Torre) Date: Mon, 1 Oct 2018 16:05:20 +0200 Subject: JMC-5359: Ugly values on Y axis when no events In-Reply-To: References: <06030643-3BBD-428A-8CE3-032C2DB6EDDB@oracle.com> Message-ID: On Mon, Oct 1, 2018 at 4:01 PM Marcus Hirt wrote: > > Hi Ken, > > Check with Mario if he can sponsor your change. I think he is currently busy setting up a new computer. So, if not, I can do it. Yeah, still not finished... I'll try to push the patch later tonight if you can't make it before. Cheers, Mario > Kind regards, > Marcus > > ?On 2018-10-01, 15:58, "jmc-dev on behalf of Marcus Hirt" wrote: > > Hi Ken, > > Looks good! > > Kind regards, > Marcus > > ?On 2018-10-01, 15:50, "jmc-dev on behalf of Ken Dobson" wrote: > > Hi all, > > just checking to see if someone could take a quick look at the patch above > when they have a chance. > > Thanks, > > Ken > > On Tue, Sep 18, 2018 at 5:17 PM, Ken Dobson wrote: > > > Hi all, > > > > This is another simple UI fix for JMC-5359, which also appears to be a > > duplicate of JMC-5045 as well. If someone could have a look at it that'd be > > great. > > Jira: https://bugs.openjdk.java.net/projects/JMC/issues/JMC-5359 > > https://bugs.openjdk.java.net/projects/JMC/issues/JMC-5045 > > > > diff -r 9ebfa2888b8f application/org.openjdk.jmc. > > ui/src/main/java/org/openjdk/jmc/ui/charts/XYDataRenderer.java > > --- a/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/ > > jmc/ui/charts/XYDataRenderer.java Fri Sep 14 01:21:16 2018 +0200 > > +++ b/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/ > > jmc/ui/charts/XYDataRenderer.java Tue Sep 18 17:11:03 2018 -0400 > > @@ -44,6 +44,7 @@ > > > > import org.openjdk.jmc.common.IDisplayable; > > import org.openjdk.jmc.common.unit.IQuantity; > > +import org.openjdk.jmc.common.unit.UnitLookup; > > import org.openjdk.jmc.common.util.ColorToolkit; > > import org.openjdk.jmc.ui.charts.AWTChartToolkit.IColorProvider; > > import org.openjdk.jmc.ui.charts.IChartInfoVisitor.IBucket; > > @@ -200,9 +201,11 @@ > > > > if (yAxisMin != null && yAxisMax != null) { > > FontMetrics fm = context.getFontMetrics(); > > - // If min=max, expand range to be [min, min+1] > > + /* If min=max, expand range to be [min, min+1], or [min, > > min+1024] in the case of > > + a graph measured in bytes*/ > > if (yAxisMin.compareTo(yAxisMax) == 0) { > > - yAxisMax = yAxisMin.getUnit().quantity(yAxisMin.doubleValue() > > + 1); > > + int offset = yAxisMin.getUnit() == UnitLookup.BYTE ? 1024 > > : 1; > > + yAxisMax = yAxisMin.getUnit().quantity(yAxisMin.doubleValue() > > + offset); > > } else { > > // Add sufficient padding to ensure that labels for ticks > > <= yAxisMax fit, > > // and constant value graphs are discernible. > > > > Thanks, > > > > Ken > > > > > > > > > > -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From marcus.hirt at oracle.com Mon Oct 1 15:07:09 2018 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Mon, 01 Oct 2018 17:07:09 +0200 Subject: JMC-6118: Java Mission Control tests fails on OpenJDK 8 In-Reply-To: References: <151DB053-0910-4B26-BA7D-FBEE50E24DC8@redhat.com> <5CA1715A-6F81-4A08-9966-85A9DF459E95@oracle.com> <0A3A3292-D4A5-4838-B576-690DA53EFFE3@redhat.com> <1B755453-D45B-4C02-83B0-06B0497718BE@oracle.com> Message-ID: Hi Salman, Looks good to me! Guru, since you're the build maestro, perhaps you can take a look too? Kind regards, Marcus From: Salman Siddiqui Date: Monday, 1 October 2018 at 16:29 To: Subject: Re: JMC-6118: Java Mission Control tests fails on OpenJDK 8 Hi Marcus On Mon, Oct 1, 2018 at 10:57 AM Marcus Hirt wrote: Hi Salman, I would be happy to! Where can I take a look at the patch? I sent it as an attachment to my previous email. It is also pasted below. ? Kind regards, Marcus diff -r 896f9586d4c6 application/pom.xml --- a/application/pom.xml??? Thu Sep 20 08:32:13 2018 -0700 +++ b/application/pom.xml??? Fri Sep 28 12:13:40 2018 -0400 @@ -110,6 +110,20 @@ ???? ???? ???? ??? +??? ??? ??? no-jfr +??? ??? ??? +??? ??? ??? ??? +??? ??? ??? ??? ??? http://java.runtime.name +??? ??? ??? ??? ??? OpenJDK Runtime Environment +??? ??? ??? ??? +??????????????????????????????? (,11) +??? ??? ??? +??? ??? ??? +??? ??? ??? ??? org.openjdk.jmc.rjmx.test.services.CommercialFeaturesServiceTest,org.openjdk.jmc.flightrecorder.controlpanel.ui.model.test.EventConfigurationModelTest,org.openjdk.jmc.flightrecorder.controlpanel.ui.test.PropertyContentBuilderTest,org.openjdk.jmc.flightrecorder.controlpanel.ui.model.test.JfcAndServerSettingsCombinationTest,org.openjdk.jmc.rjmx.services.jfr.test.EventMetadataTest,org.openjdk.jmc.rjmx.services.jfr.test.EventTemplateTest,org.openjdk.jmc.rjmx.services.jfr.test.JfrControlTest,org.openjdk.jmc.rjmx.services.jfr.test.JfrPackageExampleTest,org.openjdk.jmc.rjmx.services.jfr.test.OnlineEventOptionsTest,org.openjdk.jmc.rjmx.services.jfr.test.RecordingOptionsTest +??? ??? ??? ??? +??? ??? ??? +??? ??? +??? ??? ???? ??? ??? uitests ???? ??? ??? ???? ??? ??? ??? uitests @@ -119,6 +133,8 @@ ???? ???? ??? 1.8 ???? ??? 1.8 +??? ??? +??? ??? -XX:+UnlockCommercialFeatures -XX:+FlightRecorder ???? ? ???? diff -r 896f9586d4c6 application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/pom.xml --- a/application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/pom.xml??? Thu Sep 20 08:32:13 2018 -0700 +++ b/application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/pom.xml??? Fri Sep 28 12:13:40 2018 -0400 @@ -47,7 +47,7 @@ ???? ??? ??? ??? tycho-surefire-plugin ???? ??? ??? ??? ${tycho-version} ???? ??? ??? ??? -??? ??? ??? ??? ??? -Dcom.sun.management.jmxremote.port=9999 -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false -Djava.rmi.server.hostname=localhost -Djmc.test.rjmx.serviceURL=service:jmx:rmi:///jndi/rmi://localhost:9999/jmxrmi -XX:+UnlockCommercialFeatures -XX:+FlightRecorder +??? ??? ??? ??? ??? -Dcom.sun.management.jmxremote.port=9999 -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false -Djava.rmi.server.hostname=localhost -Djmc.test.rjmx.serviceURL=service:jmx:rmi:///jndi/rmi://localhost:9999/jmxrmi ${jfr.vmargs} ???? ??? ??? ??? ???? ??? ??? ???? ??? diff -r 896f9586d4c6 application/tests/org.openjdk.jmc.rjmx.services.jfr.test/pom.xml --- a/application/tests/org.openjdk.jmc.rjmx.services.jfr.test/pom.xml??? Thu Sep 20 08:32:13 2018 -0700 +++ b/application/tests/org.openjdk.jmc.rjmx.services.jfr.test/pom.xml??? Fri Sep 28 12:13:40 2018 -0400 @@ -47,8 +47,9 @@ ???? ??? ??? ??? tycho-surefire-plugin ???? ??? ??? ??? ${tycho-version} ???? ??? ??? ??? -??? ??? ??? ??? ??? -Dcom.sun.management.jmxremote.port=9999 -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false -Djava.rmi.server.hostname=localhost -Djmc.test.rjmx.serviceURL=service:jmx:rmi:///jndi/rmi://localhost:9999/jmxrmi -XX:+UnlockCommercialFeatures -XX:+FlightRecorder -??? ??? ??? ??? +??? ??? ??? ??? ??? -Dcom.sun.management.jmxremote.port=9999 -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false -Djava.rmi.server.hostname=localhost -Djmc.test.rjmx.serviceURL=service:jmx:rmi:///jndi/rmi://localhost:9999/jmxrmi ${jfr.vmargs} +??? ??? ??? ??? ??? false +??????????????????????????????? ???? ??? ??? ???? ??? ???? diff -r 896f9586d4c6 application/tests/pom.xml --- a/application/tests/pom.xml??? Thu Sep 20 08:32:13 2018 -0700 +++ b/application/tests/pom.xml??? Fri Sep 28 12:13:40 2018 -0400 @@ -114,7 +114,10 @@ ???? ??? ??? ??? ???? ??? ??? ??? ??? -nl en ???? ??? ??? ??? ??? ${test.includes} -??? ??? ??? ??? ??? ${test.excludes} +??? ??? ??? ??? ??? +??? ??? ??? ??? ??? ??? ${test.excludes} +??? ??? ??? ??? ??? ??? ${jfr.tests} +??? ??? ??? ??? ??? ???? ??? ??? ??? ??? ${fail.if.no.tests} ???? ??? ??? ??? ???? ??? ??? diff -r 896f9586d4c6 pom.xml --- a/pom.xml??? Thu Sep 20 08:32:13 2018 -0700 +++ b/pom.xml??? Fri Sep 28 12:13:40 2018 -0400 @@ -290,7 +290,7 @@ ???? ??? ??? ??? ??? ??? ???? ??? ??? ??? ??? ??? ??? ???? ??? ??? ??? ??? ??? ??? ??? -??? ??? ??? ??? ??? ??? ??? ??? ??? [1.8.0-40,9.0.0) +??? ??? ??? ??? ??? ??? ??? ??? ??? [1.8.0-40,) ???? ??? ??? ??? ??? ??? ??? ??? ??? Building JMC requires Java 8 version JDK 1.8.0_40 or later ???? ??? ??? ??? ??? ??? ??? ??? ???? ??? ??? ??? ??? ??? ??? ??? ??? diff -r 896f9586d4c6 releng/third-party/pom.xml --- a/releng/third-party/pom.xml??? Thu Sep 20 08:32:13 2018 -0700 +++ b/releng/third-party/pom.xml??? Fri Sep 28 12:13:40 2018 -0400 @@ -108,7 +108,7 @@ ???? ??? ??? ??? ??? ??? ???? ??? ??? ??? ??? ??? ??? ???? ??? ??? ??? ??? ??? ??? ??? -??? ??? ??? ??? ??? ??? ??? ??? ??? [1.8.0-40,9.0.0) +??? ??? ??? ??? ??? ??? ??? ??? ??? [1.8.0-40,) ???? ??? ??? ??? ??? ??? ??? ??? ??? Building JMC requires Java 8 version JDK 1.8.0_40 or later ???? ??? ??? ??? ??? ??? ??? ??? ???? ??? ??? ??? ??? ??? ??? ??? ??? ? From jkang at redhat.com Mon Oct 1 20:43:06 2018 From: jkang at redhat.com (Jie Kang) Date: Mon, 1 Oct 2018 16:43:06 -0400 Subject: RFR: JMC-6115 Use Jemmy builds from Maven Central In-Reply-To: References: Message-ID: Hi all, Please find attached an alternative patch that addresses JMC-6115. It adds a step in the maven phase to download the Jemmy libraries from Maven Central. The pom file is also converted to all tabs. Let me know what you think! Regards, -------------- next part -------------- A non-text attachment was scrubbed... Name: jmc-6115.patch Type: text/x-patch Size: 9679 bytes Desc: not available URL: From marcus.hirt at oracle.com Wed Oct 3 10:44:35 2018 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Wed, 03 Oct 2018 12:44:35 +0200 Subject: JMC Roadmap Discussion Message-ID: <7DE79519-24EE-43EA-92A2-B02DD44BB6D3@oracle.com> Hi all, Now that JMC has been open sourced for a little while, I think it would be a good time to talk a little bit about what the future might hold. Since JDK Mission Control is an open source project, I firmly believe this to be something that we should discuss as a community. Therefore I hereby invite anyone who wants to join to a little roadmap discussion: Subject: JMC Roadmap Discussion Location: Google Hangout [1] Date: 2018-10-11 Time: 09:00-10:00 PDT 12:00-13:00 EDT 18:00-19:00 CET 21:30-22:30 IST 01:00-02:00 JST (2018-10-12) If you'd like to join, please send me an e-mail and I'll add you to the invite! Note: It's my first time arranging a video conference with Google Hangouts. Look to the IRC #jmc channel just before the meeting to check if there's been any last minute changes of technology and/or URL. ;) [1] https://hangouts.google.com/hangouts/_/calendar/bWFyY3VzQGhpcnQuc2U.31a058aj5b7c3t57mlns7o13fb?hs=121 From marcus.hirt at oracle.com Wed Oct 3 22:36:29 2018 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Thu, 04 Oct 2018 00:36:29 +0200 Subject: Review request for JMC-6158: Adding JfrAttribute for event type id Message-ID: <4CAE67A3-1D88-45A5-86ED-ED7AA2B1FB7D@oracle.com> Hi all, Please review this fix to provide a JfrAttribute for event type id. Jira: https://bugs.openjdk.java.net/browse/JMC-6158 Webrev: http://cr.openjdk.java.net/~hirt/JMC-6158/webrev.01/ Kind regards, Marcus From guru.hb at oracle.com Thu Oct 4 03:37:03 2018 From: guru.hb at oracle.com (Guru) Date: Thu, 4 Oct 2018 09:07:03 +0530 Subject: Review request for JMC-6158: Adding JfrAttribute for event type id In-Reply-To: <4CAE67A3-1D88-45A5-86ED-ED7AA2B1FB7D@oracle.com> References: <4CAE67A3-1D88-45A5-86ED-ED7AA2B1FB7D@oracle.com> Message-ID: <05CC4483-CB4D-4DE0-899E-811583A6753C@oracle.com> +1, Changes looks good to me. +nit : If possible modify the text "The identifier for the event type of the event? (Three `the` in the sentence). Thanks, Guru > On 04-Oct-2018, at 4:06 AM, Marcus Hirt wrote: > > Hi all, > > Please review this fix to provide a JfrAttribute for event type id. > > Jira: https://bugs.openjdk.java.net/browse/JMC-6158 > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6158/webrev.01/ > > Kind regards, > Marcus > > From sharath.ballal at oracle.com Thu Oct 4 04:34:07 2018 From: sharath.ballal at oracle.com (Sharath Ballal) Date: Thu, 4 Oct 2018 04:34:07 +0000 (UTC) Subject: Review request for JMC-6158: Adding JfrAttribute for event type id In-Reply-To: <05CC4483-CB4D-4DE0-899E-811583A6753C@oracle.com> References: <4CAE67A3-1D88-45A5-86ED-ED7AA2B1FB7D@oracle.com> <05CC4483-CB4D-4DE0-899E-811583A6753C@oracle.com> Message-ID: <2cff3e80-19c0-449b-80cb-38cfa1cc1c50@default> +1, Changes looks good to me. I have a question though, would addition of EVENT_TYPE_ID effect any other test ? Thanks, Sharath -----Original Message----- From: Guru Sent: Thursday, October 04, 2018 9:07 AM To: Marcus Hirt Cc: jmc-dev at openjdk.java.net Subject: Re: Review request for JMC-6158: Adding JfrAttribute for event type id +1, Changes looks good to me. +nit : If possible modify the text "The identifier for the event type of the event? (Three `the` in the sentence). Thanks, Guru > On 04-Oct-2018, at 4:06 AM, Marcus Hirt wrote: > > Hi all, > > Please review this fix to provide a JfrAttribute for event type id. > > Jira: https://bugs.openjdk.java.net/browse/JMC-6158 > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6158/webrev.01/ > > Kind regards, > Marcus > > From marcus.hirt at oracle.com Thu Oct 4 08:09:48 2018 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Thu, 04 Oct 2018 10:09:48 +0200 Subject: Review request for JMC-6158: Adding JfrAttribute for event type id In-Reply-To: References: <4CAE67A3-1D88-45A5-86ED-ED7AA2B1FB7D@oracle.com> Message-ID: <581C0C62-6B89-4DE2-9C55-EA567CEEAD97@oracle.com> Thanks, couldn?t come up with anything better and still grammatically correct, so pushed as is. If someone has a better idea, feel free to adjust. Kind regards, Marcus From: Guru Date: Thursday, 4 October 2018 at 05:37 To: Marcus Hirt Cc: "jmc-dev at openjdk.java.net" Subject: Re: Review request for JMC-6158: Adding JfrAttribute for event type id +1, Changes looks good to me. +nit : If possible modify the text "The identifier for the event type of the event? (Three `the` in the sentence). Thanks, Guru On 04-Oct-2018, at 4:06 AM, Marcus Hirt wrote: Hi all, Please review this fix to provide a JfrAttribute for event type id. Jira: https://bugs.openjdk.java.net/browse/JMC-6158 Webrev: http://cr.openjdk.java.net/~hirt/JMC-6158/webrev.01/ Kind regards, Marcus From marcus.hirt at oracle.com Thu Oct 4 08:13:31 2018 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Thu, 04 Oct 2018 10:13:31 +0200 Subject: Review request for JMC-6158: Adding JfrAttribute for event type id In-Reply-To: <8495611C-3C5D-4F6D-A1E8-9EE547CB79DA@oracle.com> References: <4CAE67A3-1D88-45A5-86ED-ED7AA2B1FB7D@oracle.com> <05CC4483-CB4D-4DE0-899E-811583A6753C@oracle.com> <8495611C-3C5D-4F6D-A1E8-9EE547CB79DA@oracle.com> Message-ID: <958E26DA-7605-481F-B1E8-8A43C486B086@oracle.com> Hi Sharath, No, not that I can think of. That said, this entire area would benefit from better tests. I added a simple verification test in terms of another related attribute, but the test coverage for this part of the code isn't great. Kind regards, Marcus ?On 2018-10-04, 06:34, "Sharath Ballal" wrote: +1, Changes looks good to me. I have a question though, would addition of EVENT_TYPE_ID effect any other test ? Thanks, Sharath -----Original Message----- From: Guru Sent: Thursday, October 04, 2018 9:07 AM To: Marcus Hirt Cc: jmc-dev at openjdk.java.net Subject: Re: Review request for JMC-6158: Adding JfrAttribute for event type id +1, Changes looks good to me. +nit : If possible modify the text "The identifier for the event type of the event? (Three `the` in the sentence). Thanks, Guru > On 04-Oct-2018, at 4:06 AM, Marcus Hirt wrote: > > Hi all, > > Please review this fix to provide a JfrAttribute for event type id. > > Jira: https://bugs.openjdk.java.net/browse/JMC-6158 > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6158/webrev.01/ > > Kind regards, > Marcus > > From marcus.hirt at oracle.com Thu Oct 4 21:27:32 2018 From: marcus.hirt at oracle.com (marcus.hirt at oracle.com) Date: Thu, 04 Oct 2018 21:27:32 +0000 Subject: hg: jmc/jmc: JMC-6158: Adding JfrAttribute for event type id Message-ID: <201810042127.w94LRWIh027131@aojmv0008.oracle.com> Changeset: 9539b8e1c970 Author: hirt Date: 2018-10-04 10:08 +0200 URL: http://hg.openjdk.java.net/jmc/jmc/rev/9539b8e1c970 JMC-6158: Adding JfrAttribute for event type id Reviewed-by: ghb, sballal ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/JfrAttributes.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/messages/internal/Messages.java ! core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/messages/internal/messages.properties + core/tests/org.openjdk.jmc.flightrecorder.test/src/test/java/org/openjdk/jmc/flightrecorder/test/JfrAttributesTest.java ! core/tests/org.openjdk.jmc.flightrecorder.test/src/test/java/org/openjdk/jmc/flightrecorder/test/util/RecordingToolkit.java From neugens at redhat.com Fri Oct 5 08:36:34 2018 From: neugens at redhat.com (Mario Torre) Date: Fri, 05 Oct 2018 10:36:34 +0200 Subject: JMC-5359: Ugly values on Y axis when no events In-Reply-To: References: <06030643-3BBD-428A-8CE3-032C2DB6EDDB@oracle.com> Message-ID: <2eddc4dd8ba62b4c699635a8ce871db81eff76c0.camel@redhat.com> On Mon, 2018-10-01 at 16:00 +0200, Marcus Hirt wrote: > Hi Ken, > > Check with Mario if he can sponsor your change. I think he is > currently busy setting up a new computer. So, if not, I can do it. Ken, could you please send me the actual patch for pushing? While there, I would like to suggest a minor change, on the comment formatting: - // If min=max, expand range to be [min, min+1] + // If min=max, expand range to be [min, min+1], or [min, min+1024] in the case of + // a graph measured in bytes [use single line comments instead of multiline, it's easier to see where the comments start and stop, in alternative I suggest to always use an '*' to highlight a comment line when in multiline]. Cheers, Mario > Kind regards, > Marcus > > ?On 2018-10-01, 15:58, "jmc-dev on behalf of Marcus Hirt" < > jmc-dev-bounces at openjdk.java.net on behalf of marcus.hirt at oracle.com> > wrote: > > Hi Ken, > > Looks good! > > Kind regards, > Marcus > > ?On 2018-10-01, 15:50, "jmc-dev on behalf of Ken Dobson" < > jmc-dev-bounces at openjdk.java.net on behalf of kdobson at redhat.com> > wrote: > > Hi all, > > just checking to see if someone could take a quick look at > the patch above > when they have a chance. > > Thanks, > > Ken > > On Tue, Sep 18, 2018 at 5:17 PM, Ken Dobson < > kdobson at redhat.com> wrote: > > > Hi all, > > > > This is another simple UI fix for JMC-5359, which also > appears to be a > > duplicate of JMC-5045 as well. If someone could have a look > at it that'd be > > great. > > Jira: > https://bugs.openjdk.java.net/projects/JMC/issues/JMC-5359 > > https://bugs.openjdk.java.net/projects/JMC/issues/JMC-5045 > > > > diff -r 9ebfa2888b8f application/org.openjdk.jmc. > > > ui/src/main/java/org/openjdk/jmc/ui/charts/XYDataRenderer.java > > --- > a/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/ > > jmc/ui/charts/XYDataRenderer.java Fri Sep 14 01:21:16 > 2018 +0200 > > +++ > b/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/ > > jmc/ui/charts/XYDataRenderer.java Tue Sep 18 17:11:03 > 2018 -0400 > > @@ -44,6 +44,7 @@ > > > > import org.openjdk.jmc.common.IDisplayable; > > import org.openjdk.jmc.common.unit.IQuantity; > > +import org.openjdk.jmc.common.unit.UnitLookup; > > import org.openjdk.jmc.common.util.ColorToolkit; > > import > org.openjdk.jmc.ui.charts.AWTChartToolkit.IColorProvider; > > import > org.openjdk.jmc.ui.charts.IChartInfoVisitor.IBucket; > > @@ -200,9 +201,11 @@ > > > > if (yAxisMin != null && yAxisMax != null) { > > FontMetrics fm = context.getFontMetrics(); > > - // If min=max, expand range to be [min, min+1] > > + /* If min=max, expand range to be [min, > min+1], or [min, > > min+1024] in the case of > > + a graph measured in bytes*/ > > if (yAxisMin.compareTo(yAxisMax) == 0) { > > - yAxisMax = > yAxisMin.getUnit().quantity(yAxisMin.doubleValue() > > + 1); > > + int offset = yAxisMin.getUnit() == > UnitLookup.BYTE ? 1024 > > : 1; > > + yAxisMax = > yAxisMin.getUnit().quantity(yAxisMin.doubleValue() > > + offset); > > } else { > > // Add sufficient padding to ensure that > labels for ticks > > <= yAxisMax fit, > > // and constant value graphs are > discernible. > > > > Thanks, > > > > Ken > > > > > > > > > > -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From kdobson at redhat.com Fri Oct 5 15:40:01 2018 From: kdobson at redhat.com (Ken Dobson) Date: Fri, 5 Oct 2018 11:40:01 -0400 Subject: JMC-5359: Ugly values on Y axis when no events In-Reply-To: <2eddc4dd8ba62b4c699635a8ce871db81eff76c0.camel@redhat.com> References: <06030643-3BBD-428A-8CE3-032C2DB6EDDB@oracle.com> <2eddc4dd8ba62b4c699635a8ce871db81eff76c0.camel@redhat.com> Message-ID: Attached is the patch with the commenting change made. Ken On Fri, Oct 5, 2018 at 4:36 AM Mario Torre wrote: > On Mon, 2018-10-01 at 16:00 +0200, Marcus Hirt wrote: > > Hi Ken, > > > > Check with Mario if he can sponsor your change. I think he is > > currently busy setting up a new computer. So, if not, I can do it. > > Ken, could you please send me the actual patch for pushing? > > While there, I would like to suggest a minor change, on the comment > formatting: > > - // If min=max, expand range to be [min, min+1] > + // If min=max, expand range to be [min, min+1], or [min, > min+1024] in the case of > + // a graph measured in bytes > > [use single line comments instead of multiline, it's easier to see > where the comments start and stop, in alternative I suggest to always > use an '*' to highlight a comment line when in multiline]. > > Cheers, > Mario > > > Kind regards, > > Marcus > > > > ?On 2018-10-01, 15:58, "jmc-dev on behalf of Marcus Hirt" < > > jmc-dev-bounces at openjdk.java.net on behalf of marcus.hirt at oracle.com> > > wrote: > > > > Hi Ken, > > > > Looks good! > > > > Kind regards, > > Marcus > > > > ?On 2018-10-01, 15:50, "jmc-dev on behalf of Ken Dobson" < > > jmc-dev-bounces at openjdk.java.net on behalf of kdobson at redhat.com> > > wrote: > > > > Hi all, > > > > just checking to see if someone could take a quick look at > > the patch above > > when they have a chance. > > > > Thanks, > > > > Ken > > > > On Tue, Sep 18, 2018 at 5:17 PM, Ken Dobson < > > kdobson at redhat.com> wrote: > > > > > Hi all, > > > > > > This is another simple UI fix for JMC-5359, which also > > appears to be a > > > duplicate of JMC-5045 as well. If someone could have a look > > at it that'd be > > > great. > > > Jira: > > https://bugs.openjdk.java.net/projects/JMC/issues/JMC-5359 > > > https://bugs.openjdk.java.net/projects/JMC/issues/JMC-5045 > > > > > > diff -r 9ebfa2888b8f application/org.openjdk.jmc. > > > > > ui/src/main/java/org/openjdk/jmc/ui/charts/XYDataRenderer.java > > > --- > > a/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/ > > > jmc/ui/charts/XYDataRenderer.java Fri Sep 14 01:21:16 > > 2018 +0200 > > > +++ > > b/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/ > > > jmc/ui/charts/XYDataRenderer.java Tue Sep 18 17:11:03 > > 2018 -0400 > > > @@ -44,6 +44,7 @@ > > > > > > import org.openjdk.jmc.common.IDisplayable; > > > import org.openjdk.jmc.common.unit.IQuantity; > > > +import org.openjdk.jmc.common.unit.UnitLookup; > > > import org.openjdk.jmc.common.util.ColorToolkit; > > > import > > org.openjdk.jmc.ui.charts.AWTChartToolkit.IColorProvider; > > > import > > org.openjdk.jmc.ui.charts.IChartInfoVisitor.IBucket; > > > @@ -200,9 +201,11 @@ > > > > > > if (yAxisMin != null && yAxisMax != null) { > > > FontMetrics fm = context.getFontMetrics(); > > > - // If min=max, expand range to be [min, min+1] > > > + /* If min=max, expand range to be [min, > > min+1], or [min, > > > min+1024] in the case of > > > + a graph measured in bytes*/ > > > if (yAxisMin.compareTo(yAxisMax) == 0) { > > > - yAxisMax = > > yAxisMin.getUnit().quantity(yAxisMin.doubleValue() > > > + 1); > > > + int offset = yAxisMin.getUnit() == > > UnitLookup.BYTE ? 1024 > > > : 1; > > > + yAxisMax = > > yAxisMin.getUnit().quantity(yAxisMin.doubleValue() > > > + offset); > > > } else { > > > // Add sufficient padding to ensure that > > labels for ticks > > > <= yAxisMax fit, > > > // and constant value graphs are > > discernible. > > > > > > Thanks, > > > > > > Ken > > > > > > > > > > > > > > > > > > > > -- > Mario Torre > Associate Manager, Software Engineering > Red Hat GmbH > 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > > -------------- next part -------------- A non-text attachment was scrubbed... Name: JMC-5359.patch Type: text/x-patch Size: 1448 bytes Desc: not available URL: From neugens.limasoftware at gmail.com Fri Oct 5 15:58:33 2018 From: neugens.limasoftware at gmail.com (neugens.limasoftware at gmail.com) Date: Fri, 05 Oct 2018 15:58:33 +0000 Subject: hg: jmc/jmc: JMC-5359: Ugly values on Y axis when no events Message-ID: <201810051558.w95FwX7u021364@aojmv0008.oracle.com> Changeset: ba12bfb55277 Author: neugens Date: 2018-10-05 17:49 +0200 URL: http://hg.openjdk.java.net/jmc/jmc/rev/ba12bfb55277 JMC-5359: Ugly values on Y axis when no events Summary: add code for graph measured in bytes Reviewed-by: neugens, hirt Contributed-by: Ken Dobson ! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/XYDataRenderer.java From neugens at redhat.com Fri Oct 5 15:59:02 2018 From: neugens at redhat.com (Mario Torre) Date: Fri, 5 Oct 2018 17:59:02 +0200 Subject: JMC-5359: Ugly values on Y axis when no events In-Reply-To: References: <06030643-3BBD-428A-8CE3-032C2DB6EDDB@oracle.com> <2eddc4dd8ba62b4c699635a8ce871db81eff76c0.camel@redhat.com> Message-ID: Pushed, congratulations! Cheers, Mario On Fri, Oct 5, 2018 at 5:40 PM Ken Dobson wrote: > > Attached is the patch with the commenting change made. > > Ken > > On Fri, Oct 5, 2018 at 4:36 AM Mario Torre wrote: >> >> On Mon, 2018-10-01 at 16:00 +0200, Marcus Hirt wrote: >> > Hi Ken, >> > >> > Check with Mario if he can sponsor your change. I think he is >> > currently busy setting up a new computer. So, if not, I can do it. >> >> Ken, could you please send me the actual patch for pushing? >> >> While there, I would like to suggest a minor change, on the comment >> formatting: >> >> - // If min=max, expand range to be [min, min+1] >> + // If min=max, expand range to be [min, min+1], or [min, >> min+1024] in the case of >> + // a graph measured in bytes >> >> [use single line comments instead of multiline, it's easier to see >> where the comments start and stop, in alternative I suggest to always >> use an '*' to highlight a comment line when in multiline]. >> >> Cheers, >> Mario >> >> > Kind regards, >> > Marcus >> > >> > ?On 2018-10-01, 15:58, "jmc-dev on behalf of Marcus Hirt" < >> > jmc-dev-bounces at openjdk.java.net on behalf of marcus.hirt at oracle.com> >> > wrote: >> > >> > Hi Ken, >> > >> > Looks good! >> > >> > Kind regards, >> > Marcus >> > >> > ?On 2018-10-01, 15:50, "jmc-dev on behalf of Ken Dobson" < >> > jmc-dev-bounces at openjdk.java.net on behalf of kdobson at redhat.com> >> > wrote: >> > >> > Hi all, >> > >> > just checking to see if someone could take a quick look at >> > the patch above >> > when they have a chance. >> > >> > Thanks, >> > >> > Ken >> > >> > On Tue, Sep 18, 2018 at 5:17 PM, Ken Dobson < >> > kdobson at redhat.com> wrote: >> > >> > > Hi all, >> > > >> > > This is another simple UI fix for JMC-5359, which also >> > appears to be a >> > > duplicate of JMC-5045 as well. If someone could have a look >> > at it that'd be >> > > great. >> > > Jira: >> > https://bugs.openjdk.java.net/projects/JMC/issues/JMC-5359 >> > > https://bugs.openjdk.java.net/projects/JMC/issues/JMC-5045 >> > > >> > > diff -r 9ebfa2888b8f application/org.openjdk.jmc. >> > > >> > ui/src/main/java/org/openjdk/jmc/ui/charts/XYDataRenderer.java >> > > --- >> > a/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/ >> > > jmc/ui/charts/XYDataRenderer.java Fri Sep 14 01:21:16 >> > 2018 +0200 >> > > +++ >> > b/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/ >> > > jmc/ui/charts/XYDataRenderer.java Tue Sep 18 17:11:03 >> > 2018 -0400 >> > > @@ -44,6 +44,7 @@ >> > > >> > > import org.openjdk.jmc.common.IDisplayable; >> > > import org.openjdk.jmc.common.unit.IQuantity; >> > > +import org.openjdk.jmc.common.unit.UnitLookup; >> > > import org.openjdk.jmc.common.util.ColorToolkit; >> > > import >> > org.openjdk.jmc.ui.charts.AWTChartToolkit.IColorProvider; >> > > import >> > org.openjdk.jmc.ui.charts.IChartInfoVisitor.IBucket; >> > > @@ -200,9 +201,11 @@ >> > > >> > > if (yAxisMin != null && yAxisMax != null) { >> > > FontMetrics fm = context.getFontMetrics(); >> > > - // If min=max, expand range to be [min, min+1] >> > > + /* If min=max, expand range to be [min, >> > min+1], or [min, >> > > min+1024] in the case of >> > > + a graph measured in bytes*/ >> > > if (yAxisMin.compareTo(yAxisMax) == 0) { >> > > - yAxisMax = >> > yAxisMin.getUnit().quantity(yAxisMin.doubleValue() >> > > + 1); >> > > + int offset = yAxisMin.getUnit() == >> > UnitLookup.BYTE ? 1024 >> > > : 1; >> > > + yAxisMax = >> > yAxisMin.getUnit().quantity(yAxisMin.doubleValue() >> > > + offset); >> > > } else { >> > > // Add sufficient padding to ensure that >> > labels for ticks >> > > <= yAxisMax fit, >> > > // and constant value graphs are >> > discernible. >> > > >> > > Thanks, >> > > >> > > Ken >> > > >> > >> > >> > >> > >> > >> > >> > >> > >> -- >> Mario Torre >> Associate Manager, Software Engineering >> Red Hat GmbH >> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 >> -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From sasiddiq at redhat.com Fri Oct 5 19:48:43 2018 From: sasiddiq at redhat.com (Salman Siddiqui) Date: Fri, 5 Oct 2018 19:48:43 +0000 Subject: JMC-6118: Java Mission Control tests fails on OpenJDK 8 In-Reply-To: References: <151DB053-0910-4B26-BA7D-FBEE50E24DC8@redhat.com> <5CA1715A-6F81-4A08-9966-85A9DF459E95@oracle.com> <0A3A3292-D4A5-4838-B576-690DA53EFFE3@redhat.com> <1B755453-D45B-4C02-83B0-06B0497718BE@oracle.com> Message-ID: Hi Guru, Could you please send a log of the errors you encountered on Ubuntu? Thanks, Salman On Mon, Oct 1, 2018 at 11:07 AM Marcus Hirt wrote: > Hi Salman, > > Looks good to me! Guru, since you're the build maestro, > perhaps you can take a look too? > > Kind regards, > Marcus > > > From: Salman Siddiqui > Date: Monday, 1 October 2018 at 16:29 > To: > Subject: Re: JMC-6118: Java Mission Control tests fails on OpenJDK 8 > > Hi Marcus > > On Mon, Oct 1, 2018 at 10:57 AM Marcus Hirt > wrote: > Hi Salman, > I would be happy to! Where can I take a look at the patch? > > I sent it as an attachment to my previous email. It is also pasted below. > > > Kind regards, > Marcus > > > diff -r 896f9586d4c6 application/pom.xml > --- a/application/pom.xml Thu Sep 20 08:32:13 2018 -0700 > +++ b/application/pom.xml Fri Sep 28 12:13:40 2018 -0400 > @@ -110,6 +110,20 @@ > > > > + no-jfr > + > + > + http://java.runtime.name > + OpenJDK Runtime Environment > + > + (,11) > + > + > + > org.openjdk.jmc.rjmx.test.services.CommercialFeaturesServiceTest,org.openjdk.jmc.flightrecorder.controlpanel.ui.model.test.EventConfigurationModelTest,org.openjdk.jmc.flightrecorder.controlpanel.ui.test.PropertyContentBuilderTest,org.openjdk.jmc.flightrecorder.controlpanel.ui.model.test.JfcAndServerSettingsCombinationTest,org.openjdk.jmc.rjmx.services.jfr.test.EventMetadataTest,org.openjdk.jmc.rjmx.services.jfr.test.EventTemplateTest,org.openjdk.jmc.rjmx.services.jfr.test.JfrControlTest,org.openjdk.jmc.rjmx.services.jfr.test.JfrPackageExampleTest,org.openjdk.jmc.rjmx.services.jfr.test.OnlineEventOptionsTest,org.openjdk.jmc.rjmx.services.jfr.test.RecordingOptionsTest > + > + > + > + > uitests > > uitests > @@ -119,6 +133,8 @@ > > 1.8 > 1.8 > + > + -XX:+UnlockCommercialFeatures > -XX:+FlightRecorder > > > > diff -r 896f9586d4c6 > application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/pom.xml > --- > a/application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/pom.xml > Thu Sep 20 08:32:13 2018 -0700 > +++ > b/application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/pom.xml > Fri Sep 28 12:13:40 2018 -0400 > @@ -47,7 +47,7 @@ > tycho-surefire-plugin > ${tycho-version} > > - -Dcom.sun.management.jmxremote.port=9999 > -Dcom.sun.management.jmxremote.authenticate=false > -Dcom.sun.management.jmxremote.ssl=false > -Djava.rmi.server.hostname=localhost > -Djmc.test.rjmx.serviceURL=service:jmx:rmi:///jndi/rmi://localhost:9999/jmxrmi > -XX:+UnlockCommercialFeatures -XX:+FlightRecorder > + -Dcom.sun.management.jmxremote.port=9999 > -Dcom.sun.management.jmxremote.authenticate=false > -Dcom.sun.management.jmxremote.ssl=false > -Djava.rmi.server.hostname=localhost > -Djmc.test.rjmx.serviceURL=service:jmx:rmi:///jndi/rmi://localhost:9999/jmxrmi > ${jfr.vmargs} > > > > diff -r 896f9586d4c6 > application/tests/org.openjdk.jmc.rjmx.services.jfr.test/pom.xml > --- a/application/tests/org.openjdk.jmc.rjmx.services.jfr.test/pom.xml > Thu Sep 20 08:32:13 2018 -0700 > +++ b/application/tests/org.openjdk.jmc.rjmx.services.jfr.test/pom.xml > Fri Sep 28 12:13:40 2018 -0400 > @@ -47,8 +47,9 @@ > tycho-surefire-plugin > ${tycho-version} > > - -Dcom.sun.management.jmxremote.port=9999 > -Dcom.sun.management.jmxremote.authenticate=false > -Dcom.sun.management.jmxremote.ssl=false > -Djava.rmi.server.hostname=localhost > -Djmc.test.rjmx.serviceURL=service:jmx:rmi:///jndi/rmi://localhost:9999/jmxrmi > -XX:+UnlockCommercialFeatures -XX:+FlightRecorder > - > + -Dcom.sun.management.jmxremote.port=9999 > -Dcom.sun.management.jmxremote.authenticate=false > -Dcom.sun.management.jmxremote.ssl=false > -Djava.rmi.server.hostname=localhost > -Djmc.test.rjmx.serviceURL=service:jmx:rmi:///jndi/rmi://localhost:9999/jmxrmi > ${jfr.vmargs} > + false > + > > > > diff -r 896f9586d4c6 application/tests/pom.xml > --- a/application/tests/pom.xml Thu Sep 20 08:32:13 2018 -0700 > +++ b/application/tests/pom.xml Fri Sep 28 12:13:40 2018 -0400 > @@ -114,7 +114,10 @@ > > -nl en > ${test.includes} > - ${test.excludes} > + > + ${test.excludes} > + ${jfr.tests} > + > ${fail.if.no.tests} > > > diff -r 896f9586d4c6 pom.xml > --- a/pom.xml Thu Sep 20 08:32:13 2018 -0700 > +++ b/pom.xml Fri Sep 28 12:13:40 2018 -0400 > @@ -290,7 +290,7 @@ > > > > - [1.8.0-40,9.0.0) > + [1.8.0-40,) > Building JMC requires Java 8 > version JDK 1.8.0_40 or later > > > diff -r 896f9586d4c6 releng/third-party/pom.xml > --- a/releng/third-party/pom.xml Thu Sep 20 08:32:13 2018 -0700 > +++ b/releng/third-party/pom.xml Fri Sep 28 12:13:40 2018 -0400 > @@ -108,7 +108,7 @@ > > > > - [1.8.0-40,9.0.0) > + [1.8.0-40,) > Building JMC requires Java 8 > version JDK 1.8.0_40 or later > > > > > > From andrew at nmedia.net Mon Oct 8 17:49:27 2018 From: andrew at nmedia.net (Andrew Munn) Date: Mon, 8 Oct 2018 10:49:27 -0700 (PDT) Subject: JMC plugin for Oracle Coherence Message-ID: I'm using JMC with JDK-11. How can I use the Coherence plugin mentioned here: https://coherencedownunder.wordpress.com/2017/10/19/updated-coherence-plug-in-with-java-9-mission-control/ Thanks! From klara.ward at oracle.com Tue Oct 9 11:15:14 2018 From: klara.ward at oracle.com (Klara Ward) Date: Tue, 9 Oct 2018 13:15:14 +0200 Subject: JMC plugin for Oracle Coherence In-Reply-To: References: Message-ID: <4f76c53c-d88d-2f31-5e10-be1cd46766a5@oracle.com> >From what I remember, and assuming this has not changed since I was active in the JMC team; The Coherence plugin was not open sourced, to access it you have to wait until it is released as part of "Oracle JMC 7". For Oracle JMC 7, the Coherence plugin would be released on an updatesite for install in the JMC app or in Eclipse. You could also run it in JMC 6, included in Oracle JDK 9. // Klara On 2018-10-08 19:49, Andrew Munn wrote: > I'm using JMC with JDK-11. How can I use the Coherence plugin mentioned > here: > > https://coherencedownunder.wordpress.com/2017/10/19/updated-coherence-plug-in-with-java-9-mission-control/ > > Thanks! From guru.hb at oracle.com Tue Oct 9 11:21:12 2018 From: guru.hb at oracle.com (Guru) Date: Tue, 9 Oct 2018 16:51:12 +0530 Subject: JMC plugin for Oracle Coherence In-Reply-To: <4f76c53c-d88d-2f31-5e10-be1cd46766a5@oracle.com> References: <4f76c53c-d88d-2f31-5e10-be1cd46766a5@oracle.com> Message-ID: Comments inline. > On 09-Oct-2018, at 4:45 PM, Klara Ward wrote: > > From what I remember, and assuming this has not changed since I was > active in the JMC team; Yes, you are correct. > > The Coherence plugin was not open sourced, to access it you have to wait > until it is released as part of "Oracle JMC 7". > For Oracle JMC 7, the Coherence plugin would be released on an > updatesite for install in the JMC app or in Eclipse. We have not released Coherence plugin update sites for JMC 7. > > You could also run it in JMC 6, included in Oracle JDK 9. > > // Klara > > On 2018-10-08 19:49, Andrew Munn wrote: >> I'm using JMC with JDK-11. How can I use the Coherence plugin mentioned >> here: >> >> https://coherencedownunder.wordpress.com/2017/10/19/updated-coherence-plug-in-with-java-9-mission-control/ >> >> Thanks! > > From marcus.hirt at oracle.com Wed Oct 10 08:46:21 2018 From: marcus.hirt at oracle.com (marcus.hirt at oracle.com) Date: Wed, 10 Oct 2018 08:46:21 +0000 Subject: hg: jmc/jmc: JMC-6158: Fixing copy-and-paste error Message-ID: <201810100846.w9A8kLWc023387@aojmv0008.oracle.com> Changeset: e9b084ee1021 Author: hirt Date: 2018-10-10 10:46 +0200 URL: http://hg.openjdk.java.net/jmc/jmc/rev/e9b084ee1021 JMC-6158: Fixing copy-and-paste error Reviewed-by: vpaliwal ! core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/messages/internal/messages.properties From marcus.hirt at oracle.com Wed Oct 10 09:53:53 2018 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Wed, 10 Oct 2018 11:53:53 +0200 Subject: Review request for JMC-6161: Reficio maven repo no longer available making it impossible to build JMC Message-ID: <53DFB910-6C66-490F-AD1A-B2FEA420E9AD@oracle.com> Hi all, Please review this fix to make it possible to build JMC again (especially for new users not having the p2-maven plug-in cached). Jira:?? https://bugs.openjdk.java.net/browse/JMC-6161 Webrev: http://cr.openjdk.java.net/~hirt/JMC-6161/webrev.01/ Kind regards, Marcus From miro.wengner at gmail.com Wed Oct 10 12:53:31 2018 From: miro.wengner at gmail.com (Miro Wengner) Date: Wed, 10 Oct 2018 14:53:31 +0200 Subject: Review request for JMC-6161: Reficio maven repo no longer available making it impossible to build JMC In-Reply-To: <53DFB910-6C66-490F-AD1A-B2FEA420E9AD@oracle.com> References: <53DFB910-6C66-490F-AD1A-B2FEA420E9AD@oracle.com> Message-ID: <99DA0F06-F65A-4644-94C5-5040D93A48D0@gmail.com> all looks good, compiles and run Kind Regards, Miro > On Oct 10, 2018, at 11:53 AM, Marcus Hirt wrote: > > Hi all, > > > > Please review this fix to make it possible to build JMC again (especially for new users not having the p2-maven plug-in cached). > > > > Jira: https://bugs.openjdk.java.net/browse/JMC-6161 > > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6161/webrev.01/ > > > > Kind regards, > > Marcus > From marcus.hirt at oracle.com Wed Oct 10 13:18:59 2018 From: marcus.hirt at oracle.com (marcus.hirt at oracle.com) Date: Wed, 10 Oct 2018 13:18:59 +0000 Subject: hg: jmc/jmc: JMC-6161: Getting the p2-maven plug-in from maven central, making jmc buildable again Message-ID: <201810101318.w9ADIxF2025645@aojmv0008.oracle.com> Changeset: 2177c12e7894 Author: hirt Date: 2018-10-10 15:18 +0200 URL: http://hg.openjdk.java.net/jmc/jmc/rev/2177c12e7894 JMC-6161: Getting the p2-maven plug-in from maven central, making jmc buildable again Summary: The reficio maven repo doesn't seem to be up anymore, and there is a released version of it on maven central Reviewed-by: mwengner ! releng/third-party/pom.xml From sasiddiq at redhat.com Wed Oct 10 16:53:52 2018 From: sasiddiq at redhat.com (Salman Siddiqui) Date: Wed, 10 Oct 2018 12:53:52 -0400 Subject: JMC-6118: Java Mission Control tests fails on OpenJDK 8 In-Reply-To: References: <151DB053-0910-4B26-BA7D-FBEE50E24DC8@redhat.com> <5CA1715A-6F81-4A08-9966-85A9DF459E95@oracle.com> <0A3A3292-D4A5-4838-B576-690DA53EFFE3@redhat.com> <1B755453-D45B-4C02-83B0-06B0497718BE@oracle.com> Message-ID: Hi Guru, I tested the patch on an Ubuntu 18.04 VM and it works fine. Can you please take another look and send me a more detailed log of the issue you experienced? Thanks, Salman On Fri, Oct 5, 2018 at 3:48 PM Salman Siddiqui wrote: > Hi Guru, > > Could you please send a log of the errors you encountered on Ubuntu? > > Thanks, > Salman > > On Mon, Oct 1, 2018 at 11:07 AM Marcus Hirt > wrote: > >> Hi Salman, >> >> Looks good to me! Guru, since you're the build maestro, >> perhaps you can take a look too? >> >> Kind regards, >> Marcus >> >> >> From: Salman Siddiqui >> Date: Monday, 1 October 2018 at 16:29 >> To: >> Subject: Re: JMC-6118: Java Mission Control tests fails on OpenJDK 8 >> >> Hi Marcus >> >> On Mon, Oct 1, 2018 at 10:57 AM Marcus Hirt > marcus.hirt at oracle.com> wrote: >> Hi Salman, >> I would be happy to! Where can I take a look at the patch? >> >> I sent it as an attachment to my previous email. It is also pasted below. >> >> >> Kind regards, >> Marcus >> >> >> diff -r 896f9586d4c6 application/pom.xml >> --- a/application/pom.xml Thu Sep 20 08:32:13 2018 -0700 >> +++ b/application/pom.xml Fri Sep 28 12:13:40 2018 -0400 >> @@ -110,6 +110,20 @@ >> >> >> >> + no-jfr >> + >> + >> + http://java.runtime.name >> + OpenJDK Runtime Environment >> + >> + (,11) >> + >> + >> + >> org.openjdk.jmc.rjmx.test.services.CommercialFeaturesServiceTest,org.openjdk.jmc.flightrecorder.controlpanel.ui.model.test.EventConfigurationModelTest,org.openjdk.jmc.flightrecorder.controlpanel.ui.test.PropertyContentBuilderTest,org.openjdk.jmc.flightrecorder.controlpanel.ui.model.test.JfcAndServerSettingsCombinationTest,org.openjdk.jmc.rjmx.services.jfr.test.EventMetadataTest,org.openjdk.jmc.rjmx.services.jfr.test.EventTemplateTest,org.openjdk.jmc.rjmx.services.jfr.test.JfrControlTest,org.openjdk.jmc.rjmx.services.jfr.test.JfrPackageExampleTest,org.openjdk.jmc.rjmx.services.jfr.test.OnlineEventOptionsTest,org.openjdk.jmc.rjmx.services.jfr.test.RecordingOptionsTest >> + >> + >> + >> + >> uitests >> >> uitests >> @@ -119,6 +133,8 @@ >> >> 1.8 >> 1.8 >> + >> + -XX:+UnlockCommercialFeatures >> -XX:+FlightRecorder >> >> >> >> diff -r 896f9586d4c6 >> application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/pom.xml >> --- >> a/application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/pom.xml >> Thu Sep 20 08:32:13 2018 -0700 >> +++ >> b/application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/pom.xml >> Fri Sep 28 12:13:40 2018 -0400 >> @@ -47,7 +47,7 @@ >> tycho-surefire-plugin >> ${tycho-version} >> >> - -Dcom.sun.management.jmxremote.port=9999 >> -Dcom.sun.management.jmxremote.authenticate=false >> -Dcom.sun.management.jmxremote.ssl=false >> -Djava.rmi.server.hostname=localhost >> -Djmc.test.rjmx.serviceURL=service:jmx:rmi:///jndi/rmi://localhost:9999/jmxrmi >> -XX:+UnlockCommercialFeatures -XX:+FlightRecorder >> + -Dcom.sun.management.jmxremote.port=9999 >> -Dcom.sun.management.jmxremote.authenticate=false >> -Dcom.sun.management.jmxremote.ssl=false >> -Djava.rmi.server.hostname=localhost >> -Djmc.test.rjmx.serviceURL=service:jmx:rmi:///jndi/rmi://localhost:9999/jmxrmi >> ${jfr.vmargs} >> >> >> >> diff -r 896f9586d4c6 >> application/tests/org.openjdk.jmc.rjmx.services.jfr.test/pom.xml >> --- a/application/tests/org.openjdk.jmc.rjmx.services.jfr.test/pom.xml >> Thu Sep 20 08:32:13 2018 -0700 >> +++ b/application/tests/org.openjdk.jmc.rjmx.services.jfr.test/pom.xml >> Fri Sep 28 12:13:40 2018 -0400 >> @@ -47,8 +47,9 @@ >> tycho-surefire-plugin >> ${tycho-version} >> >> - -Dcom.sun.management.jmxremote.port=9999 >> -Dcom.sun.management.jmxremote.authenticate=false >> -Dcom.sun.management.jmxremote.ssl=false >> -Djava.rmi.server.hostname=localhost >> -Djmc.test.rjmx.serviceURL=service:jmx:rmi:///jndi/rmi://localhost:9999/jmxrmi >> -XX:+UnlockCommercialFeatures -XX:+FlightRecorder >> - >> + -Dcom.sun.management.jmxremote.port=9999 >> -Dcom.sun.management.jmxremote.authenticate=false >> -Dcom.sun.management.jmxremote.ssl=false >> -Djava.rmi.server.hostname=localhost >> -Djmc.test.rjmx.serviceURL=service:jmx:rmi:///jndi/rmi://localhost:9999/jmxrmi >> ${jfr.vmargs} >> + false >> + >> >> >> >> diff -r 896f9586d4c6 application/tests/pom.xml >> --- a/application/tests/pom.xml Thu Sep 20 08:32:13 2018 -0700 >> +++ b/application/tests/pom.xml Fri Sep 28 12:13:40 2018 -0400 >> @@ -114,7 +114,10 @@ >> >> -nl en >> ${test.includes} >> - ${test.excludes} >> + >> + ${test.excludes} >> + ${jfr.tests} >> + >> ${fail.if.no.tests} >> >> >> diff -r 896f9586d4c6 pom.xml >> --- a/pom.xml Thu Sep 20 08:32:13 2018 -0700 >> +++ b/pom.xml Fri Sep 28 12:13:40 2018 -0400 >> @@ -290,7 +290,7 @@ >> >> >> >> - [1.8.0-40,9.0.0) >> + [1.8.0-40,) >> Building JMC requires Java >> 8 version JDK 1.8.0_40 or later >> >> >> diff -r 896f9586d4c6 releng/third-party/pom.xml >> --- a/releng/third-party/pom.xml Thu Sep 20 08:32:13 2018 -0700 >> +++ b/releng/third-party/pom.xml Fri Sep 28 12:13:40 2018 -0400 >> @@ -108,7 +108,7 @@ >> >> >> >> - [1.8.0-40,9.0.0) >> + [1.8.0-40,) >> Building JMC requires Java >> 8 version JDK 1.8.0_40 or later >> >> >> >> >> >> From jkang at redhat.com Wed Oct 10 17:29:31 2018 From: jkang at redhat.com (Jie Kang) Date: Wed, 10 Oct 2018 13:29:31 -0400 Subject: RFR: JMC-6115 Use Jemmy builds from Maven Central In-Reply-To: References: Message-ID: On Mon, Oct 1, 2018 at 4:43 PM Jie Kang wrote: > > Hi all, > > Please find attached an alternative patch that addresses JMC-6115. It > adds a step in the maven phase to download the Jemmy libraries from > Maven Central. The pom file is also converted to all tabs. Let me know > what you think! Hi, Would anyone be able to look at the alternative patch I've proposed? I've attached it again to this e-mail. Regards, > > > Regards, -------------- next part -------------- A non-text attachment was scrubbed... Name: jmc-6115.patch Type: text/x-patch Size: 9679 bytes Desc: not available URL: From marcus.hirt at oracle.com Thu Oct 11 11:09:29 2018 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Thu, 11 Oct 2018 13:09:29 +0200 Subject: JMC Roadmap Discussion In-Reply-To: <391F1987-7CBA-41D1-8B4F-765E586B5F18@oracle.com> References: <391F1987-7CBA-41D1-8B4F-765E586B5F18@oracle.com> Message-ID: Hi all, This is a quick reminder regarding today's roadmap discussion. There are currently 12 participants. If you have not received an invite, please let me know! Kind regards, Marcus ?On 2018-10-03, 12:45, "jmc-dev on behalf of Marcus Hirt" wrote: Hi all, Now that JMC has been open sourced for a little while, I think it would be a good time to talk a little bit about what the future might hold. Since JDK Mission Control is an open source project, I firmly believe this to be something that we should discuss as a community. Therefore I hereby invite anyone who wants to join to a little roadmap discussion: Subject: JMC Roadmap Discussion Location: Google Hangout [1] Date: 2018-10-11 Time: 09:00-10:00 PDT 12:00-13:00 EDT 18:00-19:00 CET 21:30-22:30 IST 01:00-02:00 JST (2018-10-12) If you'd like to join, please send me an e-mail and I'll add you to the invite! Note: It's my first time arranging a video conference with Google Hangouts. Look to the IRC #jmc channel just before the meeting to check if there's been any last minute changes of technology and/or URL. ;) [1] https://hangouts.google.com/hangouts/_/calendar/bWFyY3VzQGhpcnQuc2U.31a058aj5b7c3t57mlns7o13fb?hs=121 From marcus.hirt at oracle.com Thu Oct 11 15:57:40 2018 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Thu, 11 Oct 2018 17:57:40 +0200 Subject: JMC Roadmap Discussion In-Reply-To: <98E98BDC-DF92-4059-B87E-32D6DC965660@oracle.com> References: <391F1987-7CBA-41D1-8B4F-765E586B5F18@oracle.com> <98E98BDC-DF92-4059-B87E-32D6DC965660@oracle.com> Message-ID: Seems hangout didn't work for me whilst on the Oracle network. We will use this instead: https://oracle.zoom.us/my/marcus.hirt?pwd=Q01tNklrZGVMTys4TkRvYmRkTm83Zz09 Kind regards, Marcus ?On 2018-10-11, 13:10, "jmc-dev on behalf of Marcus Hirt" wrote: Hi all, This is a quick reminder regarding today's roadmap discussion. There are currently 12 participants. If you have not received an invite, please let me know! Kind regards, Marcus ?On 2018-10-03, 12:45, "jmc-dev on behalf of Marcus Hirt" wrote: Hi all, Now that JMC has been open sourced for a little while, I think it would be a good time to talk a little bit about what the future might hold. Since JDK Mission Control is an open source project, I firmly believe this to be something that we should discuss as a community. Therefore I hereby invite anyone who wants to join to a little roadmap discussion: Subject: JMC Roadmap Discussion Location: Google Hangout [1] Date: 2018-10-11 Time: 09:00-10:00 PDT 12:00-13:00 EDT 18:00-19:00 CET 21:30-22:30 IST 01:00-02:00 JST (2018-10-12) If you'd like to join, please send me an e-mail and I'll add you to the invite! Note: It's my first time arranging a video conference with Google Hangouts. Look to the IRC #jmc channel just before the meeting to check if there's been any last minute changes of technology and/or URL. ;) [1] https://hangouts.google.com/hangouts/_/calendar/bWFyY3VzQGhpcnQuc2U.31a058aj5b7c3t57mlns7o13fb?hs=121 From marcus.hirt at oracle.com Thu Oct 11 17:26:00 2018 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Thu, 11 Oct 2018 19:26:00 +0200 Subject: JMC Roadmap Discussion In-Reply-To: <98E98BDC-DF92-4059-B87E-32D6DC965660@oracle.com> References: <391F1987-7CBA-41D1-8B4F-765E586B5F18@oracle.com> <98E98BDC-DF92-4059-B87E-32D6DC965660@oracle.com> Message-ID: <46BAD9B0-0B89-4EC8-AB43-93EEA5D7FF06@oracle.com> Thank you all for joining! That was a lot more people than I expected. :) Kind regards, Marcus ?On 2018-10-11, 13:10, "jmc-dev on behalf of Marcus Hirt" wrote: Hi all, This is a quick reminder regarding today's roadmap discussion. There are currently 12 participants. If you have not received an invite, please let me know! Kind regards, Marcus ?On 2018-10-03, 12:45, "jmc-dev on behalf of Marcus Hirt" wrote: Hi all, Now that JMC has been open sourced for a little while, I think it would be a good time to talk a little bit about what the future might hold. Since JDK Mission Control is an open source project, I firmly believe this to be something that we should discuss as a community. Therefore I hereby invite anyone who wants to join to a little roadmap discussion: Subject: JMC Roadmap Discussion Location: Google Hangout [1] Date: 2018-10-11 Time: 09:00-10:00 PDT 12:00-13:00 EDT 18:00-19:00 CET 21:30-22:30 IST 01:00-02:00 JST (2018-10-12) If you'd like to join, please send me an e-mail and I'll add you to the invite! Note: It's my first time arranging a video conference with Google Hangouts. Look to the IRC #jmc channel just before the meeting to check if there's been any last minute changes of technology and/or URL. ;) [1] https://hangouts.google.com/hangouts/_/calendar/bWFyY3VzQGhpcnQuc2U.31a058aj5b7c3t57mlns7o13fb?hs=121 From patrick at reini.net Sat Oct 13 16:48:27 2018 From: patrick at reini.net (Patrick Reinhart) Date: Sat, 13 Oct 2018 18:48:27 +0200 Subject: RFR: JMC-6115 Use Jemmy builds from Maven Central In-Reply-To: References: Message-ID: Hi Jie, For me the tests do not run here under Linux: mvn verify -P uitests [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] JDK Mission Control 7.0.0-SNAPSHOT ................. SUCCESS [? 2.095 s] [INFO] missioncontrol.application ......................... SUCCESS [? 0.059 s] [INFO] org.openjdk.jmc.ui.common .......................... SUCCESS [? 6.941 s] [INFO] org.openjdk.jmc.commands ........................... SUCCESS [? 4.492 s] [INFO] org.openjdk.jmc.ui ................................. SUCCESS [ 14.612 s] [INFO] org.openjdk.jmc.greychart .......................... SUCCESS [? 7.724 s] [INFO] org.openjdk.jmc.greychart.ui ....................... SUCCESS [? 6.848 s] [INFO] org.openjdk.jmc.rjmx ............................... SUCCESS [ 10.093 s] [INFO] org.openjdk.jmc.rjmx.ui ............................ SUCCESS [? 9.516 s] [INFO] org.openjdk.jmc.alert .............................. SUCCESS [? 5.107 s] [INFO] org.openjdk.jmc.attach ............................. SUCCESS [? 2.444 s] [INFO] org.openjdk.jmc.browser.attach ..................... FAILURE [? 4.726 s] Also the UI tests fail: mvn verify -P uitests [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] JDK Mission Control 7.0.0-SNAPSHOT ................. SUCCESS [? 1.867 s] [INFO] missioncontrol.application ......................... SUCCESS [? 0.061 s] [INFO] org.openjdk.jmc.ui.common .......................... SUCCESS [? 5.843 s] [INFO] org.openjdk.jmc.commands ........................... SUCCESS [? 4.192 s] [INFO] org.openjdk.jmc.ui ................................. SUCCESS [ 12.285 s] [INFO] org.openjdk.jmc.greychart .......................... SUCCESS [? 5.707 s] [INFO] org.openjdk.jmc.greychart.ui ....................... SUCCESS [? 6.156 s] [INFO] org.openjdk.jmc.rjmx ............................... SUCCESS [? 9.170 s] [INFO] org.openjdk.jmc.rjmx.ui ............................ SUCCESS [? 9.860 s] [INFO] org.openjdk.jmc.alert .............................. SUCCESS [? 4.523 s] [INFO] org.openjdk.jmc.attach ............................. SUCCESS [? 1.856 s] [INFO] org.openjdk.jmc.browser.attach ..................... FAILURE [? 3.777 s] -Patrick Am 10.10.18 um 19:29 schrieb Jie Kang: > On Mon, Oct 1, 2018 at 4:43 PM Jie Kang wrote: >> Hi all, >> >> Please find attached an alternative patch that addresses JMC-6115. It >> adds a step in the maven phase to download the Jemmy libraries from >> Maven Central. The pom file is also converted to all tabs. Let me know >> what you think! > Hi, > > Would anyone be able to look at the alternative patch I've proposed? > I've attached it again to this e-mail. > > > Regards, > >> >> Regards, From neugens at redhat.com Mon Oct 15 06:21:44 2018 From: neugens at redhat.com (Mario Torre) Date: Mon, 15 Oct 2018 08:21:44 +0200 Subject: RFR: JMC-6115 Use Jemmy builds from Maven Central In-Reply-To: References: Message-ID: On Sat, Oct 13, 2018 at 6:49 PM Patrick Reinhart wrote: > > Hi Jie, > > For me the tests do not run here under Linux: > > mvn verify -P uitests > [INFO] org.openjdk.jmc.browser.attach ..................... FAILURE [ > 3.777 s] I believe this is https://bugs.openjdk.java.net/browse/JMC-6118, are you testing with OpenJDK? We're working on a fix for this. Cheers, Mario -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From jkang at redhat.com Mon Oct 15 13:07:50 2018 From: jkang at redhat.com (Jie Kang) Date: Mon, 15 Oct 2018 09:07:50 -0400 Subject: RFR: JMC-6115 Use Jemmy builds from Maven Central In-Reply-To: References: Message-ID: On Sat, Oct 13, 2018 at 12:48 PM Patrick Reinhart wrote: > > Hi Jie, > > For me the tests do not run here under Linux: > > mvn verify -P uitests > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] JDK Mission Control 7.0.0-SNAPSHOT ................. SUCCESS [ > 2.095 s] > [INFO] missioncontrol.application ......................... SUCCESS [ > 0.059 s] > [INFO] org.openjdk.jmc.ui.common .......................... SUCCESS [ > 6.941 s] > [INFO] org.openjdk.jmc.commands ........................... SUCCESS [ > 4.492 s] > [INFO] org.openjdk.jmc.ui ................................. SUCCESS [ > 14.612 s] > [INFO] org.openjdk.jmc.greychart .......................... SUCCESS [ > 7.724 s] > [INFO] org.openjdk.jmc.greychart.ui ....................... SUCCESS [ > 6.848 s] > [INFO] org.openjdk.jmc.rjmx ............................... SUCCESS [ > 10.093 s] > [INFO] org.openjdk.jmc.rjmx.ui ............................ SUCCESS [ > 9.516 s] > [INFO] org.openjdk.jmc.alert .............................. SUCCESS [ > 5.107 s] > [INFO] org.openjdk.jmc.attach ............................. SUCCESS [ > 2.444 s] > [INFO] org.openjdk.jmc.browser.attach ..................... FAILURE [ > 4.726 s] > > Also the UI tests fail: > > mvn verify -P uitests The logs below has the same failure as the logs above; was this the intended paste? `org.openjdk.jmc.browser.attach` is under `application` module, is not a UI test and has no dependence on the Jemmy libraries as far as I can tell. The patch adds a new phase to the `org.openjdk.jmc.test.jemmy` module that downloads Jemmy libraries under the lib folder; assuming your logs are complete this module has not been reached and so I can't see how this failure is related. Can you share logs of the actual failure? Otherwise possibly retry with a clean run via 'mvn clean verify -P uitests'. Regards, > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] JDK Mission Control 7.0.0-SNAPSHOT ................. SUCCESS [ > 1.867 s] > [INFO] missioncontrol.application ......................... SUCCESS [ > 0.061 s] > [INFO] org.openjdk.jmc.ui.common .......................... SUCCESS [ > 5.843 s] > [INFO] org.openjdk.jmc.commands ........................... SUCCESS [ > 4.192 s] > [INFO] org.openjdk.jmc.ui ................................. SUCCESS [ > 12.285 s] > [INFO] org.openjdk.jmc.greychart .......................... SUCCESS [ > 5.707 s] > [INFO] org.openjdk.jmc.greychart.ui ....................... SUCCESS [ > 6.156 s] > [INFO] org.openjdk.jmc.rjmx ............................... SUCCESS [ > 9.170 s] > [INFO] org.openjdk.jmc.rjmx.ui ............................ SUCCESS [ > 9.860 s] > [INFO] org.openjdk.jmc.alert .............................. SUCCESS [ > 4.523 s] > [INFO] org.openjdk.jmc.attach ............................. SUCCESS [ > 1.856 s] > [INFO] org.openjdk.jmc.browser.attach ..................... FAILURE [ > 3.777 s] > > -Patrick > > > From guru.hb at oracle.com Mon Oct 15 13:55:47 2018 From: guru.hb at oracle.com (Guru) Date: Mon, 15 Oct 2018 19:25:47 +0530 Subject: JMC-6118: Java Mission Control tests fails on OpenJDK 8 In-Reply-To: References: <151DB053-0910-4B26-BA7D-FBEE50E24DC8@redhat.com> <5CA1715A-6F81-4A08-9966-85A9DF459E95@oracle.com> <0A3A3292-D4A5-4838-B576-690DA53EFFE3@redhat.com> <1B755453-D45B-4C02-83B0-06B0497718BE@oracle.com> Message-ID: <0A3095E4-1F8E-4700-87F1-AEDE4EA93B1C@oracle.com> Hi Salman, Changes look good to me. The failure which I have encountered is not related to your patch. Thanks, Guru > On 10-Oct-2018, at 10:23 PM, Salman Siddiqui wrote: > > Hi Guru, > > I tested the patch on an Ubuntu 18.04 VM and it works fine. > Can you please take another look and send me a more detailed log of the issue you experienced? > > Thanks, > Salman > > On Fri, Oct 5, 2018 at 3:48 PM Salman Siddiqui > wrote: > Hi Guru, > > Could you please send a log of the errors you encountered on Ubuntu? > > Thanks, > Salman > > On Mon, Oct 1, 2018 at 11:07 AM Marcus Hirt > wrote: > Hi Salman, > > Looks good to me! Guru, since you're the build maestro, > perhaps you can take a look too? > > Kind regards, > Marcus > > > From: Salman Siddiqui > > Date: Monday, 1 October 2018 at 16:29 > To: > > Subject: Re: JMC-6118: Java Mission Control tests fails on OpenJDK 8 > > Hi Marcus > > On Mon, Oct 1, 2018 at 10:57 AM Marcus Hirt > wrote: > Hi Salman, > I would be happy to! Where can I take a look at the patch? > > I sent it as an attachment to my previous email. It is also pasted below. > > > Kind regards, > Marcus > > > diff -r 896f9586d4c6 application/pom.xml > --- a/application/pom.xml Thu Sep 20 08:32:13 2018 -0700 > +++ b/application/pom.xml Fri Sep 28 12:13:40 2018 -0400 > @@ -110,6 +110,20 @@ > > > > + no-jfr > + > + > + http://java.runtime.name > + OpenJDK Runtime Environment > + > + (,11) > + > + > + org.openjdk.jmc.rjmx.test.services.CommercialFeaturesServiceTest,org.openjdk.jmc.flightrecorder.controlpanel.ui.model.test.EventConfigurationModelTest,org.openjdk.jmc.flightrecorder.controlpanel.ui.test.PropertyContentBuilderTest,org.openjdk.jmc.flightrecorder.controlpanel.ui.model.test.JfcAndServerSettingsCombinationTest,org.openjdk.jmc.rjmx.services.jfr.test.EventMetadataTest,org.openjdk.jmc.rjmx.services.jfr.test.EventTemplateTest,org.openjdk.jmc.rjmx.services.jfr.test.JfrControlTest,org.openjdk.jmc.rjmx.services.jfr.test.JfrPackageExampleTest,org.openjdk.jmc.rjmx.services.jfr.test.OnlineEventOptionsTest,org.openjdk.jmc.rjmx.services.jfr.test.RecordingOptionsTest > + > + > + > + > uitests > > uitests > @@ -119,6 +133,8 @@ > > 1.8 > 1.8 > + > + -XX:+UnlockCommercialFeatures -XX:+FlightRecorder > > > > diff -r 896f9586d4c6 application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/pom.xml > --- a/application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/pom.xml Thu Sep 20 08:32:13 2018 -0700 > +++ b/application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/pom.xml Fri Sep 28 12:13:40 2018 -0400 > @@ -47,7 +47,7 @@ > tycho-surefire-plugin > ${tycho-version} > > - -Dcom.sun.management.jmxremote.port=9999 -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false -Djava.rmi.server.hostname=localhost -Djmc.test.rjmx.serviceURL=service:jmx:rmi:///jndi/rmi://localhost:9999/jmxrmi -XX:+UnlockCommercialFeatures -XX:+FlightRecorder > + -Dcom.sun.management.jmxremote.port=9999 -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false -Djava.rmi.server.hostname=localhost -Djmc.test.rjmx.serviceURL=service:jmx:rmi:///jndi/rmi://localhost:9999/jmxrmi ${jfr.vmargs} > > > > diff -r 896f9586d4c6 application/tests/org.openjdk.jmc.rjmx.services.jfr.test/pom.xml > --- a/application/tests/org.openjdk.jmc.rjmx.services.jfr.test/pom.xml Thu Sep 20 08:32:13 2018 -0700 > +++ b/application/tests/org.openjdk.jmc.rjmx.services.jfr.test/pom.xml Fri Sep 28 12:13:40 2018 -0400 > @@ -47,8 +47,9 @@ > tycho-surefire-plugin > ${tycho-version} > > - -Dcom.sun.management.jmxremote.port=9999 -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false -Djava.rmi.server.hostname=localhost -Djmc.test.rjmx.serviceURL=service:jmx:rmi:///jndi/rmi://localhost:9999/jmxrmi -XX:+UnlockCommercialFeatures -XX:+FlightRecorder > - > + -Dcom.sun.management.jmxremote.port=9999 -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false -Djava.rmi.server.hostname=localhost -Djmc.test.rjmx.serviceURL=service:jmx:rmi:///jndi/rmi://localhost:9999/jmxrmi ${jfr.vmargs} > + false > + > > > > diff -r 896f9586d4c6 application/tests/pom.xml > --- a/application/tests/pom.xml Thu Sep 20 08:32:13 2018 -0700 > +++ b/application/tests/pom.xml Fri Sep 28 12:13:40 2018 -0400 > @@ -114,7 +114,10 @@ > > -nl en > ${test.includes} > - ${test.excludes} > + > + ${test.excludes} > + ${jfr.tests} > + > ${fail.if.no .tests} > > > diff -r 896f9586d4c6 pom.xml > --- a/pom.xml Thu Sep 20 08:32:13 2018 -0700 > +++ b/pom.xml Fri Sep 28 12:13:40 2018 -0400 > @@ -290,7 +290,7 @@ > > > > - [1.8.0-40,9.0.0) > + [1.8.0-40,) > Building JMC requires Java 8 version JDK 1.8.0_40 or later > > > diff -r 896f9586d4c6 releng/third-party/pom.xml > --- a/releng/third-party/pom.xml Thu Sep 20 08:32:13 2018 -0700 > +++ b/releng/third-party/pom.xml Fri Sep 28 12:13:40 2018 -0400 > @@ -108,7 +108,7 @@ > > > > - [1.8.0-40,9.0.0) > + [1.8.0-40,) > Building JMC requires Java 8 version JDK 1.8.0_40 or later > > > > > From patrick at reini.net Mon Oct 15 21:10:47 2018 From: patrick at reini.net (Patrick Reinhart) Date: Mon, 15 Oct 2018 23:10:47 +0200 Subject: RFR: JMC-6115 Use Jemmy builds from Maven Central In-Reply-To: References: Message-ID: <0d551284-2fa3-c94d-4001-572afca9ae22@reini.net> I used the Oracle JDK: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T20:33:14+02:00) Maven home: /opt/apache-maven-3.5.4 Java version: 1.8.0_181, vendor: Oracle Corporation, runtime: /usr/java/jdk1.8.0_181/jre Default locale: de_CH, platform encoding: UTF-8 OS name: "linux", version: "4.18.9-200.fc28.x86_64", arch: "amd64", family: "unix" -Patrick Am 15.10.18 um 08:21 schrieb Mario Torre: > On Sat, Oct 13, 2018 at 6:49 PM Patrick Reinhart wrote: >> Hi Jie, >> >> For me the tests do not run here under Linux: >> >> mvn verify -P uitests >> [INFO] org.openjdk.jmc.browser.attach ..................... FAILURE [ >> 3.777 s] > I believe this is https://bugs.openjdk.java.net/browse/JMC-6118, are > you testing with OpenJDK? > > We're working on a fix for this. > > Cheers, > Mario > From deepa.avhad at oracle.com Tue Oct 16 05:57:23 2018 From: deepa.avhad at oracle.com (Deepa Avhad) Date: Tue, 16 Oct 2018 11:27:23 +0530 Subject: Review request for JMC-5576: Alert dialog should use a sash. Message-ID: Hi all, Please review the fix for, Jira: https://bugs.openjdk.java.net/browse/JMC-5576 webrev: http://cr.openjdk.java.net/~ghb/davhad/5576/webrev.0/ RC :? "Trigger Alert" dialog, impossible to show all detail in table without scrolling. Solution: Added Sashform, which provides the sash between table and the text area. Test: Tested on Windows 10, MacOS? and yet to test on Linux. Thanks, Deepa From marcus.hirt at oracle.com Tue Oct 16 12:18:02 2018 From: marcus.hirt at oracle.com (marcus.hirt at oracle.com) Date: Tue, 16 Oct 2018 12:18:02 +0000 Subject: hg: jmc/jmc: JMC-5576: Adding sash to make it possible to read full Alert details Message-ID: <201810161218.w9GCI318022143@aojmv0008.oracle.com> Changeset: e9468a3e03af Author: hirt Date: 2018-10-16 14:17 +0200 URL: http://hg.openjdk.java.net/jmc/jmc/rev/e9468a3e03af JMC-5576: Adding sash to make it possible to read full Alert details Reviewed-by: hirt Contributed-by: Deepa Avhad ! application/org.openjdk.jmc.alert/src/main/java/org/openjdk/jmc/alert/AlertDialog.java From marcus.hirt at oracle.com Tue Oct 16 12:18:56 2018 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Tue, 16 Oct 2018 14:18:56 +0200 Subject: Review request for JMC-5576: Alert dialog should use a sash. In-Reply-To: <9D808C1B-284F-4F59-8314-0315B4D831C9@oracle.com> References: <9D808C1B-284F-4F59-8314-0315B4D831C9@oracle.com> Message-ID: <9C823629-4DD5-4C4E-8E9F-0A967A11D2F1@oracle.com> Looks good! Thank you for the contribution! Kind regards, Marcus ?On 2018-10-16, 07:57, "Deepa Avhad" wrote: Hi all, Please review the fix for, Jira: https://bugs.openjdk.java.net/browse/JMC-5576 webrev: http://cr.openjdk.java.net/~ghb/davhad/5576/webrev.0/ RC : "Trigger Alert" dialog, impossible to show all detail in table without scrolling. Solution: Added Sashform, which provides the sash between table and the text area. Test: Tested on Windows 10, MacOS and yet to test on Linux. Thanks, Deepa From neugens at redhat.com Tue Oct 16 16:18:57 2018 From: neugens at redhat.com (Mario Torre) Date: Tue, 16 Oct 2018 18:18:57 +0200 Subject: JMC-6118: Java Mission Control tests fails on OpenJDK 8 In-Reply-To: <0A3095E4-1F8E-4700-87F1-AEDE4EA93B1C@oracle.com> References: <151DB053-0910-4B26-BA7D-FBEE50E24DC8@redhat.com> <5CA1715A-6F81-4A08-9966-85A9DF459E95@oracle.com> <0A3A3292-D4A5-4838-B576-690DA53EFFE3@redhat.com> <1B755453-D45B-4C02-83B0-06B0497718BE@oracle.com> <0A3095E4-1F8E-4700-87F1-AEDE4EA93B1C@oracle.com> Message-ID: On Mon, 2018-10-15 at 19:25 +0530, Guru wrote: > Hi Salman, > > Changes look good to me. > > The failure which I have encountered is not related to your patch. > > Thanks, > Guru Great, thanks! Salman, can you please send me the approved patch as attachment, I'll push it for you. Cheers, Mario > > On 10-Oct-2018, at 10:23 PM, Salman Siddiqui > > wrote: > > > > Hi Guru, > > > > I tested the patch on an Ubuntu 18.04 VM and it works fine. > > Can you please take another look and send me a more detailed log of > > the issue you experienced? > > > > Thanks, > > Salman > > > > On Fri, Oct 5, 2018 at 3:48 PM Salman Siddiqui > > wrote: > > Hi Guru, > > > > Could you please send a log of the errors you encountered on > > Ubuntu? > > > > Thanks, > > Salman > > > > On Mon, Oct 1, 2018 at 11:07 AM Marcus Hirt > > wrote: > > Hi Salman, > > > > Looks good to me! Guru, since you're the build maestro, > > perhaps you can take a look too? > > > > Kind regards, > > Marcus > > > > > > From: Salman Siddiqui > sasiddiq at redhat.com>> > > Date: Monday, 1 October 2018 at 16:29 > > To: > > > Subject: Re: JMC-6118: Java Mission Control tests fails on OpenJDK > > 8 > > > > Hi Marcus > > > > On Mon, Oct 1, 2018 at 10:57 AM Marcus Hirt > marcus.hirt at oracle.com > wrote: > > Hi Salman, > > I would be happy to! Where can I take a look at the patch? > > > > I sent it as an attachment to my previous email. It is also pasted > > below. > > > > > > Kind regards, > > Marcus > > > > > > diff -r 896f9586d4c6 application/pom.xml > > --- a/application/pom.xml Thu Sep 20 08:32:13 2018 -0700 > > +++ b/application/pom.xml Fri Sep 28 12:13:40 2018 -0400 > > @@ -110,6 +110,20 @@ > > > > > > > > + no-jfr > > + > > + > > + http://java.runtime.name < > > http://java.runtime.name/> > > + OpenJDK Runtime Environment > > + > > + (,11) > > + > > + > > + org.openjdk.jmc.rjmx.test.services.Comm > > ercialFeaturesServiceTest,org.openjdk.jmc.flightrecorder.controlpan > > el.ui.model.test.EventConfigurationModelTest,org.openjdk.jmc.flight > > recorder.controlpanel.ui.test.PropertyContentBuilderTest,org.openjd > > k.jmc.flightrecorder.controlpanel.ui.model.test.JfcAndServerSetting > > sCombinationTest,org.openjdk.jmc.rjmx.services.jfr.test.EventMetada > > taTest,org.openjdk.jmc.rjmx.services.jfr.test.EventTemplateTest,org > > .openjdk.jmc.rjmx.services.jfr.test.JfrControlTest,org.openjdk.jmc. > > rjmx.services.jfr.test.JfrPackageExampleTest,org.openjdk.jmc.rjmx.s > > ervices.jfr.test.OnlineEventOptionsTest,org.openjdk.jmc.rjmx.servic > > es.jfr.test.RecordingOptionsTest > > + > > + > > + > > + > > uitests > > > > uitests > > @@ -119,6 +133,8 @@ > > > > 1.8 > > 1.8 > > + > > + -XX:+UnlockCommercialFeatures > > -XX:+FlightRecorder > > > > > > > > diff -r 896f9586d4c6 > > application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.te > > st/pom.xml > > --- > > a/application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui. > > test/pom.xml Thu Sep 20 08:32:13 2018 -0700 > > +++ > > b/application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui. > > test/pom.xml Fri Sep 28 12:13:40 2018 -0400 > > @@ -47,7 +47,7 @@ > > tycho-surefire-plugin > > ${tycho-version} > > > > - - > > Dcom.sun.management.jmxremote.port=9999 > > -Dcom.sun.management.jmxremote.authenticate=false > > -Dcom.sun.management.jmxremote.ssl=false > > -Djava.rmi.server.hostname=localhost > > -Djmc.test.rjmx.serviceURL=service:jmx:rmi:///jndi/rmi://localhost: > > 9999/jmxrmi -XX:+UnlockCommercialFeatures > > -XX:+FlightRecorder > > + - > > Dcom.sun.management.jmxremote.port=9999 > > -Dcom.sun.management.jmxremote.authenticate=false > > -Dcom.sun.management.jmxremote.ssl=false > > -Djava.rmi.server.hostname=localhost > > -Djmc.test.rjmx.serviceURL=service:jmx:rmi:///jndi/rmi://localhost: > > 9999/jmxrmi ${jfr.vmargs} > > > > > > > > diff -r 896f9586d4c6 > > application/tests/org.openjdk.jmc.rjmx.services.jfr.test/pom.xml > > --- > > a/application/tests/org.openjdk.jmc.rjmx.services.jfr.test/pom.xml > > Thu Sep 20 08:32:13 2018 -0700 > > +++ > > b/application/tests/org.openjdk.jmc.rjmx.services.jfr.test/pom.xml > > Fri Sep 28 12:13:40 2018 -0400 > > @@ -47,8 +47,9 @@ > > tycho-surefire-plugin > > ${tycho-version} > > > > - - > > Dcom.sun.management.jmxremote.port=9999 > > -Dcom.sun.management.jmxremote.authenticate=false > > -Dcom.sun.management.jmxremote.ssl=false > > -Djava.rmi.server.hostname=localhost > > -Djmc.test.rjmx.serviceURL=service:jmx:rmi:///jndi/rmi://localhost: > > 9999/jmxrmi -XX:+UnlockCommercialFeatures > > -XX:+FlightRecorder > > - > > + - > > Dcom.sun.management.jmxremote.port=9999 > > -Dcom.sun.management.jmxremote.authenticate=false > > -Dcom.sun.management.jmxremote.ssl=false > > -Djava.rmi.server.hostname=localhost > > -Djmc.test.rjmx.serviceURL=service:jmx:rmi:///jndi/rmi://localhost: > > 9999/jmxrmi ${jfr.vmargs} > > + false > > + > > > > > > > > diff -r 896f9586d4c6 application/tests/pom.xml > > --- a/application/tests/pom.xml Thu Sep 20 08:32:13 2018 -0700 > > +++ b/application/tests/pom.xml Fri Sep 28 12:13:40 2018 -0400 > > @@ -114,7 +114,10 @@ > > > > -nl en > > ${test.includes} > > - ${test.excludes} > > + > > + ${test.excludes} > > + ${jfr.tests} > > + > > ${fail.if.no < > > http://fail.if.no/>.tests} > > > > > > diff -r 896f9586d4c6 pom.xml > > --- a/pom.xml Thu Sep 20 08:32:13 2018 -0700 > > +++ b/pom.xml Fri Sep 28 12:13:40 2018 -0400 > > @@ -290,7 +290,7 @@ > > > > > > > > - [1.8.0- > > 40,9.0.0) > > + [1.8.0-40,) > > Building JMC requires > > Java 8 version JDK 1.8.0_40 or later > > > > > > diff -r 896f9586d4c6 releng/third-party/pom.xml > > --- a/releng/third-party/pom.xml Thu Sep 20 08:32:13 2018 -0700 > > +++ b/releng/third-party/pom.xml Fri Sep 28 12:13:40 2018 -0400 > > @@ -108,7 +108,7 @@ > > > > > > > > - [1.8.0- > > 40,9.0.0) > > + [1.8.0-40,) > > Building JMC requires > > Java 8 version JDK 1.8.0_40 or later > > > > > > > > > > > > -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From tejpal.rebari at oracle.com Tue Oct 16 17:12:33 2018 From: tejpal.rebari at oracle.com (Tejpal Rebari) Date: Tue, 16 Oct 2018 22:42:33 +0530 Subject: Review request for JMC-6151:[osx] opening .jfr file on mac fails for first time Message-ID: <117B1D9D-BE7A-49A2-83C5-3E53905B3B3F@oracle.com> Hi all, Please review the fix for, Jira: https://bugs.openjdk.java.net/browse/JMC-6151 webrev: http://cr.openjdk.java.net/~ghb/trebari/JMC-6151/webrev.0/ RC : (Mac OSX) FileDialog.setfilterIndex() doesn't work as expected Solution: For Mac OSX disabled the filters extension ,so the file dialog shows all the files that are there in the path.While for other OS it works same as before. Test: Tested on Windows 10, MacOS, Linux. Thanks, Tejpal From marcus.hirt at oracle.com Tue Oct 16 17:30:21 2018 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Tue, 16 Oct 2018 19:30:21 +0200 Subject: Review request for JMC-6151:[osx] opening .jfr file on mac fails for first time In-Reply-To: <5ECA9039-37DA-4427-ABEB-A96AF1DAC4C1@oracle.com> References: <5ECA9039-37DA-4427-ABEB-A96AF1DAC4C1@oracle.com> Message-ID: <136485D8-F1B0-4AC5-9F4D-92A3BC4C0D4F@oracle.com> Looks fine, but let?s see if we can get the Eclipse fix earlier than 4.10. Also, perhaps you could add some text to the comment, e.g.: // FIXME: Workaround for Eclipse bug 540164. See JMC-6171. Would you like me to push it for you? Kind regards, Marcus From: Tejpal Rebari Date: Tuesday, 16 October 2018 at 19:12 To: Marcus Hirt Cc: Subject: Review request for JMC-6151:[osx] opening .jfr file on mac fails for first time Hi all, Please review the fix for, Jira:?https://bugs.openjdk.java.net/browse/JMC-5576 webrev:?http://cr.openjdk.java.net/~ghb/trebari/JMC-6151/webrev.0/ RC : (Mac OSX) FileDialog.setfilterIndex() doesn't work as expected Solution: For Mac OSX disabled the filters extension ,so the file dialog shows all the files that are there in the path.While for other OS it works same as before. Test: Tested on Windows 10, MacOS, Linux. Thanks, Tejpal From guru.hb at oracle.com Tue Oct 16 17:35:28 2018 From: guru.hb at oracle.com (Guru) Date: Tue, 16 Oct 2018 23:05:28 +0530 Subject: Review request for JMC-6151:[osx] opening .jfr file on mac fails for first time In-Reply-To: <117B1D9D-BE7A-49A2-83C5-3E53905B3B3F@oracle.com> References: <117B1D9D-BE7A-49A2-83C5-3E53905B3B3F@oracle.com> Message-ID: <91993DE7-5DD7-4D00-BA72-8F845C4B2315@oracle.com> +1 looks good to me. Note : This might break UI test on Mac, Do UI test and file a bug in Jira. Thanks, Guru > On 16-Oct-2018, at 10:42 PM, Tejpal Rebari wrote: > > Hi all, > > Please review the fix for, > Jira: https://bugs.openjdk.java.net/browse/JMC-6151 > webrev: http://cr.openjdk.java.net/~ghb/trebari/JMC-6151/webrev.0/ > RC : (Mac OSX) FileDialog.setfilterIndex() doesn't work as expected > Solution: For Mac OSX disabled the filters extension ,so the file dialog shows all the files that are there in the path.While for other OS it works same as before. > Test: Tested on Windows 10, MacOS, Linux. > > Thanks, > Tejpal From tejpal.rebari at oracle.com Tue Oct 16 18:09:31 2018 From: tejpal.rebari at oracle.com (Tejpal Rebari) Date: Tue, 16 Oct 2018 23:39:31 +0530 Subject: Review request for JMC-6151:[osx] opening .jfr file on mac fails for first time In-Reply-To: <04ABC4ED-E28C-4ECB-BA11-F3486D68B3A3@oracle.com> References: <5ECA9039-37DA-4427-ABEB-A96AF1DAC4C1@oracle.com> <136485D8-F1B0-4AC5-9F4D-92A3BC4C0D4F@oracle.com> <04ABC4ED-E28C-4ECB-BA11-F3486D68B3A3@oracle.com> Message-ID: Hi Marcus, Made the changes according to your instruction, diff -r 2177c12e7894 application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/actions/OpenFileAction.java --- a/application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/actions/OpenFileAction.java Wed Oct 10 15:18:48 2018 +0200 +++ b/application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/actions/OpenFileAction.java Tue Oct 16 23:30:54 2018 +0530 @@ -47,6 +47,7 @@ import org.openjdk.jmc.rcp.application.ApplicationPlugin; import org.openjdk.jmc.ui.MCPathEditorInput; import org.openjdk.jmc.ui.WorkbenchToolkit; +import org.openjdk.jmc.ui.common.util.Environment; /** * Class for opening a file @@ -140,7 +141,10 @@ public static void openFile(IWorkbenchWindow inWindow) { FileDialog dialog = new FileDialog(inWindow.getShell(), SWT.OPEN | SWT.MULTI); dialog.setFilterPath(getDefaultFilterPath()); - setFilterNamesAndExtensions(dialog); + // FIXME: Workaround for Eclipse bug 540164. See JMC-6171. + if (Environment.getOSType() != Environment.OSType.MAC) { + setFilterNamesAndExtensions(dialog); + } dialog.setText(Messages.OpenFileAction_OPEN_FILE_TITLE); if (dialog.open() == null) { Thanks and Regards Tejpal > On 16-Oct-2018, at 11:25 PM, Tejpal Rebari wrote: > > Yes,please push it for me. > > Thanks and regards > Tejpal > >> On 16-Oct-2018, at 11:00 PM, Marcus Hirt wrote: >> >> Looks fine, but let?s see if we can get the Eclipse fix earlier than 4.10. >> Also, perhaps you could add some text to the comment, e.g.: >> >> // FIXME: Workaround for Eclipse bug 540164. See JMC-6171. >> >> Would you like me to push it for you? >> >> Kind regards, >> Marcus >> >> From: Tejpal Rebari >> Date: Tuesday, 16 October 2018 at 19:12 >> To: Marcus Hirt >> Cc: >> Subject: Review request for JMC-6151:[osx] opening .jfr file on mac fails for first time >> >> Hi all, >> >> Please review the fix for, >> Jira: https://bugs.openjdk.java.net/browse/JMC-5576 >> webrev: http://cr.openjdk.java.net/~ghb/trebari/JMC-6151/webrev.0/ >> RC : (Mac OSX) FileDialog.setfilterIndex() doesn't work as expected >> Solution: For Mac OSX disabled the filters extension ,so the file dialog shows all the files that are there in the path.While for other OS it works same as before. >> Test: Tested on Windows 10, MacOS, Linux. >> >> Thanks, >> Tejpal >> >> > From marcus.hirt at oracle.com Tue Oct 16 19:58:51 2018 From: marcus.hirt at oracle.com (marcus.hirt at oracle.com) Date: Tue, 16 Oct 2018 19:58:51 +0000 Subject: hg: jmc/jmc: JMC-6151: Workaround for the file dialog filter bug on Mac OS X Message-ID: <201810161958.w9GJwpgt020151@aojmv0008.oracle.com> Changeset: faf2abb509ad Author: hirt Date: 2018-10-16 21:58 +0200 URL: http://hg.openjdk.java.net/jmc/jmc/rev/faf2abb509ad JMC-6151: Workaround for the file dialog filter bug on Mac OS X Reviewed-by: hirt, ghb Contributed-by: Tejpal Rebari ! application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/actions/OpenFileAction.java From neugens.limasoftware at gmail.com Wed Oct 17 11:10:15 2018 From: neugens.limasoftware at gmail.com (neugens.limasoftware at gmail.com) Date: Wed, 17 Oct 2018 11:10:15 +0000 Subject: hg: jmc/jmc: JMC-6118: Java Mission Control tests fails on OpenJDK 8 Message-ID: <201810171110.w9HBAFqn004434@aojmv0008.oracle.com> Changeset: ecb68ef82eb7 Author: neugens Date: 2018-10-17 13:09 +0200 URL: http://hg.openjdk.java.net/jmc/jmc/rev/ecb68ef82eb7 JMC-6118: Java Mission Control tests fails on OpenJDK 8 Summary: Add profile that skips some tests when running on OpenJDK versions without JFR Reviewed-by: hirt, ghb Contributed-by: Salman Siddiqui ! application/pom.xml ! application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/pom.xml ! application/tests/org.openjdk.jmc.rjmx.services.jfr.test/pom.xml ! application/tests/pom.xml ! pom.xml ! releng/third-party/pom.xml From Gary.Morrison at arm.com Wed Oct 17 17:25:54 2018 From: Gary.Morrison at arm.com (Gary Morrison) Date: Wed, 17 Oct 2018 17:25:54 +0000 Subject: Oracle Java Mission Control vs. JDK Mission Control Differences Message-ID: First, a prefacing comment and question: Please bear with me in my verbal descriptions; it would be easier if I could post a picture. Am I allowed to post here in HTML, including inline screenshots? I'm currently working with the JMC binary release at http://jdk.java.net/jmc, with OpenJDK 10, and I've noticed a number of ... odd ... differences between that and what I see in various tutorials, for example: * When I open the MBean Server for a current, indefinitely-running JVM, it pops up (in the Overview tab) a default set of "Dashboard" and graphs for "Processor" and "Memory." The upper-right-corner controls on each of those items contains a green "+" to "Add attributes," an icon of two tan arrows chasing each other to "Enable updates," and a "wheel-chair" icon for "Accessibility mode." The tutorials show a rather important small icon to the right of it that I **do not see**: An "X" icon to close that graph or Dashboard. I haven't found any way to close these graphs after they come up! * When I File:Open a .jfr file, I see it pop up a set of ... I'm honestly not sure what they are, but they are two columns of grey horizonal lines with a green rectangle on the left containing a number, and a topic name to the right of that rectangle. These are classified in these major categories (with subcategories): Java Application, Environment, JVM Internals, and Event Browser. Not obvious what those things are or what to do with them. In contrast, in the tutorials (e.g., https://www.youtube.com/watch?v=1mIPWyHl5xw&t=191s, time 4:31) it pops up a gloriously useful pane called "Overview," with dials showing "Heap Usage," "Total CPU Usage," and "GC Pause Time, along with a graph of CPU usage below that, along with icons along the left side for "General," "Memory," "Code," "Threads," etc. Questions: * Is this difference an Oracle JMC vs. OpenJDK JMC difference? * What can I do with these grey-bar thingies in the .jfr file picture? Again, thanks for bearing with my verbal descriptions of graphical images! IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. From Gary.Morrison at arm.com Wed Oct 17 17:57:55 2018 From: Gary.Morrison at arm.com (Gary Morrison) Date: Wed, 17 Oct 2018 17:57:55 +0000 Subject: Oracle Java Mission Control vs. JDK Mission Control Differences In-Reply-To: References: Message-ID: Oh, duh! It just occurred to me that my description of what I get when I open a .jfr file might be a lot clearer if I add that that pane is entitled "Automated Analysis Results." The green numbers I mentioned initially came up as "cylon eyes" scanning back and forth, presumably while it calculates those numbers. The tutorial, in contrast, popped up a very-different pane entitled "Overview." ----------------------------------------------------------------------------------- From: Gary Morrison ... * When I File:Open a .jfr file, I see it pop up a set of ... I'm honestly not sure what they are, but they are two columns of grey horizonal lines with a green rectangle on the left containing a number, and a topic name to the right of that rectangle. ... IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. From marcus.hirt at oracle.com Fri Oct 19 11:17:04 2018 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Fri, 19 Oct 2018 13:17:04 +0200 Subject: Oracle Java Mission Control vs. JDK Mission Control Differences In-Reply-To: References: Message-ID: <139368A9-2413-43EB-9E3F-9A2F085121C8@oracle.com> Hi Gary, There is a new tutorial in the works for JMC 7. It will be used in the HoL at Code One next week. It will be released within the next few months. Gotta say I love "cylon eyes" - that will probably be the technical term from on. ;) Kind regards, Marcus ?On 2018-10-17, 19:58, "jmc-dev on behalf of Gary Morrison" wrote: Oh, duh! It just occurred to me that my description of what I get when I open a .jfr file might be a lot clearer if I add that that pane is entitled "Automated Analysis Results." The green numbers I mentioned initially came up as "cylon eyes" scanning back and forth, presumably while it calculates those numbers. The tutorial, in contrast, popped up a very-different pane entitled "Overview." ----------------------------------------------------------------------------------- From: Gary Morrison ... * When I File:Open a .jfr file, I see it pop up a set of ... I'm honestly not sure what they are, but they are two columns of grey horizonal lines with a green rectangle on the left containing a number, and a topic name to the right of that rectangle. ... IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. From Gary.Morrison at arm.com Fri Oct 19 18:24:34 2018 From: Gary.Morrison at arm.com (Gary Morrison) Date: Fri, 19 Oct 2018 18:24:34 +0000 Subject: Oracle Java Mission Control vs. JDK Mission Control Differences In-Reply-To: <139368A9-2413-43EB-9E3F-9A2F085121C8@oracle.com> References: <139368A9-2413-43EB-9E3F-9A2F085121C8@oracle.com> Message-ID: Thanks for replying, Marcus! I'm pretty new to the OpenJDK open-source world (coming for a very different background of uP-core simulation and random-testing), so I'm glad I'm "upstreaming" something, albeit just ?Cylon eyes?! ?? I was about to ask you (only, so that I could HTML-mail some pictures rather than stumbling to describe what I see in words) about this "Automated Analysis Results" window (pane). However, I googled it again, and this time I did find a reference that might explain what it's all about. So I'll read that and a couple others before I pester you. -----Original Message----- From: Marcus Hirt Sent: Friday, October 19, 2018 6:17 AM To: Gary Morrison ; jmc-dev at openjdk.java.net Subject: Re: Oracle Java Mission Control vs. JDK Mission Control Differences Hi Gary, There is a new tutorial in the works for JMC 7. It will be used in the HoL at Code One next week. It will be released within the next few months. Gotta say I love "cylon eyes" - that will probably be the technical term from on. ;) Kind regards, Marcus ?On 2018-10-17, 19:58, "jmc-dev on behalf of Gary Morrison" wrote: Oh, duh! It just occurred to me that my description of what I get when I open a .jfr file might be a lot clearer if I add that that pane is entitled "Automated Analysis Results." The green numbers I mentioned initially came up as "cylon eyes" scanning back and forth, presumably while it calculates those numbers. The tutorial, in contrast, popped up a very-different pane entitled "Overview." ----------------------------------------------------------------------------------- From: Gary Morrison ... * When I File:Open a .jfr file, I see it pop up a set of ... I'm honestly not sure what they are, but they are two columns of grey horizonal lines with a green rectangle on the left containing a number, and a topic name to the right of that rectangle. ... IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. From marcus.hirt at oracle.com Fri Oct 19 19:16:11 2018 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Fri, 19 Oct 2018 21:16:11 +0200 Subject: Oracle Java Mission Control vs. JDK Mission Control Differences In-Reply-To: References: <139368A9-2413-43EB-9E3F-9A2F085121C8@oracle.com> Message-ID: Hi Gary, If you wish we could have a quick talk over Zoom or Skype? I?m currently traveling, but will be in CA with nothing much to do during the weekend after Code One (27th & 28th). Kind regards, Marcus - Excuse me if terse; sent from my phone. > On 19 Oct 2018, at 20:24, Gary Morrison wrote: > > Thanks for replying, Marcus! > > I'm pretty new to the OpenJDK open-source world (coming for a very different background of uP-core simulation and random-testing), so I'm glad I'm "upstreaming" something, albeit just ?Cylon eyes?! ?? > > I was about to ask you (only, so that I could HTML-mail some pictures rather than stumbling to describe what I see in words) about this "Automated Analysis Results" window (pane). However, I googled it again, and this time I did find a reference that might explain what it's all about. So I'll read that and a couple others before I pester you. > > -----Original Message----- > From: Marcus Hirt > Sent: Friday, October 19, 2018 6:17 AM > To: Gary Morrison ; jmc-dev at openjdk.java.net > Subject: Re: Oracle Java Mission Control vs. JDK Mission Control Differences > > Hi Gary, > > There is a new tutorial in the works for JMC 7. It will be used in the HoL at Code One next week. It will be released within the next few months. > > Gotta say I love "cylon eyes" - that will probably be the technical term from on. ;) > > Kind regards, > Marcus > > ?On 2018-10-17, 19:58, "jmc-dev on behalf of Gary Morrison" wrote: > > Oh, duh! It just occurred to me that my description of what I get when I open a .jfr file might be a lot clearer if I add that that pane is entitled "Automated Analysis Results." The green numbers I mentioned initially came up as "cylon eyes" scanning back and forth, presumably while it calculates those numbers. The tutorial, in contrast, popped up a very-different pane entitled "Overview." > ----------------------------------------------------------------------------------- > From: Gary Morrison > ... > * When I File:Open a .jfr file, I see it pop up a set of ... I'm honestly not sure what they are, but they are two columns of grey horizonal lines with a green rectangle on the left containing a number, and a topic name to the right of that rectangle. ... > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. From marcus.hirt at oracle.com Sun Oct 21 05:17:39 2018 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Sat, 20 Oct 2018 22:17:39 -0700 Subject: Subject: Review request for JMC-6174: Documenting how to use ide update site Message-ID: <14412C75-F47B-4AB3-8577-408A4D64831C@oracle.com> Hi all, Please review this fix to document how to use the ide update site: Jira: https://bugs.openjdk.java.net/browse/JMC-6174 diff -r ecb68ef82eb7 README.md --- a/README.md Wed Oct 17 13:09:45 2018 +0200 +++ b/README.md Sat Oct 20 22:16:46 2018 -0700 @@ -293,7 +293,28 @@ And here is an example for Windows x64: ```bash -missioncontrol\target\products\org.openjdk.jmc\win32\win32\x86_64\jmc.exe -vm %JAVA_HOME%\bin +target\products\org.openjdk.jmc\win32\win32\x86_64\jmc.exe -vm %JAVA_HOME%\bin +``` + +## Using the Built JMC Update Site in Eclipse +As part of the JMC build, the JMC update sites will be built. + +There is one update site for the stand-alone RCP application, providing plug-ins for the stand-alone release of JMC: + +```bash +application/org.openjdk.jmc.updatesite.rcp/target/ +``` + +There is another update site for the Eclipse plug-ins, providing plug-ins for running JMC inside of Eclipse: + +```bash +application/org.openjdk.jmc.updatesite.ide/target/ +``` + +To install it into Eclipe, simply open Eclipse and select Help | Install New Software... In the dialog, click Add... and then click the Archive... button. Select the built update site, e.g. + +```bash +application/org.openjdk.jmc.updatesite.ide/target/org.openjdk.jmc.updatesite.ide-7.0.0-SNAPSHOT.zip ``` ## Setting Up for Development and Launching in Eclipse --- Kind regards, Marcus From miro.wengner at gmail.com Sun Oct 21 20:47:34 2018 From: miro.wengner at gmail.com (Miro Wengner) Date: Sun, 21 Oct 2018 13:47:34 -0700 Subject: Subject: Review request for JMC-6174: Documenting how to use ide update site In-Reply-To: <14412C75-F47B-4AB3-8577-408A4D64831C@oracle.com> References: <14412C75-F47B-4AB3-8577-408A4D64831C@oracle.com> Message-ID: <7E030A35-F92C-46D7-879E-13CAFB33823C@gmail.com> Hi Marcus, it looks fine to me, Kind Regards, Miro > On Oct 20, 2018, at 10:17 PM, Marcus Hirt wrote: > > Hi all, > > Please review this fix to document how to use the ide update site: > > Jira: https://bugs.openjdk.java.net/browse/JMC-6174 > > diff -r ecb68ef82eb7 README.md > --- a/README.md Wed Oct 17 13:09:45 2018 +0200 > +++ b/README.md Sat Oct 20 22:16:46 2018 -0700 > @@ -293,7 +293,28 @@ > And here is an example for Windows x64: > > ```bash > -missioncontrol\target\products\org.openjdk.jmc\win32\win32\x86_64\jmc.exe -vm %JAVA_HOME%\bin > +target\products\org.openjdk.jmc\win32\win32\x86_64\jmc.exe -vm %JAVA_HOME%\bin > +``` > + > +## Using the Built JMC Update Site in Eclipse > +As part of the JMC build, the JMC update sites will be built. > + > +There is one update site for the stand-alone RCP application, providing plug-ins for the stand-alone release of JMC: > + > +```bash > +application/org.openjdk.jmc.updatesite.rcp/target/ > +``` > + > +There is another update site for the Eclipse plug-ins, providing plug-ins for running JMC inside of Eclipse: > + > +```bash > +application/org.openjdk.jmc.updatesite.ide/target/ > +``` > + > +To install it into Eclipe, simply open Eclipse and select Help | Install New Software... In the dialog, click Add... and then click the Archive... button. Select the built update site, e.g. > + > +```bash > +application/org.openjdk.jmc.updatesite.ide/target/org.openjdk.jmc.updatesite.ide-7.0.0-SNAPSHOT.zip > ``` > > ## Setting Up for Development and Launching in Eclipse > --- > > Kind regards, > Marcus > > From marcus.hirt at oracle.com Sun Oct 21 20:50:23 2018 From: marcus.hirt at oracle.com (marcus.hirt at oracle.com) Date: Sun, 21 Oct 2018 20:50:23 +0000 Subject: hg: jmc/jmc: JMC-6174: Document how to use ide update site Message-ID: <201810212050.w9LKoOab008638@aojmv0008.oracle.com> Changeset: bd0c0065130b Author: hirt Date: 2018-10-21 13:50 -0700 URL: http://hg.openjdk.java.net/jmc/jmc/rev/bd0c0065130b JMC-6174: Document how to use ide update site Reviewed-by: mwengner ! README.md From Gary.Morrison at arm.com Mon Oct 22 22:37:09 2018 From: Gary.Morrison at arm.com (Gary Morrison) Date: Mon, 22 Oct 2018 22:37:09 +0000 Subject: JMC Version Differences? Message-ID: I'm currently using this version of JMC (with OpenJDK10): http://jdk.java.net/jmc I'm debating why, when I open a .jfr file, I do not see what I see in https://www.youtube.com/watch?v=1mIPWyHl5xw&t=191s at time 4:31. In particular, in the video, along the left edge of the Overview pane (not sure I'm seeing an Overview pane anywhere for that matter), there's an icon bar with icons General, Memory, Code, Threads, I/O, System, and Events. I *think* this Memory icon is mentioned also in https://blog.takipi.com/oracle-java-mission-control-the-ultimate-guide, section 4.2, showing a pane that comes up from hitting that icon (?). What I instead see is an "Outline" tab on the left-side pane, under the menu, which includes various things I can choose to view. One of those is Memory, but when I click on that, it looks nothing like what I see in https://blog.takipi.com/oracle-java-mission-control-the-ultimate-guide. Am I seeing something different because I'm using the OpenJDK JMC, whereas these URLs above use the Oracle JMC, or perhaps just different JMC version, or...? IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. From Gary.Morrison at arm.com Mon Oct 22 23:06:14 2018 From: Gary.Morrison at arm.com (Gary Morrison) Date: Mon, 22 Oct 2018 23:06:14 +0000 Subject: JMC Version Differences? In-Reply-To: References: Message-ID: Oh, sorry: Scratch what I was suggesting below about the Memory tab in https://blog.takipi.com/oracle-java-mission-control-the-ultimate-guide; that's not from looking at a .jfr file, it's looking at on-going MBean activity. Nevertheless, I'm wondering if any of you know why I'm not seeing that icon bar I described, from that YouTube video. -----Original Message----- From: Gary Morrison ... I *think* this Memory icon is mentioned also in https://blog.takipi.com/oracle-java-mission-control-the-ultimate-guide, section 4.2, showing a pane that comes up from hitting that icon (?). IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. From klara.ward at oracle.com Tue Oct 23 05:26:13 2018 From: klara.ward at oracle.com (Klara Ward) Date: Tue, 23 Oct 2018 07:26:13 +0200 Subject: JMC Version Differences? In-Reply-To: References: Message-ID: <561A5351-E1B3-49A7-A4BF-870ED11B1411@oracle.com> The JMC UI for JFR was rewritten for JMC 6, the open source version is 7, and the version Takipi used was 5. The same data is shown but in different ways. I can?t recall someone ever writing a guide for how the two UIs compare, but this tutorial by Marcus Hirt is probably useful - http://hirt.se/blog/?p=939 // Klara > 23 okt. 2018 kl. 00:37 skrev Gary Morrison : > > I'm currently using this version of JMC (with OpenJDK10): > > http://jdk.java.net/jmc > > I'm debating why, when I open a .jfr file, I do not see what I see in https://www.youtube.com/watch?v=1mIPWyHl5xw&t=191s at time 4:31. In particular, in the video, along the left edge of the Overview pane (not sure I'm seeing an Overview pane anywhere for that matter), there's an icon bar with icons General, Memory, Code, Threads, I/O, System, and Events. I *think* this Memory icon is mentioned also in https://blog.takipi.com/oracle-java-mission-control-the-ultimate-guide, section 4.2, showing a pane that comes up from hitting that icon (?). > > What I instead see is an "Outline" tab on the left-side pane, under the menu, which includes various things I can choose to view. One of those is Memory, but when I click on that, it looks nothing like what I see in https://blog.takipi.com/oracle-java-mission-control-the-ultimate-guide. > > Am I seeing something different because I'm using the OpenJDK JMC, whereas these URLs above use the Oracle JMC, or perhaps just different JMC version, or...? > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. From Gary.Morrison at arm.com Tue Oct 23 11:17:19 2018 From: Gary.Morrison at arm.com (Gary Morrison) Date: Tue, 23 Oct 2018 11:17:19 +0000 Subject: JMC Version Differences? In-Reply-To: <561A5351-E1B3-49A7-A4BF-870ED11B1411@oracle.com> References: , <561A5351-E1B3-49A7-A4BF-870ED11B1411@oracle.com> Message-ID: Superb! Thanks for the clarification, Klara. I?ll check out that tutorial, and search for information specifically on version 7 (or later). Get Outlook for iOS ________________________________ From: Klara Ward Sent: Tuesday, October 23, 2018 12:26 AM To: Gary Morrison Cc: jmc-dev at openjdk.java.net Subject: Re: JMC Version Differences? The JMC UI for JFR was rewritten for JMC 6, the open source version is 7, and the version Takipi used was 5. The same data is shown but in different ways. I can?t recall someone ever writing a guide for how the two UIs compare, but this tutorial by Marcus Hirt is probably useful - http://hirt.se/blog/?p=939 // Klara 23 okt. 2018 kl. 00:37 skrev Gary Morrison >: I'm currently using this version of JMC (with OpenJDK10): http://jdk.java.net/jmc I'm debating why, when I open a .jfr file, I do not see what I see in https://www.youtube.com/watch?v=1mIPWyHl5xw&t=191s at time 4:31. In particular, in the video, along the left edge of the Overview pane (not sure I'm seeing an Overview pane anywhere for that matter), there's an icon bar with icons General, Memory, Code, Threads, I/O, System, and Events. I *think* this Memory icon is mentioned also in https://blog.takipi.com/oracle-java-mission-control-the-ultimate-guide, section 4.2, showing a pane that comes up from hitting that icon (?). What I instead see is an "Outline" tab on the left-side pane, under the menu, which includes various things I can choose to view. One of those is Memory, but when I click on that, it looks nothing like what I see in https://blog.takipi.com/oracle-java-mission-control-the-ultimate-guide. Am I seeing something different because I'm using the OpenJDK JMC, whereas these URLs above use the Oracle JMC, or perhaps just different JMC version, or...? IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. From Gary.Morrison at arm.com Tue Oct 23 20:54:21 2018 From: Gary.Morrison at arm.com (Gary Morrison) Date: Tue, 23 Oct 2018 20:54:21 +0000 Subject: "Please consider reporting this to the maintainers of org.eclipse.osgi.storage.FrameworkExtensionInstaller" Message-ID: (I think I asked about this before, but I lost some Email archives a couple weeks ago, so maybe somebody replied and I no longer have a record of it. If so, apologies in advance.) ------------------------------------------------------------------ In performing the "mvn p2:site" command from Marcus' blog, http://hirt.se/blog/?p=947, I get "consider reporting this to the maintainers of org.eclipse.osgi.storage.FrameworkExtensionInstaller" as shown below. I googled around for an hour or so, and the closest thing I could find was somebody getting a trying to run Eclipse, which was resolved to a Java version issue, but best I can tell from the pom.xml, that shouldn't be an issue (using OpenJDK 10). Any ideas? Thanks, everybody! ------------------------------------------------------------------ ... [INFO] Command line: [/home/ubuntu/jdk10/build/linux-aarch64-normal-server-fastdebug/jdk/bin/java, -jar, /home/ubuntu/.m2/repository/org/eclipse/tycho/tycho-bundles-external/0.23.1/eclipse/plugins/org.eclipse.equinox.launcher_1.3.100.v20150511-1540.jar, -configuration, /tmp/tycho-p2-runtime9306636892630440993.tmp/configuration, -debug, -consoleLog, -console, -nosplash, -application, org.eclipse.equinox.p2.publisher.FeaturesAndBundlesPublisher, -artifactRepository, file:/home/ubuntu/jmc/releng/third-party/target/repository, -metadataRepository, file:/home/ubuntu/jmc/releng/third-party/target/repository, -publishArtifacts, -compress, -nouses, -source, /home/ubuntu/jmc/releng/third-party/target/source] Configuration location: file:/tmp/tycho-p2-runtime9306636892630440993.tmp/configuration/ Configuration file: file:/tmp/tycho-p2-runtime9306636892630440993.tmp/configuration/config.ini loaded Install location: file:/tmp/tycho-p2-runtime9306636892630440993.tmp/ Framework located: file:/home/ubuntu/.m2/repository/org/eclipse/tycho/tycho-bundles-external/0.23.1/eclipse/plugins/org.eclipse.osgi_3.10.100.v20150529-1857.jar Framework classpath: file:/home/ubuntu/.m2/repository/org/eclipse/tycho/tycho-bundles-external/0.23.1/eclipse/plugins/org.eclipse.osgi_3.10.100.v20150529-1857.jar Debug options: file:/home/ubuntu/jmc/releng/third-party/.options not found WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.eclipse.osgi.storage.FrameworkExtensionInstaller (file:/home/ubuntu/.m2/repository/org/eclipse/tycho/tycho-bundles-external/0.23.1/eclipse/plugins/org.eclipse.osgi_3.10.100.v20150529-1857.jar) to method java.net.URLClassLoader.addURL(java.net.URL) WARNING: Please consider reporting this to the maintainers of org.eclipse.osgi.storage.FrameworkExtensionInstaller WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release Time to load bundles: 678 ... IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. From Gary.Morrison at arm.com Tue Oct 23 21:23:01 2018 From: Gary.Morrison at arm.com (Gary Morrison) Date: Tue, 23 Oct 2018 21:23:01 +0000 Subject: "Please consider reporting this to the maintainers of org.eclipse.osgi.storage.FrameworkExtensionInstaller" In-Reply-To: References: Message-ID: Ya know, the more I look at it, the more I'm thinking maybe that's not the root problem after all. The way it ultimately fails is (turning on -e and -X): ------------------------------------------------------------ ... !ENTRY org.eclipse.core.runtime 2 0 2018-10-23 16:15:18.813 !MESSAGE Could not resolve module: org.eclipse.core.runtime [46] Unresolved requirement: Require-Bundle: javax.annotation; bundle-version="1.1.0"; visibility:="reexport"; resolution:="optional" Unresolved requirement: Require-Bundle: javax.inject; bundle-version="1.0.0"; visibility:="reexport"; resolution:="optional" Unresolved requirement: Require-Bundle: org.eclipse.core.jobs; bundle-version="[3.2.0,4.0.0)"; visibility:="reexport" -> Bundle-SymbolicName: org.eclipse.core.jobs; bundle-version="3.7.0.v20150330-2103"; singleton:="true" org.eclipse.core.jobs [45] Unresolved requirement: Require-Capability: osgi.ee; filter:="(&(osgi.ee=JavaSE)(version=1.7))" !ENTRY org.eclipse.core.net 2 0 2018-10-23 16:15:18.814 !MESSAGE Could not resolve module: org.eclipse.core.net [31] Unresolved requirement: Require-Bundle: org.eclipse.equinox.security; bundle-version="[1.0.0,2.0.0)" -> Bundle-SymbolicName: org.eclipse.equinox.security; bundle-version="1.2.100.v20150423-1356"; singleton:="true" org.eclipse.equinox.security [2] Unresolved requirement: Import-Package: org.eclipse.core.runtime.jobs -> Export-Package: org.eclipse.core.runtime.jobs; bundle-symbolic-name="org.eclipse.core.jobs"; bundle-version="3.7.0.v20150330-2103"; version="0.0.0" org.eclipse.core.jobs [45] Unresolved requirement: Require-Capability: osgi.ee; filter:="(&(osgi.ee=JavaSE)(version=1.7))" !ENTRY org.eclipse.ecf.provider.filetransfer.httpclient4 2 0 2018-10-23 16:15:18.815 !MESSAGE Could not resolve module: org.eclipse.ecf.provider.filetransfer.httpclient4 [39] Unresolved requirement: Import-Package: org.eclipse.core.runtime.jobs -> Export-Package: org.eclipse.core.runtime.jobs; bundle-symbolic-name="org.eclipse.core.jobs"; bundle-version="3.7.0.v20150330-2103"; version="0.0.0" org.eclipse.core.jobs [45] Unresolved requirement: Require-Capability: osgi.ee; filter:="(&(osgi.ee=JavaSE)(version=1.7))" !ENTRY org.eclipse.tycho.p2.tools.impl 2 0 2018-10-23 16:15:18.815 !MESSAGE Could not resolve module: org.eclipse.tycho.p2.tools.impl [56] Unresolved requirement: Import-Package: org.eclipse.tycho !ENTRY org.eclipse.ecf.provider.filetransfer.ssl 2 0 2018-10-23 16:15:18.816 !MESSAGE Could not resolve module: org.eclipse.ecf.provider.filetransfer.ssl [30] Unresolved requirement: Fragment-Host: org.eclipse.ecf.provider.filetransfer; bundle-version="2.0.0" -> Bundle-SymbolicName: org.eclipse.ecf.provider.filetransfer; bundle-version="3.2.200.v20150512-1727"; singleton:="true" org.eclipse.ecf.provider.filetransfer [5] Unresolved requirement: Import-Package: org.eclipse.core.net.proxy; resolution:="optional" -> Export-Package: org.eclipse.core.net.proxy; bundle-symbolic-name="org.eclipse.core.net"; bundle-version="1.2.300.v20141118-1725"; version="0.0.0" org.eclipse.core.net [31] Unresolved requirement: Require-Bundle: org.eclipse.equinox.security; bundle-version="[1.0.0,2.0.0)" -> Bundle-SymbolicName: org.eclipse.equinox.security; bundle-version="1.2.100.v20150423-1356"; singleton:="true" org.eclipse.equinox.security [2] Unresolved requirement: Import-Package: org.eclipse.core.runtime.jobs -> Export-Package: org.eclipse.core.runtime.jobs; bundle-symbolic-name="org.eclipse.core.jobs"; bundle-version="3.7.0.v20150330-2103"; version="0.0.0" org.eclipse.core.jobs [45] Unresolved requirement: Require-Capability: osgi.ee; filter:="(&(osgi.ee=JavaSE)(version=1.7))" Unresolved requirement: Import-Package: org.eclipse.core.runtime.jobs -> Export-Package: org.eclipse.core.runtime.jobs; bundle-symbolic-name="org.eclipse.core.jobs"; bundle-version="3.7.0.v20150330-2103"; version="0.0.0" !ENTRY org.eclipse.equinox.p2.metadata.repository 2 0 2018-10-23 16:15:18.817 !MESSAGE Could not resolve module: org.eclipse.equinox.p2.metadata.repository [50] Unresolved requirement: Import-Package: org.eclipse.equinox.internal.p2.persistence -> Export-Package: org.eclipse.equinox.internal.p2.persistence; bundle-symbolic-name="org.eclipse.equinox.p2.repository"; bundle-version="2.3.100.v20150428-1613"; version="0.0.0"; x-friends:="org.eclipse.equinox.p2.artifact.repository, org.eclipse.equinox.p2.engine, org.eclipse.equinox.p2.metadata.repository, org.eclipse.equinox.p2.ui.importexport, org.eclipse.equinox.p2.repository.tools" org.eclipse.equinox.p2.repository [12] Unresolved requirement: Import-Package: org.eclipse.core.runtime.jobs -> Export-Package: org.eclipse.core.runtime.jobs; bundle-symbolic-name="org.eclipse.core.jobs"; bundle-version="3.7.0.v20150330-2103"; version="0.0.0" org.eclipse.core.jobs [45] Unresolved requirement: Require-Capability: osgi.ee; filter:="(&(osgi.ee=JavaSE)(version=1.7))" !ENTRY org.eclipse.equinox.p2.publisher.eclipse 2 0 2018-10-23 16:15:18.817 !MESSAGE Could not resolve module: org.eclipse.equinox.p2.publisher.eclipse [17] Unresolved requirement: Import-Package: org.eclipse.equinox.internal.p2.artifact.repository -> Export-Package: org.eclipse.equinox.internal.p2.artifact.repository; bundle-symbolic-name="org.eclipse.equinox.p2.artifact.repository"; bundle-version="1.1.400.v20150513-2116"; version="0.0.0"; x-friends:="org.eclipse.equinox.p2.publisher, org.eclipse.equinox.p2.reconciler.dropins, org.eclipse.equinox.p2.ui, org.eclipse.equinox.p2.directorywatcher, org.eclipse.equinox.p2.repository.tools, org.eclipse.equinox.p2.publisher.eclipse" org.eclipse.equinox.p2.artifact.repository [33] Unresolved requirement: Import-Package: org.eclipse.core.runtime.jobs -> Export-Package: org.eclipse.core.runtime.jobs; bundle-symbolic-name="org.eclipse.core.jobs"; bundle-version="3.7.0.v20150330-2103"; version="0.0.0" org.eclipse.core.jobs [45] Unresolved requirement: Require-Capability: osgi.ee; filter:="(&(osgi.ee=JavaSE)(version=1.7))" !ENTRY org.eclipse.osgi 4 0 2018-10-23 16:15:18.818 !MESSAGE Application error !STACK 1 java.lang.IllegalStateException: Unable to acquire application service. Ensure that the org.eclipse.core.runtime bundle is resolved and started (see config.ini). at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:78) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:564) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:669) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:608) at org.eclipse.equinox.launcher.Main.run(Main.java:1515) at org.eclipse.equinox.launcher.Main.main(Main.java:1488) An error has occurred. See the log file /tmp/tycho-p2-runtime8716034074417446755.tmp/configuration/1540329316288.log. [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 27.375 s [INFO] Finished at: 2018-10-23T16:15:19-05:00 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.reficio:p2-maven-plugin:1.2.0:site (default-cli) on project external-dependencies: Execution default-cli of goal org.reficio:p2-maven-plugin:1.2.0:site failed: org.apache.maven.plugin.MojoExecutionException: Unable to execute mojo: P2 publisher return code was 13 -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.reficio:p2-maven-plugin:1.2.0:site (default-cli) on project external-dependencies: Execution default-cli of goal org.reficio:p2-maven-plugin:1.2.0:site failed: org.apache.maven.plugin.MojoExecutionException: Unable to execute mojo at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:213) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:154) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:146) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81) at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) at org.apache.maven.cli.MavenCli.execute (MavenCli.java:954) at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288) at org.apache.maven.cli.MavenCli.main (MavenCli.java:192) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:564) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:289) at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:229) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:415) at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:356) Caused by: org.apache.maven.plugin.PluginExecutionException: Execution default-cli of goal org.reficio:p2-maven-plugin:1.2.0:site failed: org.apache.maven.plugin.MojoExecutionException: Unable to execute mojo at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:148) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:208) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:154) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:146) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81) at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) at org.apache.maven.cli.MavenCli.execute (MavenCli.java:954) at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288) at org.apache.maven.cli.MavenCli.main (MavenCli.java:192) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:564) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:289) at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:229) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:415) at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:356) Caused by: java.lang.RuntimeException: org.apache.maven.plugin.MojoExecutionException: Unable to execute mojo at org.reficio.p2.P2Mojo.execute (P2Mojo.java:233) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:208) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:154) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:146) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81) at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) at org.apache.maven.cli.MavenCli.execute (MavenCli.java:954) at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288) at org.apache.maven.cli.MavenCli.main (MavenCli.java:192) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:564) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:289) at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:229) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:415) at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:356) Caused by: org.apache.maven.plugin.MojoExecutionException: Unable to execute mojo at org.twdata.maven.mojoexecutor.MojoExecutor.executeMojo (MojoExecutor.java:96) at org.reficio.p2.publisher.BundlePublisher.execute (BundlePublisher.java:57) at org.reficio.p2.P2Mojo.executeP2PublisherPlugin (P2Mojo.java:434) at org.reficio.p2.P2Mojo.execute (P2Mojo.java:229) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:208) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:154) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:146) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81) at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) at org.apache.maven.cli.MavenCli.execute (MavenCli.java:954) at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288) at org.apache.maven.cli.MavenCli.main (MavenCli.java:192) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:564) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:289) at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:229) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:415) at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:356) Caused by: org.apache.maven.plugin.MojoFailureException: P2 publisher return code was 13 at org.eclipse.tycho.plugins.p2.extras.PublishFeaturesAndBundlesMojo.publishContent (PublishFeaturesAndBundlesMojo.java:131) at org.eclipse.tycho.plugins.p2.extras.PublishFeaturesAndBundlesMojo.execute (PublishFeaturesAndBundlesMojo.java:105) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137) at org.twdata.maven.mojoexecutor.MojoExecutor.executeMojo (MojoExecutor.java:94) at org.reficio.p2.publisher.BundlePublisher.execute (BundlePublisher.java:57) at org.reficio.p2.P2Mojo.executeP2PublisherPlugin (P2Mojo.java:434) at org.reficio.p2.P2Mojo.execute (P2Mojo.java:229) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:208) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:154) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:146) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81) at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) at org.apache.maven.cli.MavenCli.execute (MavenCli.java:954) at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288) at org.apache.maven.cli.MavenCli.main (MavenCli.java:192) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:564) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:289) at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:229) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:415) at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:356) [ERROR] [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException ubuntu at tx2inst-c143:~/jmc/releng/third-party$ IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. From tejpal.rebari at oracle.com Wed Oct 24 02:40:42 2018 From: tejpal.rebari at oracle.com (Tejpal Rebari) Date: Wed, 24 Oct 2018 08:10:42 +0530 Subject: "Please consider reporting this to the maintainers of org.eclipse.osgi.storage.FrameworkExtensionInstaller" In-Reply-To: References: Message-ID: <40398B5E-E762-452D-846F-0C71A9AEEAFE@oracle.com> Hi Gary, Some of the build components still use jdk 8 , so jdk 8 is required to run mvn p2:site. Regards Tejpal > On 24-Oct-2018, at 2:53 AM, Gary Morrison wrote: > > Ya know, the more I look at it, the more I'm thinking maybe that's not the root problem after all. > > The way it ultimately fails is (turning on -e and -X): > > ------------------------------------------------------------ > > ... > !ENTRY org.eclipse.core.runtime 2 0 2018-10-23 16:15:18.813 > !MESSAGE Could not resolve module: org.eclipse.core.runtime [46] > Unresolved requirement: Require-Bundle: javax.annotation; bundle-version="1.1.0"; visibility:="reexport"; resolution:="optional" > Unresolved requirement: Require-Bundle: javax.inject; bundle-version="1.0.0"; visibility:="reexport"; resolution:="optional" > Unresolved requirement: Require-Bundle: org.eclipse.core.jobs; bundle-version="[3.2.0,4.0.0)"; visibility:="reexport" > -> Bundle-SymbolicName: org.eclipse.core.jobs; bundle-version="3.7.0.v20150330-2103"; singleton:="true" > org.eclipse.core.jobs [45] > Unresolved requirement: Require-Capability: osgi.ee; filter:="(&(osgi.ee=JavaSE)(version=1.7))" > > > !ENTRY org.eclipse.core.net 2 0 2018-10-23 16:15:18.814 > !MESSAGE Could not resolve module: org.eclipse.core.net [31] > Unresolved requirement: Require-Bundle: org.eclipse.equinox.security; bundle-version="[1.0.0,2.0.0)" > -> Bundle-SymbolicName: org.eclipse.equinox.security; bundle-version="1.2.100.v20150423-1356"; singleton:="true" > org.eclipse.equinox.security [2] > Unresolved requirement: Import-Package: org.eclipse.core.runtime.jobs > -> Export-Package: org.eclipse.core.runtime.jobs; bundle-symbolic-name="org.eclipse.core.jobs"; bundle-version="3.7.0.v20150330-2103"; version="0.0.0" > org.eclipse.core.jobs [45] > Unresolved requirement: Require-Capability: osgi.ee; filter:="(&(osgi.ee=JavaSE)(version=1.7))" > > > !ENTRY org.eclipse.ecf.provider.filetransfer.httpclient4 2 0 2018-10-23 16:15:18.815 > !MESSAGE Could not resolve module: org.eclipse.ecf.provider.filetransfer.httpclient4 [39] > Unresolved requirement: Import-Package: org.eclipse.core.runtime.jobs > -> Export-Package: org.eclipse.core.runtime.jobs; bundle-symbolic-name="org.eclipse.core.jobs"; bundle-version="3.7.0.v20150330-2103"; version="0.0.0" > org.eclipse.core.jobs [45] > Unresolved requirement: Require-Capability: osgi.ee; filter:="(&(osgi.ee=JavaSE)(version=1.7))" > > > !ENTRY org.eclipse.tycho.p2.tools.impl 2 0 2018-10-23 16:15:18.815 > !MESSAGE Could not resolve module: org.eclipse.tycho.p2.tools.impl [56] > Unresolved requirement: Import-Package: org.eclipse.tycho > > > !ENTRY org.eclipse.ecf.provider.filetransfer.ssl 2 0 2018-10-23 16:15:18.816 > !MESSAGE Could not resolve module: org.eclipse.ecf.provider.filetransfer.ssl [30] > Unresolved requirement: Fragment-Host: org.eclipse.ecf.provider.filetransfer; bundle-version="2.0.0" > -> Bundle-SymbolicName: org.eclipse.ecf.provider.filetransfer; bundle-version="3.2.200.v20150512-1727"; singleton:="true" > org.eclipse.ecf.provider.filetransfer [5] > Unresolved requirement: Import-Package: org.eclipse.core.net.proxy; resolution:="optional" > -> Export-Package: org.eclipse.core.net.proxy; bundle-symbolic-name="org.eclipse.core.net"; bundle-version="1.2.300.v20141118-1725"; version="0.0.0" > org.eclipse.core.net [31] > Unresolved requirement: Require-Bundle: org.eclipse.equinox.security; bundle-version="[1.0.0,2.0.0)" > -> Bundle-SymbolicName: org.eclipse.equinox.security; bundle-version="1.2.100.v20150423-1356"; singleton:="true" > org.eclipse.equinox.security [2] > Unresolved requirement: Import-Package: org.eclipse.core.runtime.jobs > -> Export-Package: org.eclipse.core.runtime.jobs; bundle-symbolic-name="org.eclipse.core.jobs"; bundle-version="3.7.0.v20150330-2103"; version="0.0.0" > org.eclipse.core.jobs [45] > Unresolved requirement: Require-Capability: osgi.ee; filter:="(&(osgi.ee=JavaSE)(version=1.7))" > Unresolved requirement: Import-Package: org.eclipse.core.runtime.jobs > -> Export-Package: org.eclipse.core.runtime.jobs; bundle-symbolic-name="org.eclipse.core.jobs"; bundle-version="3.7.0.v20150330-2103"; version="0.0.0" > > > !ENTRY org.eclipse.equinox.p2.metadata.repository 2 0 2018-10-23 16:15:18.817 > !MESSAGE Could not resolve module: org.eclipse.equinox.p2.metadata.repository [50] > Unresolved requirement: Import-Package: org.eclipse.equinox.internal.p2.persistence > -> Export-Package: org.eclipse.equinox.internal.p2.persistence; bundle-symbolic-name="org.eclipse.equinox.p2.repository"; bundle-version="2.3.100.v20150428-1613"; version="0.0.0"; x-friends:="org.eclipse.equinox.p2.artifact.repository, org.eclipse.equinox.p2.engine, org.eclipse.equinox.p2.metadata.repository, org.eclipse.equinox.p2.ui.importexport, org.eclipse.equinox.p2.repository.tools" > org.eclipse.equinox.p2.repository [12] > Unresolved requirement: Import-Package: org.eclipse.core.runtime.jobs > -> Export-Package: org.eclipse.core.runtime.jobs; bundle-symbolic-name="org.eclipse.core.jobs"; bundle-version="3.7.0.v20150330-2103"; version="0.0.0" > org.eclipse.core.jobs [45] > Unresolved requirement: Require-Capability: osgi.ee; filter:="(&(osgi.ee=JavaSE)(version=1.7))" > > > !ENTRY org.eclipse.equinox.p2.publisher.eclipse 2 0 2018-10-23 16:15:18.817 > !MESSAGE Could not resolve module: org.eclipse.equinox.p2.publisher.eclipse [17] > Unresolved requirement: Import-Package: org.eclipse.equinox.internal.p2.artifact.repository > -> Export-Package: org.eclipse.equinox.internal.p2.artifact.repository; bundle-symbolic-name="org.eclipse.equinox.p2.artifact.repository"; bundle-version="1.1.400.v20150513-2116"; version="0.0.0"; x-friends:="org.eclipse.equinox.p2.publisher, org.eclipse.equinox.p2.reconciler.dropins, org.eclipse.equinox.p2.ui, org.eclipse.equinox.p2.directorywatcher, org.eclipse.equinox.p2.repository.tools, org.eclipse.equinox.p2.publisher.eclipse" > org.eclipse.equinox.p2.artifact.repository [33] > Unresolved requirement: Import-Package: org.eclipse.core.runtime.jobs > -> Export-Package: org.eclipse.core.runtime.jobs; bundle-symbolic-name="org.eclipse.core.jobs"; bundle-version="3.7.0.v20150330-2103"; version="0.0.0" > org.eclipse.core.jobs [45] > Unresolved requirement: Require-Capability: osgi.ee; filter:="(&(osgi.ee=JavaSE)(version=1.7))" > > > !ENTRY org.eclipse.osgi 4 0 2018-10-23 16:15:18.818 > !MESSAGE Application error > !STACK 1 > java.lang.IllegalStateException: Unable to acquire application service. Ensure that the org.eclipse.core.runtime bundle is resolved and started (see config.ini). > at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:78) > at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380) > at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235) > at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.lang.reflect.Method.invoke(Method.java:564) > at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:669) > at org.eclipse.equinox.launcher.Main.basicRun(Main.java:608) > at org.eclipse.equinox.launcher.Main.run(Main.java:1515) > at org.eclipse.equinox.launcher.Main.main(Main.java:1488) > An error has occurred. See the log file > /tmp/tycho-p2-runtime8716034074417446755.tmp/configuration/1540329316288.log. > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD FAILURE > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 27.375 s > [INFO] Finished at: 2018-10-23T16:15:19-05:00 > [INFO] ------------------------------------------------------------------------ > [ERROR] Failed to execute goal org.reficio:p2-maven-plugin:1.2.0:site (default-cli) on project external-dependencies: Execution default-cli of goal org.reficio:p2-maven-plugin:1.2.0:site failed: org.apache.maven.plugin.MojoExecutionException: Unable to execute mojo: P2 publisher return code was 13 -> [Help 1] > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.reficio:p2-maven-plugin:1.2.0:site (default-cli) on project external-dependencies: Execution default-cli of goal org.reficio:p2-maven-plugin:1.2.0:site failed: org.apache.maven.plugin.MojoExecutionException: Unable to execute mojo > at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:213) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:154) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:146) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81) > at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56) > at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) > at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) > at org.apache.maven.cli.MavenCli.execute (MavenCli.java:954) > at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288) > at org.apache.maven.cli.MavenCli.main (MavenCli.java:192) > at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) > at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) > at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke (Method.java:564) > at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:289) > at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:229) > at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:415) > at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:356) > Caused by: org.apache.maven.plugin.PluginExecutionException: Execution default-cli of goal org.reficio:p2-maven-plugin:1.2.0:site failed: org.apache.maven.plugin.MojoExecutionException: Unable to execute mojo > at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:148) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:208) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:154) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:146) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81) > at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56) > at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) > at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) > at org.apache.maven.cli.MavenCli.execute (MavenCli.java:954) > at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288) > at org.apache.maven.cli.MavenCli.main (MavenCli.java:192) > at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) > at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) > at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke (Method.java:564) > at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:289) > at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:229) > at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:415) > at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:356) > Caused by: java.lang.RuntimeException: org.apache.maven.plugin.MojoExecutionException: Unable to execute mojo > at org.reficio.p2.P2Mojo.execute (P2Mojo.java:233) > at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:208) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:154) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:146) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81) > at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56) > at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) > at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) > at org.apache.maven.cli.MavenCli.execute (MavenCli.java:954) > at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288) > at org.apache.maven.cli.MavenCli.main (MavenCli.java:192) > at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) > at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) > at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke (Method.java:564) > at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:289) > at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:229) > at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:415) > at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:356) > Caused by: org.apache.maven.plugin.MojoExecutionException: Unable to execute mojo > at org.twdata.maven.mojoexecutor.MojoExecutor.executeMojo (MojoExecutor.java:96) > at org.reficio.p2.publisher.BundlePublisher.execute (BundlePublisher.java:57) > at org.reficio.p2.P2Mojo.executeP2PublisherPlugin (P2Mojo.java:434) > at org.reficio.p2.P2Mojo.execute (P2Mojo.java:229) > at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:208) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:154) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:146) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81) > at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56) > at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) > at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) > at org.apache.maven.cli.MavenCli.execute (MavenCli.java:954) > at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288) > at org.apache.maven.cli.MavenCli.main (MavenCli.java:192) > at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) > at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) > at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke (Method.java:564) > at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:289) > at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:229) > at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:415) > at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:356) > Caused by: org.apache.maven.plugin.MojoFailureException: P2 publisher return code was 13 > at org.eclipse.tycho.plugins.p2.extras.PublishFeaturesAndBundlesMojo.publishContent (PublishFeaturesAndBundlesMojo.java:131) > at org.eclipse.tycho.plugins.p2.extras.PublishFeaturesAndBundlesMojo.execute (PublishFeaturesAndBundlesMojo.java:105) > at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137) > at org.twdata.maven.mojoexecutor.MojoExecutor.executeMojo (MojoExecutor.java:94) > at org.reficio.p2.publisher.BundlePublisher.execute (BundlePublisher.java:57) > at org.reficio.p2.P2Mojo.executeP2PublisherPlugin (P2Mojo.java:434) > at org.reficio.p2.P2Mojo.execute (P2Mojo.java:229) > at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:208) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:154) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:146) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81) > at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56) > at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) > at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) > at org.apache.maven.cli.MavenCli.execute (MavenCli.java:954) > at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288) > at org.apache.maven.cli.MavenCli.main (MavenCli.java:192) > at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) > at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) > at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke (Method.java:564) > at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:289) > at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:229) > at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:415) > at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:356) > [ERROR] > [ERROR] > [ERROR] For more information about the errors and possible solutions, please read the following articles: > [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException > ubuntu at tx2inst-c143:~/jmc/releng/third-party$ > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. From ebaron at redhat.com Fri Oct 26 14:41:41 2018 From: ebaron at redhat.com (Elliott Baron) Date: Fri, 26 Oct 2018 10:41:41 -0400 Subject: Question about JMC-5604: Check bytecode verification flags Message-ID: <006442d7-2fea-bff7-87fa-f3f594b48c40@redhat.com> Hi, I started looking at this bug, and ran into some difficulty trying to distinguish between -noverify and -Xverify:none. It seems the former is a Java launcher argument which is converted to the latter before the JVM is started. Thus, no matter which option the user specifies, the JVM arguments will show -Xverify:none. Any advice on how to proceed with this issue? JFR doesn't record launcher arguments does it? (Please bear with me, I'm just getting started with JMC development.) Thanks, Elliott From neugens at redhat.com Fri Oct 26 15:43:09 2018 From: neugens at redhat.com (Mario Torre) Date: Fri, 26 Oct 2018 17:43:09 +0200 Subject: Question about JMC-5604: Check bytecode verification flags In-Reply-To: <006442d7-2fea-bff7-87fa-f3f594b48c40@redhat.com> References: <006442d7-2fea-bff7-87fa-f3f594b48c40@redhat.com> Message-ID: On Fri, 2018-10-26 at 10:41 -0400, Elliott Baron wrote: > Hi, > > I started looking at this bug, and ran into some difficulty trying > to > distinguish between -noverify and -Xverify:none. It seems the former > is > a Java launcher argument which is converted to the latter before the > JVM > is started. Thus, no matter which option the user specifies, the JVM > arguments will show -Xverify:none. > > Any advice on how to proceed with this issue? JFR doesn't record > launcher arguments does it? (Please bear with me, I'm just getting > started with JMC development.) Hi Elliott, That doesn't seem to be a bug to me. src/share/bin/java.c: 1153 (taken from a jdk8u) } else if (JLI_StrCmp(arg, "-noverify") == 0) { AddOption("-Xverify:none", NULL); I don't think there's any way for JMC to know that the original argument was -noverify other than parsing command line options for the pid, like: cat /proc//cmdline I don't know if there's a cross platform way to do that, but I don't think this information warrants this level of complication. For all intent and purpouses the two options are equivalent. Cheers, Mario -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From Gary.Morrison at arm.com Sat Oct 27 17:20:16 2018 From: Gary.Morrison at arm.com (Gary Morrison) Date: Sat, 27 Oct 2018 17:20:16 +0000 Subject: "HTTP Error 500: Internal Server Error" on "hg clone http://hg.openjdk.java.net/jmc/jmc/" Message-ID: Curious: hg clone http://hg.openjdk.java.net/jmc/jmc/ was working earlier, but now I'm getting a 500: ubuntu at tx2inst-c143:~$ hg clone http://hg.openjdk.java.net/jmc/jmc/ destination directory: jmc abort: HTTP Error 500: Internal Server Error ubuntu at tx2inst-c143:~$ Is it just me, or is anybody else also seeing this too? I've tried from several machines here. IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. From marcus.hirt at oracle.com Sun Oct 28 04:49:39 2018 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Sat, 27 Oct 2018 21:49:39 -0700 Subject: "HTTP Error 500: Internal Server Error" on "hg clone http://hg.openjdk.java.net/jmc/jmc/" In-Reply-To: References: Message-ID: <0796C1BC-E375-43A5-861F-1599105446B4@oracle.com> Hi Gary, I am seeing this too. I've reported it. Kind regards, Marcus ?On 2018-10-27, 10:20, "jmc-dev on behalf of Gary Morrison" wrote: Curious: hg clone http://hg.openjdk.java.net/jmc/jmc/ was working earlier, but now I'm getting a 500: ubuntu at tx2inst-c143:~$ hg clone http://hg.openjdk.java.net/jmc/jmc/ destination directory: jmc abort: HTTP Error 500: Internal Server Error ubuntu at tx2inst-c143:~$ Is it just me, or is anybody else also seeing this too? I've tried from several machines here. IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. From guru.hb at oracle.com Mon Oct 29 03:48:04 2018 From: guru.hb at oracle.com (Guru) Date: Mon, 29 Oct 2018 09:18:04 +0530 Subject: "HTTP Error 500: Internal Server Error" on "hg clone http://hg.openjdk.java.net/jmc/jmc/" In-Reply-To: <0796C1BC-E375-43A5-861F-1599105446B4@oracle.com> References: <0796C1BC-E375-43A5-861F-1599105446B4@oracle.com> Message-ID: <61FCE9AC-8449-4BB6-A7B8-DD1FD7A08850@oracle.com> Hi Gary, Now its this problem is resolved. You can now clone or browse http://hg.openjdk.java.net/jmc/jmc Thanks, Guru > On 28-Oct-2018, at 10:19 AM, Marcus Hirt wrote: > > Hi Gary, > > I am seeing this too. I've reported it. > > Kind regards, > Marcus > > ?On 2018-10-27, 10:20, "jmc-dev on behalf of Gary Morrison" wrote: > > Curious: > > hg clone http://hg.openjdk.java.net/jmc/jmc/ > > was working earlier, but now I'm getting a 500: > > ubuntu at tx2inst-c143:~$ hg clone http://hg.openjdk.java.net/jmc/jmc/ > destination directory: jmc > abort: HTTP Error 500: Internal Server Error > ubuntu at tx2inst-c143:~$ > > Is it just me, or is anybody else also seeing this too? I've tried from several machines here. > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. > > > > From sharath.ballal at oracle.com Tue Oct 30 14:58:33 2018 From: sharath.ballal at oracle.com (sharath.ballal at oracle.com) Date: Tue, 30 Oct 2018 14:58:33 +0000 Subject: hg: jmc/jmc: JMC-5622: Update the updatesite landing pages for 7.0.0 Message-ID: <201810301458.w9UEwX6o020611@aojmv0008.oracle.com> Changeset: f44b4ea288ef Author: sballal Date: 2018-10-30 20:26 +0530 URL: http://hg.openjdk.java.net/jmc/jmc/rev/f44b4ea288ef JMC-5622: Update the updatesite landing pages for 7.0.0 Reviewed-by: hirt ! application/org.openjdk.jmc.updatesite.ide/src/main/resources/index.html ! application/org.openjdk.jmc.updatesite.rcp/src/main/resources/index.html From neugens at redhat.com Tue Oct 30 17:29:26 2018 From: neugens at redhat.com (Mario Torre) Date: Tue, 30 Oct 2018 18:29:26 +0100 Subject: IRC channel SPAM Message-ID: Hello all, Given the amount of disturbing spam we are receiving we are thinking to close the channel to registered users only. We are in contact with the OFTC polizei, so we may not do that if we getsee a reduction in spam, however we think is a good idea to keep nicks registered nonetheless. We'll make a decision in about one week, for now, here are some useful instructions to register your nicks. If you use Matrix: 1. From Matrix, /msg NickServ register [password] [email] 2. Go to https://services.oftc.net/ and login with [nick] as username, and the password you used in step 1, then go to Account -> Verify and complete the captcha 3. Back on Matrix, /msg NickServ checkverify 4. /msg NickServ link [nick] [password] If you use xchat or hexchat: /msg NickServ register [password] [email] /msg NickServ IDENTIFY [password] This should make you a registered user and able to use the channel. As said, we won't be making it +R just yet, but it's recommended you keep the nicks registered. Cheers, Mario -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From kdobson at redhat.com Tue Oct 30 17:36:57 2018 From: kdobson at redhat.com (Ken Dobson) Date: Tue, 30 Oct 2018 13:36:57 -0400 Subject: JMC-6100 and JMC-6152 Trigger Alerts Message-ID: Hi All, I was having a quick look at https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6100 which seem to be a duplicate of https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6152 . It seems as if that is actually how it is intended to work as of right now, as dumping an hprof file shouldn't provide an alert in JMC, just dump the file to the location you've chosen which occurs correctly. The alert that occurs the second time you turn the trigger on is an error for trying to create a file that already exists as you had previously created it. I was wondering if someone could provide some insight into whether we would like to change this in some way, such as appending a timestamp to the hprof to ensure file names aren't duplicated in case a user wanted to dump an hprof more than once. As well, logging a a trigger alert to a text file currently overwrites the previous file so that is another option. That being said it seems odd to me to keep just the most recent trigger alert rather than appending an alert so that there's a log of the previous alerts. Any insight into whether this is intended and why or whether this requires changes would be appreciated. Thanks, Ken Dobson From guru.hb at oracle.com Tue Oct 30 17:52:45 2018 From: guru.hb at oracle.com (Guru) Date: Tue, 30 Oct 2018 23:22:45 +0530 Subject: JMC-6100 and JMC-6152 Trigger Alerts In-Reply-To: References: Message-ID: Thank you Ken, Yes, JMC-6100 is duplicate of JMC-6152. I have made one of the duplicate. Defect is about the Trigger Dialog not promoted even though the intended event had encountered. There will be a One Dialog for one trigger events (which also dumps hprof ). Thanks, Guru > On 30-Oct-2018, at 11:06 PM, Ken Dobson wrote: > > Hi All, > > I was having a quick look at > https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6100 which seem to be > a duplicate of https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6152 . > It seems as if that is actually how it is intended to work as of right now, > as dumping an hprof file shouldn't provide an alert in JMC, just dump the > file to the location you've chosen which occurs correctly. The alert that > occurs the second time you turn the trigger on is an error for trying to > create a file that already exists as you had previously created it. > > I was wondering if someone could provide some insight into whether we would > like to change this in some way, such as appending a timestamp to the hprof > to ensure file names aren't duplicated in case a user wanted to dump an > hprof more than once. > As well, logging a a trigger alert to a text file currently overwrites the > previous file so that is another option. That being said it seems odd to me > to keep just the most recent trigger alert rather than appending an alert > so that there's a log of the previous alerts. > > Any insight into whether this is intended and why or whether this requires > changes would be appreciated. > > Thanks, > > Ken Dobson From marcus.hirt at oracle.com Tue Oct 30 18:02:47 2018 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Tue, 30 Oct 2018 11:02:47 -0700 Subject: IRC channel SPAM In-Reply-To: <10F2A71A-07C9-4419-848E-AF51D4308F33@redhat.com> References: <10F2A71A-07C9-4419-848E-AF51D4308F33@redhat.com> Message-ID: If you're using riot as client, simply start a chat with: @_oftc_NickServ:matrix.org ...and send commands in the chat instead of '/msg NickServ' Also note that the link part is only if you want to link a pre-existing oftc nick to your matrix nick, and that it is the oftc account that should be supplied in step 4 (!= matrix account, i.e. not the same nick as in step 2). It is not required if you only want to register your matrix nick. Kind regards, Marcus ?On 2018-10-30, 10:29, "jmc-dev on behalf of Mario Torre" wrote: Hello all, Given the amount of disturbing spam we are receiving we are thinking to close the channel to registered users only. We are in contact with the OFTC polizei, so we may not do that if we getsee a reduction in spam, however we think is a good idea to keep nicks registered nonetheless. We'll make a decision in about one week, for now, here are some useful instructions to register your nicks. If you use Matrix: 1. From Matrix, /msg NickServ register [password] [email] 2. Go to https://services.oftc.net/ and login with [nick] as username, and the password you used in step 1, then go to Account -> Verify and complete the captcha 3. Back on Matrix, /msg NickServ checkverify 4. /msg NickServ link [nick] [password] If you use xchat or hexchat: /msg NickServ register [password] [email] /msg NickServ IDENTIFY [password] This should make you a registered user and able to use the channel. As said, we won't be making it +R just yet, but it's recommended you keep the nicks registered. Cheers, Mario -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From marcus.hirt at oracle.com Tue Oct 30 18:17:14 2018 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Tue, 30 Oct 2018 11:17:14 -0700 Subject: JMC-6100 and JMC-6152 Trigger Alerts In-Reply-To: References: Message-ID: <4720A3FD-33D4-4232-A423-86E9D24E1A47@oracle.com> Agree with Ken. You select what action you want to take place if the rule is triggered. If you want a triggered rule to be displayed in the alert dialog, then that is the action you should select. If you want something else to happen, you select another action. We route errors to the dialog to make them discoverable, as there is was no apparent place to place them that would make people discover them. That does not mean we should always have the trigger dialog as a parallel, always on, action for everything. It may mean that we should log problems somewhere else in the future... Kind regards, Marcus ?On 2018-10-30, 10:53, "jmc-dev on behalf of Guru" wrote: Thank you Ken, Yes, JMC-6100 is duplicate of JMC-6152. I have made one of the duplicate. Defect is about the Trigger Dialog not promoted even though the intended event had encountered. There will be a One Dialog for one trigger events (which also dumps hprof ). Thanks, Guru > On 30-Oct-2018, at 11:06 PM, Ken Dobson wrote: > > Hi All, > > I was having a quick look at > https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6100 which seem to be > a duplicate of https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6152 . > It seems as if that is actually how it is intended to work as of right now, > as dumping an hprof file shouldn't provide an alert in JMC, just dump the > file to the location you've chosen which occurs correctly. The alert that > occurs the second time you turn the trigger on is an error for trying to > create a file that already exists as you had previously created it. > > I was wondering if someone could provide some insight into whether we would > like to change this in some way, such as appending a timestamp to the hprof > to ensure file names aren't duplicated in case a user wanted to dump an > hprof more than once. > As well, logging a a trigger alert to a text file currently overwrites the > previous file so that is another option. That being said it seems odd to me > to keep just the most recent trigger alert rather than appending an alert > so that there's a log of the previous alerts. > > Any insight into whether this is intended and why or whether this requires > changes would be appreciated. > > Thanks, > > Ken Dobson From marcus.hirt at oracle.com Tue Oct 30 18:24:32 2018 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Tue, 30 Oct 2018 11:24:32 -0700 Subject: JMC-6100 and JMC-6152 Trigger Alerts In-Reply-To: <7A8B0594-B5D8-446C-9CC3-C6E48CE074D0@redhat.com> References: <7A8B0594-B5D8-446C-9CC3-C6E48CE074D0@redhat.com> Message-ID: <850F9058-85C7-4DED-A76F-140C9B0AAF53@oracle.com> Hi Ken, I was sure that logging to file was appending. As a matter of fact, that is one of the demos I used to do - have the file open in a separate editor and watching it refresh itself as new events are coming in. If this behavior has changed, that is indeed a bug. I just ran it in Eclipse, and it even refreshes the editor as new data is coming In. ;) <--8<--> ========== Notification Alert! ========== A notification event has been triggered! Notification creation time was: Tue Oct 30 11:22:13 PDT 2018 The notification source is: [11] LoadAndDeadlock (6496) The notification rule is: CPU Usage - JVM Process (Too High) Type description: attribute://java.lang:type=OperatingSystem/ProcessCpuLoad Rule trigger condition: value > 15 % The actual trigger value: 0.21656308360607793========================================= ========== Notification Alert! ========== A notification event has been triggered! Notification creation time was: Tue Oct 30 11:22:40 PDT 2018 The notification source is: [11] LoadAndDeadlock (6496) The notification rule is: CPU Usage - JVM Process (Too High) Type description: attribute://java.lang:type=OperatingSystem/ProcessCpuLoad Rule trigger condition: value > 15 % The actual trigger value: 0.22926899255241157========================================= ========== Notification Alert! ========== A notification event has been triggered! Notification creation time was: Tue Oct 30 11:23:07 PDT 2018 The notification source is: [11] LoadAndDeadlock (6496) The notification rule is: CPU Usage - JVM Process (Too High) Type description: attribute://java.lang:type=OperatingSystem/ProcessCpuLoad Rule trigger condition: value > 15 % The actual trigger value: 0.21038889067047212========================================= <--8<--> Could this be a problem that is limited to running the stand alone app? Kind regards, Marcus ?On 2018-10-30, 10:37, "jmc-dev on behalf of Ken Dobson" wrote: Hi All, I was having a quick look at https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6100 which seem to be a duplicate of https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6152 . It seems as if that is actually how it is intended to work as of right now, as dumping an hprof file shouldn't provide an alert in JMC, just dump the file to the location you've chosen which occurs correctly. The alert that occurs the second time you turn the trigger on is an error for trying to create a file that already exists as you had previously created it. I was wondering if someone could provide some insight into whether we would like to change this in some way, such as appending a timestamp to the hprof to ensure file names aren't duplicated in case a user wanted to dump an hprof more than once. As well, logging a a trigger alert to a text file currently overwrites the previous file so that is another option. That being said it seems odd to me to keep just the most recent trigger alert rather than appending an alert so that there's a log of the previous alerts. Any insight into whether this is intended and why or whether this requires changes would be appreciated. Thanks, Ken Dobson From kdobson at redhat.com Tue Oct 30 21:17:24 2018 From: kdobson at redhat.com (Ken Dobson) Date: Tue, 30 Oct 2018 17:17:24 -0400 Subject: JMC-6100 and JMC-6152 Trigger Alerts In-Reply-To: <850F9058-85C7-4DED-A76F-140C9B0AAF53@oracle.com> References: <7A8B0594-B5D8-446C-9CC3-C6E48CE074D0@redhat.com> <850F9058-85C7-4DED-A76F-140C9B0AAF53@oracle.com> Message-ID: Hi Marcus, Yes, looking now it seems it only occurs in the standalone version, I'm having a look into why that might be. Regarding the hprof dump, should we be allowing another hprof dump to occur if the same trigger is triggered again? It seems to me that there should be a better solution than throwing an error because the file already exists. Something like appending a timestamp similar to the way it's done when a trigger dumps a JFR file. Ken Dobson On Tue, Oct 30, 2018 at 2:24 PM Marcus Hirt wrote: > Hi Ken, > > I was sure that logging to file was appending. As a matter of fact, that > is one > of the demos I used to do - have the file open in a separate editor and > watching > it refresh itself as new events are coming in. If this behavior has > changed, that > is indeed a bug. > > I just ran it in Eclipse, and it even refreshes the editor as new data is > coming > In. ;) > > <--8<--> > ========== Notification Alert! ========== > A notification event has been triggered! > > Notification creation time was: Tue Oct 30 11:22:13 PDT 2018 > The notification source is: [11] LoadAndDeadlock (6496) > The notification rule is: CPU Usage - JVM Process (Too High) > Type description: > attribute://java.lang:type=OperatingSystem/ProcessCpuLoad > Rule trigger condition: value > 15 % > The actual trigger value: > 0.21656308360607793========================================= > > ========== Notification Alert! ========== > A notification event has been triggered! > > Notification creation time was: Tue Oct 30 11:22:40 PDT 2018 > The notification source is: [11] LoadAndDeadlock (6496) > The notification rule is: CPU Usage - JVM Process (Too High) > Type description: > attribute://java.lang:type=OperatingSystem/ProcessCpuLoad > Rule trigger condition: value > 15 % > The actual trigger value: > 0.22926899255241157========================================= > > ========== Notification Alert! ========== > A notification event has been triggered! > > Notification creation time was: Tue Oct 30 11:23:07 PDT 2018 > The notification source is: [11] LoadAndDeadlock (6496) > The notification rule is: CPU Usage - JVM Process (Too High) > Type description: > attribute://java.lang:type=OperatingSystem/ProcessCpuLoad > Rule trigger condition: value > 15 % > The actual trigger value: > 0.21038889067047212========================================= > > <--8<--> > > Could this be a problem that is limited to running the stand alone app? > > Kind regards, > Marcus > > ?On 2018-10-30, 10:37, "jmc-dev on behalf of Ken Dobson" < > jmc-dev-bounces at openjdk.java.net on behalf of kdobson at redhat.com> wrote: > > Hi All, > > I was having a quick look at > https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6100 which seem > to be > a duplicate of > https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6152 . > It seems as if that is actually how it is intended to work as of right > now, > as dumping an hprof file shouldn't provide an alert in JMC, just dump > the > file to the location you've chosen which occurs correctly. The alert > that > occurs the second time you turn the trigger on is an error for trying > to > create a file that already exists as you had previously created it. > > I was wondering if someone could provide some insight into whether we > would > like to change this in some way, such as appending a timestamp to the > hprof > to ensure file names aren't duplicated in case a user wanted to dump an > hprof more than once. > As well, logging a a trigger alert to a text file currently overwrites > the > previous file so that is another option. That being said it seems odd > to me > to keep just the most recent trigger alert rather than appending an > alert > so that there's a log of the previous alerts. > > Any insight into whether this is intended and why or whether this > requires > changes would be appreciated. > > Thanks, > > Ken Dobson > > > > > From marcus.hirt at oracle.com Tue Oct 30 23:23:48 2018 From: marcus.hirt at oracle.com (Marcus Hirt) Date: Tue, 30 Oct 2018 16:23:48 -0700 Subject: JMC-6100 and JMC-6152 Trigger Alerts In-Reply-To: References: <7A8B0594-B5D8-446C-9CC3-C6E48CE074D0@redhat.com> <850F9058-85C7-4DED-A76F-140C9B0AAF53@oracle.com> Message-ID: Agreed. /M - Excuse me if terse; sent from my phone. > On 30 Oct 2018, at 14:17, Ken Dobson wrote: > > Hi Marcus, > > Yes, looking now it seems it only occurs in the standalone version, I'm having a look into why that might be. Regarding the hprof dump, should we be allowing another hprof dump to occur if the same trigger is triggered again? It seems to me that there should be a better solution than throwing an error because the file already exists. Something like appending a timestamp similar to the way it's done when a trigger dumps a JFR file. > > Ken Dobson > >> On Tue, Oct 30, 2018 at 2:24 PM Marcus Hirt wrote: >> Hi Ken, >> >> I was sure that logging to file was appending. As a matter of fact, that is one >> of the demos I used to do - have the file open in a separate editor and watching >> it refresh itself as new events are coming in. If this behavior has changed, that >> is indeed a bug. >> >> I just ran it in Eclipse, and it even refreshes the editor as new data is coming >> In. ;) >> >> <--8<--> >> ========== Notification Alert! ========== >> A notification event has been triggered! >> >> Notification creation time was: Tue Oct 30 11:22:13 PDT 2018 >> The notification source is: [11] LoadAndDeadlock (6496) >> The notification rule is: CPU Usage - JVM Process (Too High) >> Type description: >> attribute://java.lang:type=OperatingSystem/ProcessCpuLoad >> Rule trigger condition: value > 15 % >> The actual trigger value: 0.21656308360607793========================================= >> >> ========== Notification Alert! ========== >> A notification event has been triggered! >> >> Notification creation time was: Tue Oct 30 11:22:40 PDT 2018 >> The notification source is: [11] LoadAndDeadlock (6496) >> The notification rule is: CPU Usage - JVM Process (Too High) >> Type description: >> attribute://java.lang:type=OperatingSystem/ProcessCpuLoad >> Rule trigger condition: value > 15 % >> The actual trigger value: 0.22926899255241157========================================= >> >> ========== Notification Alert! ========== >> A notification event has been triggered! >> >> Notification creation time was: Tue Oct 30 11:23:07 PDT 2018 >> The notification source is: [11] LoadAndDeadlock (6496) >> The notification rule is: CPU Usage - JVM Process (Too High) >> Type description: >> attribute://java.lang:type=OperatingSystem/ProcessCpuLoad >> Rule trigger condition: value > 15 % >> The actual trigger value: 0.21038889067047212========================================= >> >> <--8<--> >> >> Could this be a problem that is limited to running the stand alone app? >> >> Kind regards, >> Marcus >> >> ?On 2018-10-30, 10:37, "jmc-dev on behalf of Ken Dobson" wrote: >> >> Hi All, >> >> I was having a quick look at >> https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6100 which seem to be >> a duplicate of https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6152 . >> It seems as if that is actually how it is intended to work as of right now, >> as dumping an hprof file shouldn't provide an alert in JMC, just dump the >> file to the location you've chosen which occurs correctly. The alert that >> occurs the second time you turn the trigger on is an error for trying to >> create a file that already exists as you had previously created it. >> >> I was wondering if someone could provide some insight into whether we would >> like to change this in some way, such as appending a timestamp to the hprof >> to ensure file names aren't duplicated in case a user wanted to dump an >> hprof more than once. >> As well, logging a a trigger alert to a text file currently overwrites the >> previous file so that is another option. That being said it seems odd to me >> to keep just the most recent trigger alert rather than appending an alert >> so that there's a log of the previous alerts. >> >> Any insight into whether this is intended and why or whether this requires >> changes would be appreciated. >> >> Thanks, >> >> Ken Dobson >> >> >> >> From kdobson at redhat.com Wed Oct 31 19:51:02 2018 From: kdobson at redhat.com (Ken Dobson) Date: Wed, 31 Oct 2018 15:51:02 -0400 Subject: JMC-6100/6152 Message-ID: Hi All, This is a small patch to allows multiple HPROF dumps if a trigger is triggered multiple times, rather than throwing an error when it tries to create a file that already exists. This is done by appending a timestamp to the end of the filename if it already exists. Thanks, Ken Dobson diff -r b3a23786ef23 application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/triggers/actions/internal/TriggerActionHPROF.java --- a/application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/triggers/actions/internal/TriggerActionHPROF.java Wed Oct 10 16:43:35 2018 -0400 +++ b/application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/triggers/actions/internal/TriggerActionHPROF.java Wed Oct 31 15:26:38 2018 -0400 @@ -44,6 +44,7 @@ import org.openjdk.jmc.rjmx.RJMXPlugin; import org.openjdk.jmc.rjmx.triggers.TriggerAction; import org.openjdk.jmc.rjmx.triggers.TriggerEvent; +import org.openjdk.jmc.ui.common.util.Filename; /** * This notification action triggers a hprof dump. @@ -70,7 +71,7 @@ */ @Override public void handleNotificationEvent(TriggerEvent e) throws Exception { - String fileName = getSetting("filename").getString(); //$NON-NLS-1$ + String fileName = Filename.splitFilename(getSetting("filename").getString()).asRandomFilename().toString(); //$NON-NLS-1$ Boolean onlyLive = getSetting("only_live").getBoolean(); //$NON-NLS-1$ if (onlyLive == null) { onlyLive = Boolean.TRUE; From kdobson at redhat.com Wed Oct 31 19:57:48 2018 From: kdobson at redhat.com (Ken Dobson) Date: Wed, 31 Oct 2018 15:57:48 -0400 Subject: Log to File constantly being overwritten in Standalone JMC Message-ID: Hi All, Another tiny patch fixing Triggers logging to a file in the Standalone version. Ken Dobson diff -r b3a23786ef23 application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/BasicFile.java --- a/application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/BasicFile.java Wed Oct 10 16:43:35 2018 -0400 +++ b/application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/BasicFile.java Wed Oct 31 15:43:55 2018 -0400 @@ -74,7 +74,7 @@ private static void write(InputStream in, File toOutput, boolean append) throws IOException { File parent = toOutput.getParentFile(); if (parent.isDirectory() || parent.mkdirs()) { - IOToolkit.write(in, toOutput, false); + IOToolkit.write(in, toOutput, append); } else { throw new IOException(); }