JMC-6118: Java Mission Control tests fails on OpenJDK 8

[Marcus Hirt]

Hi Salman,

I would be happy to! Where can I take a look at the patch?

Kind regards,
Marcus

On 2018-09-28, 18:21, "jmc-dev on behalf of Salman Siddiqui" <jmc-dev-bounces at openjdk.java.net on behalf of sasiddiq at redhat.com> wrote:

    Hi all,
    
    I've updated the patch. If someone could please review the changes, that
    would be great.
    
    Thanks,
    Salman
    
    On Fri, Sep 14, 2018 at 10:16 AM Marcus Hirt <marcus.hirt at oracle.com> wrote:
    
    > Hi Salman,
    >
    > I'll try the patch on my Windows machine at home tonight. If it works on
    > my machine,
    > then I'll open up a new bug for fixing so that the browser UI-tests run
    > properly on
    > Fedora.
    >
    > Kind regards,
    > Marcus
    >
    > On 2018-09-14, 06:01, "jmc-dev on behalf of Salman Siddiqui" <
    > jmc-dev-bounces at openjdk.java.net on behalf of sasiddiq at redhat.com> wrote:
    >
    >     Hi,
    >
    >     Please review attached patch file for fix to JMC-6118.
    >     I've tested on Linux (Fedora) with OpenJDK 8. I don't have a Windows
    >     machine available for testing so I'd appreciate some help on that
    > front.
    >
    >     Thanks,
    >     Salman
    >
    >     On Mon, Sep 10, 2018 at 1:32 PM Salman Siddiqui <sasiddiq at redhat.com>
    > wrote:
    >
    >     > Hi,
    >     >
    >     > At the request of Mario, I've been working on JMC-6118.
    >     > Some tests require commercial features and, as a result, are failing
    > on
    >     > OpenJDK 8.
    >     > My approach for a solution was to have a build profile that will
    > specify
    >     > test.excludes in the tycho-surefire-plugin configuration for tests
    > that
    >     > require commercial features. The profile will be activated when an
    > OpenJDK
    >     > runtime is detected.
    >     > However, it seems to not be working.
    >     > I was hoping someone take a look at the attached patch file and give
    > some
    >     > pointers on how to approach a fix.
    >     >
    >     > Cheers,
    >     > Salman
    >     >
    >
    >
    >
    >
    >
    
    -- 
    
    
    Salman Siddiqui
    
    Software Engineer Intern
    
    Red Hat, Toronto, Canada <https://www.redhat.com/>
    
    sasiddiq at redhat.com
    <https://red.ht/sig>