Review request for JMC-6153: Making the JfrHtmlRulesReport work again

Guru guru.hb at oracle.com
Mon Oct 1 12:34:34 UTC 2018


+1 to http://cr.openjdk.java.net/~hirt/JMC-6153/webrev.02/ <http://cr.openjdk.java.net/~hirt/JMC-6153/webrev.02/> 
Tested on Windows.

Thanks,
Guru
> On 01-Oct-2018, at 5:21 PM, Marcus Hirt <marcus.hirt at oracle.com> wrote:
> 
> Hi Guru,
> 
> Added test:
> http://cr.openjdk.java.net/~hirt/JMC-6153/webrev.01/
> 
> Kind regards,
> Marcus
> 
> On 2018-10-01, 13:12, "Guru" <guru.hb at oracle.com> wrote:
> 
>    +1, Changes looks good to me. 
> 
>    Thanks,
>    Guru
>> On 01-Oct-2018, at 2:03 PM, Marcus Hirt <marcus.hirt at oracle.com> wrote:
>> 
>> Hi all,
>> 
>> Please review this fix to make the JfrHtmlRulesReport work again.
>> 
>> Jira:   https://bugs.openjdk.java.net/browse/JMC-6153
>> 
>> The fix is to move core\org.openjdk.jmc.flightrecorder.rules\src\main\java\org\openjdk\jmc\flightrecorder\rules\report\html\resultgroups.xml to core\org.openjdk.jmc.flightrecorder.rules\src\main\resources\org\openjdk\jmc\flightrecorder\rules\report\html\resultgroups.xml
>> 
>> Kind regards,
>> Marcus
>> 
>> 
> 
> 
> 
> 
> 



More information about the jmc-dev mailing list