Review request for JMC-6158: Adding JfrAttribute for event type id

[Sharath Ballal]

+1, Changes looks good to me.

I have a question though, would addition of EVENT_TYPE_ID effect any other test ?

Thanks,
Sharath


-----Original Message-----
From: Guru 
Sent: Thursday, October 04, 2018 9:07 AM
To: Marcus Hirt
Cc: jmc-dev at openjdk.java.net
Subject: Re: Review request for JMC-6158: Adding JfrAttribute for event type id

+1, Changes looks good to me. 

+nit : If possible modify the text "The identifier for the event type of the event” (Three `the` in the sentence).

Thanks,
Guru
> On 04-Oct-2018, at 4:06 AM, Marcus Hirt <marcus.hirt at oracle.com> wrote:
> 
> Hi all,
> 
> Please review this fix to provide a JfrAttribute for event type id.
> 
> Jira:   https://bugs.openjdk.java.net/browse/JMC-6158
> Webrev: http://cr.openjdk.java.net/~hirt/JMC-6158/webrev.01/
> 
> Kind regards,
> Marcus
> 
>