Review request for JMC-6158: Adding JfrAttribute for event type id

[Marcus Hirt]

Thanks, couldn’t come up with anything better and still grammatically correct, so pushed as is. If someone has a better idea, feel free to adjust.

 

Kind regards,

Marcus

 

From: Guru <guru.hb at oracle.com>
Date: Thursday, 4 October 2018 at 05:37
To: Marcus Hirt <marcus.hirt at oracle.com>
Cc: "jmc-dev at openjdk.java.net" <jmc-dev at openjdk.java.net>
Subject: Re: Review request for JMC-6158: Adding JfrAttribute for event type id

 

+1, Changes looks good to me. 

 

+nit : If possible modify the text "The identifier for the event type of the event” (Three `the` in the sentence).

 

Thanks,

Guru

On 04-Oct-2018, at 4:06 AM, Marcus Hirt <marcus.hirt at oracle.com> wrote:

 

Hi all,

Please review this fix to provide a JfrAttribute for event type id.

Jira:   https://bugs.openjdk.java.net/browse/JMC-6158
Webrev: http://cr.openjdk.java.net/~hirt/JMC-6158/webrev.01/

Kind regards,
Marcus