Review request for JMC-6158: Adding JfrAttribute for event type id

[Marcus Hirt]

Hi Sharath,

No, not that I can think of. That said, this entire area would benefit from 
better tests. I added a simple verification test in terms of another related 
attribute, but the test coverage for this part of the code isn't great.

Kind regards,
Marcus

On 2018-10-04, 06:34, "Sharath Ballal" <sharath.ballal at oracle.com> wrote:

    +1, Changes looks good to me.
    
    I have a question though, would addition of EVENT_TYPE_ID effect any other test ?
    
    Thanks,
    Sharath
    
    
    -----Original Message-----
    From: Guru 
    Sent: Thursday, October 04, 2018 9:07 AM
    To: Marcus Hirt
    Cc: jmc-dev at openjdk.java.net
    Subject: Re: Review request for JMC-6158: Adding JfrAttribute for event type id
    
    +1, Changes looks good to me. 
    
    +nit : If possible modify the text "The identifier for the event type of the event” (Three `the` in the sentence).
    
    Thanks,
    Guru
    > On 04-Oct-2018, at 4:06 AM, Marcus Hirt <marcus.hirt at oracle.com> wrote:
    > 
    > Hi all,
    > 
    > Please review this fix to provide a JfrAttribute for event type id.
    > 
    > Jira:   https://bugs.openjdk.java.net/browse/JMC-6158
    > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6158/webrev.01/
    > 
    > Kind regards,
    > Marcus
    > 
    >