JMC-6118: Java Mission Control tests fails on OpenJDK 8
Salman Siddiqui
sasiddiq at redhat.com
Wed Oct 10 16:53:52 UTC 2018
Hi Guru,
I tested the patch on an Ubuntu 18.04 VM and it works fine.
Can you please take another look and send me a more detailed log of the
issue you experienced?
Thanks,
Salman
On Fri, Oct 5, 2018 at 3:48 PM Salman Siddiqui <sasiddiq at redhat.com> wrote:
> Hi Guru,
>
> Could you please send a log of the errors you encountered on Ubuntu?
>
> Thanks,
> Salman
>
> On Mon, Oct 1, 2018 at 11:07 AM Marcus Hirt <marcus.hirt at oracle.com>
> wrote:
>
>> Hi Salman,
>>
>> Looks good to me! Guru, since you're the build maestro,
>> perhaps you can take a look too?
>>
>> Kind regards,
>> Marcus
>>
>>
>> From: Salman Siddiqui <sasiddiq at redhat.com>
>> Date: Monday, 1 October 2018 at 16:29
>> To: <marcus.hirt at oracle.com>
>> Subject: Re: JMC-6118: Java Mission Control tests fails on OpenJDK 8
>>
>> Hi Marcus
>>
>> On Mon, Oct 1, 2018 at 10:57 AM Marcus Hirt <mailto:
>> marcus.hirt at oracle.com> wrote:
>> Hi Salman,
>> I would be happy to! Where can I take a look at the patch?
>>
>> I sent it as an attachment to my previous email. It is also pasted below.
>>
>>
>> Kind regards,
>> Marcus
>>
>>
>> diff -r 896f9586d4c6 application/pom.xml
>> --- a/application/pom.xml Thu Sep 20 08:32:13 2018 -0700
>> +++ b/application/pom.xml Fri Sep 28 12:13:40 2018 -0400
>> @@ -110,6 +110,20 @@
>> </modules>
>> <profiles>
>> <profile>
>> + <id>no-jfr</id>
>> + <activation>
>> + <property>
>> + <name>http://java.runtime.name</name>
>> + <value>OpenJDK Runtime Environment</value>
>> + </property>
>> + <jdk>(,11)</jdk>
>> + </activation>
>> + <properties>
>> +
>> <jfr.tests>org.openjdk.jmc.rjmx.test.services.CommercialFeaturesServiceTest,org.openjdk.jmc.flightrecorder.controlpanel.ui.model.test.EventConfigurationModelTest,org.openjdk.jmc.flightrecorder.controlpanel.ui.test.PropertyContentBuilderTest,org.openjdk.jmc.flightrecorder.controlpanel.ui.model.test.JfcAndServerSettingsCombinationTest,org.openjdk.jmc.rjmx.services.jfr.test.EventMetadataTest,org.openjdk.jmc.rjmx.services.jfr.test.EventTemplateTest,org.openjdk.jmc.rjmx.services.jfr.test.JfrControlTest,org.openjdk.jmc.rjmx.services.jfr.test.JfrPackageExampleTest,org.openjdk.jmc.rjmx.services.jfr.test.OnlineEventOptionsTest,org.openjdk.jmc.rjmx.services.jfr.test.RecordingOptionsTest</jfr.tests>
>> + <jfr.vmargs></jfr.vmargs>
>> + </properties>
>> + </profile>
>> + <profile>
>> <id>uitests</id>
>> <modules>
>> <module>uitests</module>
>> @@ -119,6 +133,8 @@
>> <properties>
>> <maven.compiler.source>1.8</maven.compiler.source>
>> <maven.compiler.target>1.8</maven.compiler.target>
>> + <jfr.tests></jfr.tests>
>> + <jfr.vmargs>-XX:+UnlockCommercialFeatures
>> -XX:+FlightRecorder</jfr.vmargs>
>> </properties>
>>
>> <dependencies>
>> diff -r 896f9586d4c6
>> application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/pom.xml
>> ---
>> a/application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/pom.xml
>> Thu Sep 20 08:32:13 2018 -0700
>> +++
>> b/application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/pom.xml
>> Fri Sep 28 12:13:40 2018 -0400
>> @@ -47,7 +47,7 @@
>> <artifactId>tycho-surefire-plugin</artifactId>
>> <version>${tycho-version}</version>
>> <configuration>
>> - <argLine>-Dcom.sun.management.jmxremote.port=9999
>> -Dcom.sun.management.jmxremote.authenticate=false
>> -Dcom.sun.management.jmxremote.ssl=false
>> -Djava.rmi.server.hostname=localhost
>> -Djmc.test.rjmx.serviceURL=service:jmx:rmi:///jndi/rmi://localhost:9999/jmxrmi
>> -XX:+UnlockCommercialFeatures -XX:+FlightRecorder</argLine>
>> + <argLine>-Dcom.sun.management.jmxremote.port=9999
>> -Dcom.sun.management.jmxremote.authenticate=false
>> -Dcom.sun.management.jmxremote.ssl=false
>> -Djava.rmi.server.hostname=localhost
>> -Djmc.test.rjmx.serviceURL=service:jmx:rmi:///jndi/rmi://localhost:9999/jmxrmi
>> ${jfr.vmargs}</argLine>
>> </configuration>
>> </plugin>
>> </plugins>
>> diff -r 896f9586d4c6
>> application/tests/org.openjdk.jmc.rjmx.services.jfr.test/pom.xml
>> --- a/application/tests/org.openjdk.jmc.rjmx.services.jfr.test/pom.xml
>> Thu Sep 20 08:32:13 2018 -0700
>> +++ b/application/tests/org.openjdk.jmc.rjmx.services.jfr.test/pom.xml
>> Fri Sep 28 12:13:40 2018 -0400
>> @@ -47,8 +47,9 @@
>> <artifactId>tycho-surefire-plugin</artifactId>
>> <version>${tycho-version}</version>
>> <configuration>
>> - <argLine>-Dcom.sun.management.jmxremote.port=9999
>> -Dcom.sun.management.jmxremote.authenticate=false
>> -Dcom.sun.management.jmxremote.ssl=false
>> -Djava.rmi.server.hostname=localhost
>> -Djmc.test.rjmx.serviceURL=service:jmx:rmi:///jndi/rmi://localhost:9999/jmxrmi
>> -XX:+UnlockCommercialFeatures -XX:+FlightRecorder</argLine>
>> - </configuration>
>> + <argLine>-Dcom.sun.management.jmxremote.port=9999
>> -Dcom.sun.management.jmxremote.authenticate=false
>> -Dcom.sun.management.jmxremote.ssl=false
>> -Djava.rmi.server.hostname=localhost
>> -Djmc.test.rjmx.serviceURL=service:jmx:rmi:///jndi/rmi://localhost:9999/jmxrmi
>> ${jfr.vmargs}</argLine>
>> + <failIfNoTests>false</failIfNoTests>
>> + </configuration>
>> </plugin>
>> </plugins>
>> </build>
>> diff -r 896f9586d4c6 application/tests/pom.xml
>> --- a/application/tests/pom.xml Thu Sep 20 08:32:13 2018 -0700
>> +++ b/application/tests/pom.xml Fri Sep 28 12:13:40 2018 -0400
>> @@ -114,7 +114,10 @@
>> <configuration>
>> <appArgLine>-nl en</appArgLine>
>> <includes>${test.includes}</includes>
>> - <excludes>${test.excludes}</excludes>
>> + <excludes>
>> + <exclude>${test.excludes}</exclude>
>> + <exclude>${jfr.tests}</exclude>
>> + </excludes>
>> <failIfNoTests>${fail.if.no.tests}</failIfNoTests>
>> </configuration>
>> </plugin>
>> diff -r 896f9586d4c6 pom.xml
>> --- a/pom.xml Thu Sep 20 08:32:13 2018 -0700
>> +++ b/pom.xml Fri Sep 28 12:13:40 2018 -0400
>> @@ -290,7 +290,7 @@
>> <configuration>
>> <rules>
>> <requireJavaVersion>
>> - <version>[1.8.0-40,9.0.0)</version>
>> + <version>[1.8.0-40,)</version>
>> <message>Building JMC requires Java
>> 8 version JDK 1.8.0_40 or later</message>
>> </requireJavaVersion>
>> </rules>
>> diff -r 896f9586d4c6 releng/third-party/pom.xml
>> --- a/releng/third-party/pom.xml Thu Sep 20 08:32:13 2018 -0700
>> +++ b/releng/third-party/pom.xml Fri Sep 28 12:13:40 2018 -0400
>> @@ -108,7 +108,7 @@
>> <configuration>
>> <rules>
>> <requireJavaVersion>
>> - <version>[1.8.0-40,9.0.0)</version>
>> + <version>[1.8.0-40,)</version>
>> <message>Building JMC requires Java
>> 8 version JDK 1.8.0_40 or later</message>
>> </requireJavaVersion>
>> </rules>
>>
>>
>>
>>
More information about the jmc-dev
mailing list