Review request for JMC-6151:[osx] opening .jfr file on mac fails for first time

Marcus Hirt marcus.hirt at oracle.com
Tue Oct 16 17:30:21 UTC 2018


Looks fine, but let’s see if we can get the Eclipse fix earlier than 4.10.
Also, perhaps you could add some text to the comment, e.g.:

// FIXME: Workaround for Eclipse bug 540164. See JMC-6171.

Would you like me to push it for you?

Kind regards,
Marcus

From: Tejpal Rebari <tejpal.rebari at oracle.com>
Date: Tuesday, 16 October 2018 at 19:12
To: Marcus Hirt <marcus.hirt at oracle.com>
Cc: <jmc-dev at openjdk.java.net>
Subject: Review request for JMC-6151:[osx] opening .jfr file on mac fails for first time

Hi all,

Please review the fix for,
Jira: https://bugs.openjdk.java.net/browse/JMC-5576
webrev: http://cr.openjdk.java.net/~ghb/trebari/JMC-6151/webrev.0/
RC : (Mac OSX) FileDialog.setfilterIndex() doesn't work as expected
Solution: For Mac OSX disabled the filters extension ,so the file dialog shows all the files that are there in the path.While for other OS it works same as before.
Test: Tested on Windows 10, MacOS, Linux.

Thanks,
Tejpal




More information about the jmc-dev mailing list